fix(logs): address PR review — iteration name guard, cost race, mothership retry

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/logs/components/log-details/log-details.tsx

@@ -411,22 +411,24 @@ export const LogDetails = memo(function LogDetails({
             <div className='flex items-center justify-between'>
               <h2 className='font-medium text-[var(--text-primary)] text-sm'>Log Details</h2>
               <div className='flex items-center gap-[1px]'>
-                {log?.status === 'failed' && (log?.workflow?.id || log?.workflowId) && (
-                  <Tooltip.Root>
-                    <Tooltip.Trigger asChild>
-                      <Button
-                        variant='ghost'
-                        className='!p-1'
-                        onClick={() => onRetryExecution?.()}
-                        disabled={isRetryPending}
-                        aria-label='Retry execution'
-                      >
-                        <Redo className='h-[14px] w-[14px]' />
-                      </Button>
-                    </Tooltip.Trigger>
-                    <Tooltip.Content side='bottom'>Retry</Tooltip.Content>
-                  </Tooltip.Root>
-                )}
+                {log?.status === 'failed' &&
+                  (log?.workflow?.id || log?.workflowId) &&
+                  log?.trigger !== 'mothership' && (
+                    <Tooltip.Root>
+                      <Tooltip.Trigger asChild>
+                        <Button
+                          variant='ghost'
+                          className='!p-1'
+                          onClick={() => onRetryExecution?.()}
+                          disabled={isRetryPending}
+                          aria-label='Retry execution'
+                        >
+                          <Redo className='h-[14px] w-[14px]' />
+                        </Button>
+                      </Tooltip.Trigger>
+                      <Tooltip.Content side='bottom'>Retry</Tooltip.Content>
+                    </Tooltip.Root>
+                  )}
                 <Button
                   variant='ghost'
                   className='!p-1'

apps/sim/app/workspace/[workspaceId]/logs/components/log-row-context-menu/log-row-context-menu.tsx

@@ -54,7 +54,7 @@ export const LogRowContextMenu = memo(function LogRowContextMenu({
   const hasWorkflow = Boolean(log?.workflow?.id || log?.workflowId)
   const isCancellable =
     (log?.status === 'running' || log?.status === 'pending') && hasExecutionId && hasWorkflow
-  const isRetryable = log?.status === 'failed' && hasWorkflow
+  const isRetryable = log?.status === 'failed' && hasWorkflow && log?.trigger !== 'mothership'
 
   return (
     <DropdownMenu open={isOpen} onOpenChange={(open) => !open && onClose()} modal={false}>

apps/sim/lib/logs/execution/logging-session.ts

@@ -285,6 +285,46 @@ export class LoggingSession {
     blockType: string,
     output: any
   ): Promise<void> {
+    // Accumulate cost synchronously before any await so that fire-and-forget
+    // callers still capture the full cost even if DB writes are not awaited.
+    const blockOutput = output?.output
+    if (
+      blockOutput?.cost &&
+      typeof blockOutput.cost.total === 'number' &&
+      blockOutput.cost.total > 0
+    ) {
+      const { cost, tokens, model } = blockOutput
+
+      this.accumulatedCost.total += cost.total || 0
+      this.accumulatedCost.input += cost.input || 0
+      this.accumulatedCost.output += cost.output || 0
+
+      if (tokens) {
+        this.accumulatedCost.tokens.input += tokens.input || 0
+        this.accumulatedCost.tokens.output += tokens.output || 0
+        this.accumulatedCost.tokens.total += tokens.total || 0
+      }
+
+      if (model) {
+        if (!this.accumulatedCost.models[model]) {
+          this.accumulatedCost.models[model] = {
+            input: 0,
+            output: 0,
+            total: 0,
+            tokens: { input: 0, output: 0, total: 0 },
+          }
+        }
+        this.accumulatedCost.models[model].input += cost.input || 0
+        this.accumulatedCost.models[model].output += cost.output || 0
+        this.accumulatedCost.models[model].total += cost.total || 0
+        if (tokens) {
+          this.accumulatedCost.models[model].tokens.input += tokens.input || 0
+          this.accumulatedCost.models[model].tokens.output += tokens.output || 0
+          this.accumulatedCost.models[model].tokens.total += tokens.total || 0
+        }
+      }
+    }
+
     await this.trackProgressWrite(
       this.persistLastCompletedBlock({
         blockId,
@@ -295,47 +335,13 @@ export class LoggingSession {
       })
     )
 
-    const blockOutput = output?.output
     if (
-      !blockOutput?.cost ||
-      typeof blockOutput.cost.total !== 'number' ||
-      blockOutput.cost.total <= 0
+      blockOutput?.cost &&
+      typeof blockOutput.cost.total === 'number' &&
+      blockOutput.cost.total > 0
     ) {
-      return
+      void this.trackProgressWrite(this.flushAccumulatedCost())
     }
-
-    const { cost, tokens, model } = blockOutput
-
-    this.accumulatedCost.total += cost.total || 0
-    this.accumulatedCost.input += cost.input || 0
-    this.accumulatedCost.output += cost.output || 0
-
-    if (tokens) {
-      this.accumulatedCost.tokens.input += tokens.input || 0
-      this.accumulatedCost.tokens.output += tokens.output || 0
-      this.accumulatedCost.tokens.total += tokens.total || 0
-    }
-
-    if (model) {
-      if (!this.accumulatedCost.models[model]) {
-        this.accumulatedCost.models[model] = {
-          input: 0,
-          output: 0,
-          total: 0,
-          tokens: { input: 0, output: 0, total: 0 },
-        }
-      }
-      this.accumulatedCost.models[model].input += cost.input || 0
-      this.accumulatedCost.models[model].output += cost.output || 0
-      this.accumulatedCost.models[model].total += cost.total || 0
-      if (tokens) {
-        this.accumulatedCost.models[model].tokens.input += tokens.input || 0
-        this.accumulatedCost.models[model].tokens.output += tokens.output || 0
-        this.accumulatedCost.models[model].tokens.total += tokens.total || 0
-      }
-    }
-
-    void this.trackProgressWrite(this.flushAccumulatedCost())
   }
 
   private async flushAccumulatedCost(): Promise<void> {

apps/sim/lib/logs/execution/trace-spans/iteration-grouping.ts

@@ -226,7 +226,8 @@ function groupIterationBlocksRecursive(
 
   for (const span of spans) {
     if (
-      span.name.match(/^(.+) \(iteration (\d+)\)$/) ||
+      (span.name.match(/^(.+) \(iteration (\d+)\)$/) &&
+        (span.loopId || span.parallelId || span.blockId?.includes('_parallel_'))) ||
       (span.parentIterations && span.parentIterations.length > 0)
     ) {
       iterationSpans.push(span)