Skip to content

Commit ae753cb

Browse files
icecrasher321claude
andcommitted
fix(ci): pin the sandbox flag in the second nav catalog test, bump the chart
Two CI failures, both mine. `app/workspace/[workspaceId]/settings/navigation.test.ts` asserts the unified catalog and was left on ambient env. Dropping the Sandboxes section without a sandbox provider made it 26 items instead of 27 on CI, which has no `apps/sim/.env` — the same trap already fixed in the sibling `components/settings/navigation.test.ts`, in the one file that was missed. Fixing it needs `vi.hoisted` rather than the sibling's `beforeEach`, because this file reads `allNavigationItems`, built once at module load; a hook would run after the value it is trying to influence already exists. The chart gate is separate: this branch adds sandbox settings to `helm/sim/values.yaml`, and the workflow requires a Chart.yaml bump whenever `helm/sim/**` changes. Additive config, so 1.3.0 -> 1.4.0 by SemVer. Verified by running the whole suite with the flags forced off, not just the two navigation files — no other test depends on a local env file. Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 6fca142 commit ae753cb

2 files changed

Lines changed: 14 additions & 2 deletions

File tree

apps/sim/app/workspace/[workspaceId]/settings/navigation.test.ts

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,16 @@
1-
import { describe, expect, it } from 'vitest'
1+
import { describe, expect, it, vi } from 'vitest'
2+
3+
/**
4+
* The Sandboxes section is dropped when no sandbox provider is configured, and
5+
* `allNavigationItems` is built once at module load — so this has to be set before
6+
* the module graph is imported, where a `beforeEach` would run too late. Pinning it
7+
* also keeps the catalog assertions off the developer's untracked `apps/sim/.env`,
8+
* which CI does not have.
9+
*/
10+
vi.hoisted(() => {
11+
process.env.NEXT_PUBLIC_SANDBOX_ENABLED = 'true'
12+
})
13+
214
import {
315
SETTINGS_SECTION_REGISTRY,
416
WORKSPACE_SETTINGS_ITEMS,

helm/sim/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: sim
33
description: A Helm chart for Sim - the open-source AI workspace where teams build, deploy, and manage AI agents
44
type: application
5-
version: 1.3.0
5+
version: 1.4.0
66
appVersion: "v0.7.44"
77
kubeVersion: ">=1.25.0-0"
88
home: https://sim.ai

0 commit comments

Comments
 (0)