fix(quickbooks): validate calculated sales amounts

Bill Leoutsakos · Bill Leoutsakos · commit ad88f00a382d · 2026-08-01T11:40:53.000-07:00
diff --git a/apps/docs/content/docs/en/integrations/quickbooks.mdx b/apps/docs/content/docs/en/integrations/quickbooks.mdx
@@ -188,8 +188,8 @@ List or read one account, customer, vendor, item, or employee
 |   ↳ `InvStartDate` | string | Inventory tracking start date |
 |   ↳ `PrimaryAddr` | json | Employee primary address |
 |   ↳ `BillableTime` | boolean | Whether employee time is billable |
-| `startPosition` | number | One-based position of the first item in this response |
-| `maxResults` | number | Actual number of items reported for this response |
+| `startPosition` | number | One-based position of the first record in this page |
+| `maxResults` | number | Actual number of records returned in this page |
 | `nextStartPosition` | number | Position to use when explicitly requesting the next page |
 | `hasMore` | boolean | Conservative indication that another page may exist |
 | `time` | string | QuickBooks response timestamp |
@@ -449,15 +449,14 @@ Create a Service or Non-inventory item in QuickBooks Online
 
 ### `quickbooks_update_item`
 
-Sparse-update a Service or Non-inventory item in QuickBooks Online
+Sparse-update supported fields on an item without changing its type
 
 #### Input
 
 | Parameter | Type | Required | Description |
 | --------- | ---- | -------- | ----------- |
 | `itemId` | string | Yes | ID of the item to update |
 | `syncToken` | string | Yes | Current item sync token |
-| `itemType` | string | Yes | Current item type: service or non_inventory |
 | `name` | string | No | Replacement item name |
 | `incomeAccountId` | string | No | Replacement income account ID |
 | `description` | string | No | Replacement sales description |
diff --git a/apps/sim/blocks/blocks/quickbooks.ts b/apps/sim/blocks/blocks/quickbooks.ts
@@ -573,7 +573,7 @@ export const QuickBooksBlock: BlockConfig<QuickBooksResponse> = {
       wandConfig: {
         enabled: true,
         prompt:
-          'Generate a JSON array of QuickBooks sales lines. Use item lines with lineType, positive amount, itemId, and optional description, quantity, unitPrice, and serviceDate; or description lines with lineType and description. Return ONLY the JSON array - no explanations, no extra text.',
+          'Generate a JSON array of QuickBooks sales lines. Use item lines with lineType, positive amount, itemId, and optional description, positive quantity, positive unitPrice, and serviceDate. When quantity and unitPrice are both present, amount must equal quantity multiplied by unitPrice. Use description lines with lineType and description. Return ONLY the JSON array - no explanations, no extra text.',
         generationType: 'json-object',
       },
     },
diff --git a/apps/sim/tools/quickbooks/create_credit_memo.ts b/apps/sim/tools/quickbooks/create_credit_memo.ts
@@ -1,9 +1,6 @@
 import { ErrorExtractorId } from '@/tools/error-extractors'
 import { QUICKBOOKS_MAX_RESPONSE_BYTES } from '@/tools/quickbooks/client'
-import {
-  addQuickBooksRequestId,
-  buildQuickBooksCreateSalesDocumentBody,
-} from '@/tools/quickbooks/sales_utils'
+import { buildQuickBooksCreateSalesDocumentBody } from '@/tools/quickbooks/sales_utils'
 import type {
   QuickBooksCreateCreditMemoParams,
   QuickBooksMutationResponse,
@@ -14,6 +11,7 @@ import {
   QUICKBOOKS_SALES_TRANSACTION_PROPERTIES,
 } from '@/tools/quickbooks/types'
 import {
+  addQuickBooksRequestId,
   buildQuickBooksEntityUrl,
   getQuickBooksToolHeaders,
   transformQuickBooksMutationResponse,
diff --git a/apps/sim/tools/quickbooks/create_customer_payment.ts b/apps/sim/tools/quickbooks/create_customer_payment.ts
@@ -1,9 +1,6 @@
 import { ErrorExtractorId } from '@/tools/error-extractors'
 import { QUICKBOOKS_MAX_RESPONSE_BYTES } from '@/tools/quickbooks/client'
-import {
-  addQuickBooksRequestId,
-  buildQuickBooksCreatePaymentBody,
-} from '@/tools/quickbooks/sales_utils'
+import { buildQuickBooksCreatePaymentBody } from '@/tools/quickbooks/sales_utils'
 import type {
   QuickBooksCreateCustomerPaymentParams,
   QuickBooksMutationResponse,
@@ -14,6 +11,7 @@ import {
   QUICKBOOKS_SALES_TRANSACTION_PROPERTIES,
 } from '@/tools/quickbooks/types'
 import {
+  addQuickBooksRequestId,
   buildQuickBooksEntityUrl,
   getQuickBooksToolHeaders,
   transformQuickBooksMutationResponse,
diff --git a/apps/sim/tools/quickbooks/create_estimate.ts b/apps/sim/tools/quickbooks/create_estimate.ts
@@ -1,9 +1,6 @@
 import { ErrorExtractorId } from '@/tools/error-extractors'
 import { QUICKBOOKS_MAX_RESPONSE_BYTES } from '@/tools/quickbooks/client'
-import {
-  addQuickBooksRequestId,
-  buildQuickBooksCreateSalesDocumentBody,
-} from '@/tools/quickbooks/sales_utils'
+import { buildQuickBooksCreateSalesDocumentBody } from '@/tools/quickbooks/sales_utils'
 import type {
   QuickBooksCreateEstimateParams,
   QuickBooksMutationResponse,
@@ -14,6 +11,7 @@ import {
   QUICKBOOKS_SALES_TRANSACTION_PROPERTIES,
 } from '@/tools/quickbooks/types'
 import {
+  addQuickBooksRequestId,
   buildQuickBooksEntityUrl,
   getQuickBooksToolHeaders,
   transformQuickBooksMutationResponse,
diff --git a/apps/sim/tools/quickbooks/create_invoice.ts b/apps/sim/tools/quickbooks/create_invoice.ts
@@ -1,9 +1,6 @@
 import { ErrorExtractorId } from '@/tools/error-extractors'
 import { QUICKBOOKS_MAX_RESPONSE_BYTES } from '@/tools/quickbooks/client'
-import {
-  addQuickBooksRequestId,
-  buildQuickBooksCreateSalesDocumentBody,
-} from '@/tools/quickbooks/sales_utils'
+import { buildQuickBooksCreateSalesDocumentBody } from '@/tools/quickbooks/sales_utils'
 import type {
   QuickBooksCreateInvoiceParams,
   QuickBooksMutationResponse,
@@ -14,6 +11,7 @@ import {
   QUICKBOOKS_SALES_TRANSACTION_PROPERTIES,
 } from '@/tools/quickbooks/types'
 import {
+  addQuickBooksRequestId,
   buildQuickBooksEntityUrl,
   getQuickBooksToolHeaders,
   transformQuickBooksMutationResponse,
diff --git a/apps/sim/tools/quickbooks/create_refund_receipt.ts b/apps/sim/tools/quickbooks/create_refund_receipt.ts
@@ -1,9 +1,6 @@
 import { ErrorExtractorId } from '@/tools/error-extractors'
 import { QUICKBOOKS_MAX_RESPONSE_BYTES } from '@/tools/quickbooks/client'
-import {
-  addQuickBooksRequestId,
-  buildQuickBooksCreateSalesDocumentBody,
-} from '@/tools/quickbooks/sales_utils'
+import { buildQuickBooksCreateSalesDocumentBody } from '@/tools/quickbooks/sales_utils'
 import type {
   QuickBooksCreateRefundReceiptParams,
   QuickBooksMutationResponse,
@@ -14,6 +11,7 @@ import {
   QUICKBOOKS_SALES_TRANSACTION_PROPERTIES,
 } from '@/tools/quickbooks/types'
 import {
+  addQuickBooksRequestId,
   buildQuickBooksEntityUrl,
   getQuickBooksToolHeaders,
   transformQuickBooksMutationResponse,
diff --git a/apps/sim/tools/quickbooks/create_sales_receipt.ts b/apps/sim/tools/quickbooks/create_sales_receipt.ts
@@ -1,9 +1,6 @@
 import { ErrorExtractorId } from '@/tools/error-extractors'
 import { QUICKBOOKS_MAX_RESPONSE_BYTES } from '@/tools/quickbooks/client'
-import {
-  addQuickBooksRequestId,
-  buildQuickBooksCreateSalesDocumentBody,
-} from '@/tools/quickbooks/sales_utils'
+import { buildQuickBooksCreateSalesDocumentBody } from '@/tools/quickbooks/sales_utils'
 import type {
   QuickBooksCreateSalesReceiptParams,
   QuickBooksMutationResponse,
@@ -14,6 +11,7 @@ import {
   QUICKBOOKS_SALES_TRANSACTION_PROPERTIES,
 } from '@/tools/quickbooks/types'
 import {
+  addQuickBooksRequestId,
   buildQuickBooksEntityUrl,
   getQuickBooksToolHeaders,
   transformQuickBooksMutationResponse,
diff --git a/apps/sim/tools/quickbooks/quickbooks.test.ts b/apps/sim/tools/quickbooks/quickbooks.test.ts
@@ -4,12 +4,6 @@ import { afterEach, beforeEach, describe, expect, it } from 'vitest'
 import { evaluateOutputCondition } from '@/lib/workflows/blocks/block-outputs'
 import { evaluateSubBlockCondition } from '@/lib/workflows/subblocks/visibility'
 import { QuickBooksBlock } from '@/blocks/blocks/quickbooks'
-import {
-  fetchValidatedQuickBooksCompanyInfo,
-  getQuickBooksEnvironment,
-  getQuickBooksUserInfoUrl,
-  QUICKBOOKS_MAX_RESPONSE_BYTES,
-} from '@/tools/quickbooks/client'
 import {
   quickbooksCreateCreditMemoTool,
   quickbooksCreateCustomerPaymentTool,
@@ -27,6 +21,12 @@ import {
   quickbooksVoidCustomerPaymentTool,
   quickbooksVoidInvoiceTool,
 } from '@/tools/quickbooks'
+import {
+  fetchValidatedQuickBooksCompanyInfo,
+  getQuickBooksEnvironment,
+  getQuickBooksUserInfoUrl,
+  QUICKBOOKS_MAX_RESPONSE_BYTES,
+} from '@/tools/quickbooks/client'
 import { quickbooksCreateCustomerTool } from '@/tools/quickbooks/create_customer'
 import { quickbooksCreateItemTool } from '@/tools/quickbooks/create_item'
 import { quickbooksCreateVendorTool } from '@/tools/quickbooks/create_vendor'
diff --git a/apps/sim/tools/quickbooks/sales.test.ts b/apps/sim/tools/quickbooks/sales.test.ts
@@ -191,6 +191,32 @@ describe('QuickBooks sales document validation and bodies', () => {
     expect(() => parseQuickBooksSalesLines('[{"lineType":"item","amount":1,"itemId":7}]')).toThrow(
       'itemId must be a string'
     )
+    expect(() =>
+      parseQuickBooksSalesLines('[{"lineType":"item","amount":10,"itemId":"7","quantity":0}]')
+    ).toThrow('quantity must be a positive finite number')
+    expect(() =>
+      parseQuickBooksSalesLines('[{"lineType":"item","amount":10,"itemId":"7","unitPrice":-1}]')
+    ).toThrow('unitPrice must be a positive finite number')
+    expect(() =>
+      parseQuickBooksSalesLines(
+        '[{"lineType":"item","amount":10,"itemId":"7","quantity":2,"unitPrice":6}]'
+      )
+    ).toThrow('amount must equal quantity multiplied by unitPrice')
+    expect(
+      parseQuickBooksSalesLines(
+        '[{"lineType":"item","amount":0.02,"itemId":"7","quantity":0.1,"unitPrice":0.2}]'
+      )
+    ).toEqual([
+      {
+        lineType: 'item',
+        amount: 0.02,
+        itemId: '7',
+        description: undefined,
+        quantity: 0.1,
+        unitPrice: 0.2,
+        serviceDate: undefined,
+      },
+    ])
     expect(() =>
       parseQuickBooksSalesLines(
         '[{"lineType":"item","amount":1,"itemId":"7","serviceDate":"2026-02-30"}]'
diff --git a/apps/sim/tools/quickbooks/sales_utils.ts b/apps/sim/tools/quickbooks/sales_utils.ts
@@ -68,10 +68,12 @@ function requiredPositiveNumber(value: unknown, fieldName: string): number {
   return parsed
 }
 
-function optionalFiniteNumber(value: unknown, fieldName: string): number | undefined {
+function optionalPositiveNumber(value: unknown, fieldName: string): number | undefined {
   if (value == null || value === '') return undefined
   const parsed = typeof value === 'number' ? value : Number(value)
-  if (!Number.isFinite(parsed)) throw new Error(`${fieldName} must be a finite number`)
+  if (!Number.isFinite(parsed) || parsed <= 0) {
+    throw new Error(`${fieldName} must be a positive finite number`)
+  }
   return parsed
 }
 
@@ -126,13 +128,23 @@ export function parseQuickBooksSalesLines(
     }
     assertAllowedKeys(line, ITEM_LINE_KEYS, itemName)
     const description = optionalStringValue(line.description, `${itemName}.description`)
+    const amount = requiredPositiveNumber(line.amount, `${itemName}.amount`)
+    const quantity = optionalPositiveNumber(line.quantity, `${itemName}.quantity`)
+    const unitPrice = optionalPositiveNumber(line.unitPrice, `${itemName}.unitPrice`)
+    if (
+      quantity !== undefined &&
+      unitPrice !== undefined &&
+      !new Decimal(quantity).times(unitPrice).toDecimalPlaces(2).equals(new Decimal(amount))
+    ) {
+      throw new Error(`${itemName}.amount must equal quantity multiplied by unitPrice`)
+    }
     return {
       lineType: 'item',
-      amount: requiredPositiveNumber(line.amount, `${itemName}.amount`),
+      amount,
       itemId: requiredStringValue(line.itemId, `${itemName}.itemId`),
       description,
-      quantity: optionalFiniteNumber(line.quantity, `${itemName}.quantity`),
-      unitPrice: optionalFiniteNumber(line.unitPrice, `${itemName}.unitPrice`),
+      quantity,
+      unitPrice,
       serviceDate: validateQuickBooksDate(
         optionalStringValue(line.serviceDate, `${itemName}.serviceDate`),
         `${itemName}.serviceDate`
