fix(agiloft): address PR review feedback

Author: waleedlatif1

apps/sim/tools/agiloft/get_choice_line_id.ts

@@ -104,8 +104,16 @@ export const agiloftGetChoiceLineIdTool: ToolConfig<
           }
         }
 
+        if (choiceLineId === null) {
+          return {
+            success: false,
+            output: { choiceLineId: null },
+            error: `No choice line ID found for value "${params.value}" in field "${params.fieldName}"`,
+          }
+        }
+
         return {
-          success: data.success !== false && choiceLineId !== null,
+          success: data.success !== false,
           output: { choiceLineId },
         }
       }

apps/sim/tools/agiloft/search_records.ts

@@ -100,10 +100,6 @@ export const agiloftSearchRecordsTool: ToolConfig<
           for (const item of result as Record<string, unknown>[]) {
             records.push(item)
           }
-        } else if (Array.isArray(data)) {
-          for (const item of data as Record<string, unknown>[]) {
-            records.push(item)
-          }
         } else {
           const lengthRaw = result.EWREST_length ?? data.EWREST_length
           const count = typeof lengthRaw === 'string' ? Number(lengthRaw) : (lengthRaw as number)

apps/sim/tools/agiloft/utils.ts

@@ -249,7 +249,7 @@ export function buildGetChoiceLineIdUrl(
   params: AgiloftGetChoiceLineIdParams
 ): string {
   const field = encodeURIComponent(params.fieldName.trim())
-  const value = encodeURIComponent(params.value)
+  const value = encodeURIComponent(params.value.trim())
   return `${base}/ewws/EWGetChoiceLineId/.json?${buildEwBaseQuery(params)}&field=${field}&value=${value}`
 }