Skip to content

Commit 6df18b0

Browse files
Bill LeoutsakosBill Leoutsakos
authored andcommitted
refactor(quickbooks): align integration architecture
1 parent 970d3b1 commit 6df18b0

14 files changed

Lines changed: 17 additions & 17 deletions

apps/sim/lib/auth/auth.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,9 @@ import { clearDeadFlag } from '@/lib/oauth/terminal-errors'
115115
import { getCanonicalScopesForProvider } from '@/lib/oauth/utils'
116116
import { joinInstanceOrganization } from '@/lib/organizations/instance-org'
117117
import { captureServerEvent, getPostHogClient } from '@/lib/posthog/server'
118-
import { QUICKBOOKS_OAUTH_REQUEST_TIMEOUT_MS } from '@/lib/quickbooks/client'
119118
import { disableUserResources } from '@/lib/workflows/lifecycle'
120119
import { SSO_TRUSTED_PROVIDERS } from '@/ee/sso/constants'
120+
import { QUICKBOOKS_OAUTH_REQUEST_TIMEOUT_MS } from '@/tools/quickbooks/client'
121121

122122
const logger = createLogger('Auth')
123123

apps/sim/lib/oauth/quickbooks.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
QUICKBOOKS_TOKEN_URL,
1212
withQuickBooksCallbackRealm,
1313
} from '@/lib/oauth/quickbooks'
14-
import { QUICKBOOKS_MAX_USER_INFO_BYTES } from '@/lib/quickbooks/client'
14+
import { QUICKBOOKS_MAX_USER_INFO_BYTES } from '@/tools/quickbooks/client'
1515

1616
const TEST_UUID = '01234567-89ab-4def-8abc-0123456789ab'
1717
const originalFetch = global.fetch

apps/sim/lib/oauth/quickbooks.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
normalizeQuickBooksRealmId as normalizeRealmId,
1111
QUICKBOOKS_MAX_USER_INFO_BYTES,
1212
QUICKBOOKS_OAUTH_REQUEST_TIMEOUT_MS,
13-
} from '@/lib/quickbooks/client'
13+
} from '@/tools/quickbooks/client'
1414

1515
const QUICKBOOKS_ACCOUNT_PREFIX = 'quickbooks:'
1616
const UUID_SUFFIX_PATTERN =

apps/sim/tools/error-extractors.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,4 +379,4 @@ export const ErrorExtractorId = {
379379
HTTP_STATUS_TEXT: 'http-status-text',
380380
} as const
381381

382-
import { formatQuickBooksFaultDetail, sanitizeQuickBooksFaultData } from '@/lib/quickbooks/fault'
382+
import { formatQuickBooksFaultDetail, sanitizeQuickBooksFaultData } from '@/tools/quickbooks/fault'

apps/sim/tools/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import { isSameOrigin } from '@/lib/core/utils/validation'
3030
import { SIM_VIA_HEADER, serializeCallChain } from '@/lib/execution/call-chain'
3131
import { parseMcpToolId } from '@/lib/mcp/utils'
3232
import { hostedKeyMetrics } from '@/lib/monitoring/metrics'
33-
import { sanitizeQuickBooksFaultData } from '@/lib/quickbooks/fault'
3433
import { resolveWorkspaceFileReference } from '@/lib/uploads/contexts/workspace/workspace-file-manager'
3534
import { assertPermissionsAllowed } from '@/ee/access-control/utils/permission-check'
3635
import { isCustomTool, isMcpTool } from '@/executor/constants'
@@ -40,6 +39,7 @@ import { resolveEnvVarReferences } from '@/executor/utils/reference-validation'
4039
import type { ErrorInfo } from '@/tools/error-extractors'
4140
import { ErrorExtractorId, extractErrorMessage } from '@/tools/error-extractors'
4241
import { HostedKeyRateLimitedError, HostedKeyUnavailableError } from '@/tools/errors'
42+
import { sanitizeQuickBooksFaultData } from '@/tools/quickbooks/fault'
4343
import type {
4444
BYOKProviderId,
4545
OAuthTokenPayload,
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import {
33
readResponseJsonWithLimit,
44
readResponseTextWithLimit,
55
} from '@/lib/core/utils/stream-limits'
6-
import { formatQuickBooksFaultDetail, sanitizeQuickBooksFaultData } from '@/lib/quickbooks/fault'
6+
import { formatQuickBooksFaultDetail, sanitizeQuickBooksFaultData } from '@/tools/quickbooks/fault'
77

88
export const QUICKBOOKS_MINOR_VERSION = '75'
99
export const QUICKBOOKS_MAX_RESPONSE_BYTES = 8 * 1024 * 1024

apps/sim/tools/quickbooks/error-extractor.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { describe, expect, it } from 'vitest'
2-
import { sanitizeQuickBooksFaultData } from '@/lib/quickbooks/fault'
32
import { ErrorExtractorId, extractErrorMessage } from '@/tools/error-extractors'
3+
import { sanitizeQuickBooksFaultData } from '@/tools/quickbooks/fault'
44

55
describe('QuickBooks fault extraction', () => {
66
it('parses Fault.Error entries with HTTP and tracking guidance', () => {

apps/sim/tools/quickbooks/get_company_info.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1+
import { ErrorExtractorId } from '@/tools/error-extractors'
12
import {
23
buildQuickBooksCompanyUrl,
34
normalizeQuickBooksRealmId,
45
QUICKBOOKS_MAX_RESPONSE_BYTES,
5-
} from '@/lib/quickbooks/client'
6-
import { ErrorExtractorId } from '@/tools/error-extractors'
6+
} from '@/tools/quickbooks/client'
77
import type {
88
QuickBooksAuthParams,
99
QuickBooksCompanyInfo,

apps/sim/tools/quickbooks/list_bills.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { QUICKBOOKS_MAX_RESPONSE_BYTES } from '@/lib/quickbooks/client'
21
import { ErrorExtractorId } from '@/tools/error-extractors'
2+
import { QUICKBOOKS_MAX_RESPONSE_BYTES } from '@/tools/quickbooks/client'
33
import type {
44
QuickBooksBill,
55
QuickBooksListResponse,

0 commit comments

Comments
 (0)