Skip to content

Commit 6cc326b

Browse files
waleedlatif1claude
andcommitted
fix(sap-concur): drop SCIM list_users filter param (not supported on v4.1 GET)
SCIM Identity v4.1 GET /Users does not accept a filter query parameter — filtering is only supported via POST /Users/.search (already exposed by sap_concur_search_users). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 6f8b574 commit 6cc326b

6 files changed

Lines changed: 6 additions & 44 deletions

File tree

apps/sim/blocks/blocks/sap_concur.ts

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ const EXPENSE_READ_CONTEXT_TYPE_OPS = [
4444
'sap_concur_list_expenses',
4545
'sap_concur_get_expense',
4646
'sap_concur_get_itemizations',
47-
'sap_concur_create_report_comment',
48-
'sap_concur_list_report_comments',
4947
'sap_concur_list_exceptions',
5048
]
5149

@@ -60,6 +58,8 @@ const ATTENDEE_CONTEXT_TYPE_OPS = [
6058
'sap_concur_list_attendee_associations',
6159
'sap_concur_associate_attendees',
6260
'sap_concur_remove_all_attendees',
61+
'sap_concur_create_report_comment',
62+
'sap_concur_list_report_comments',
6363
]
6464

6565
const ALLOCATION_CONTEXT_TYPE_OPS = [
@@ -1104,18 +1104,6 @@ export const SapConcurBlock: BlockConfig<SapConcurProxyResponse> = {
11041104
placeholder: '200',
11051105
condition: { field: 'operation', value: 'sap_concur_list_travel_profiles_summary' },
11061106
},
1107-
{
1108-
id: 'travelProfileActive',
1109-
title: 'Active Filter',
1110-
type: 'dropdown',
1111-
options: [
1112-
{ label: 'Any', id: '' },
1113-
{ label: 'Active', id: '1' },
1114-
{ label: 'Inactive', id: '0' },
1115-
],
1116-
value: () => '',
1117-
condition: { field: 'operation', value: 'sap_concur_list_travel_profiles_summary' },
1118-
},
11191107
{
11201108
id: 'travelConfigs',
11211109
title: 'Travel Config IDs',
@@ -1721,10 +1709,6 @@ export const SapConcurBlock: BlockConfig<SapConcurProxyResponse> = {
17211709
lastModifiedDate: params.lastModifiedDate,
17221710
page: params.travelProfilePage ? Number(params.travelProfilePage) : undefined,
17231711
itemsPerPage: params.itemsPerPage ? Number(params.itemsPerPage) : undefined,
1724-
active:
1725-
params.travelProfileActive === '1' || params.travelProfileActive === '0'
1726-
? params.travelProfileActive
1727-
: undefined,
17281712
travelConfigs: params.travelConfigs || undefined,
17291713
}
17301714
case 'sap_concur_search_locations':
@@ -1885,10 +1869,6 @@ export const SapConcurBlock: BlockConfig<SapConcurProxyResponse> = {
18851869
page: { type: 'number', description: 'Page number (lists/list_items)' },
18861870
travelProfilePage: { type: 'number', description: 'Profile summary page number' },
18871871
itemsPerPage: { type: 'number', description: 'Profile summary items per page' },
1888-
travelProfileActive: {
1889-
type: 'string',
1890-
description: 'Active filter ("1" for active, "0" for inactive)',
1891-
},
18921872
travelConfigs: { type: 'string', description: 'Comma-separated travel config ids' },
18931873
searchText: { type: 'string', description: 'Locations v5 free-text search' },
18941874
locCode: { type: 'string', description: 'Locations v5 location code' },

apps/sim/tools/sap_concur/create_report_comment.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export const createReportCommentTool: ToolConfig<
6969
type: 'string',
7070
required: true,
7171
visibility: 'user-or-llm',
72-
description: 'Access context: TRAVELER, MANAGER, or PROXY',
72+
description: 'Access context: TRAVELER or PROXY',
7373
},
7474
reportId: {
7575
type: 'string',

apps/sim/tools/sap_concur/list_report_comments.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ export const listReportCommentsTool: ToolConfig<ListReportCommentsParams, SapCon
6868
type: 'string',
6969
required: true,
7070
visibility: 'user-or-llm',
71-
description: 'Access context: TRAVELER, MANAGER, or PROXY',
71+
description: 'Access context: TRAVELER or PROXY',
7272
},
7373
reportId: {
7474
type: 'string',

apps/sim/tools/sap_concur/list_travel_profiles_summary.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -81,13 +81,6 @@ export const listTravelProfilesSummaryTool: ToolConfig<
8181
visibility: 'user-or-llm',
8282
description: 'Items per page (max 200)',
8383
},
84-
active: {
85-
type: 'string',
86-
required: false,
87-
visibility: 'user-or-llm',
88-
description:
89-
'Active filter (sent as Active query param): "1" (active) or "0" (inactive). Omit for all.',
90-
},
9184
travelConfigs: {
9285
type: 'string',
9386
required: false,
@@ -105,7 +98,6 @@ export const listTravelProfilesSummaryTool: ToolConfig<
10598
LastModifiedDate: lastModifiedDate,
10699
Page: params.page,
107100
ItemsPerPage: params.itemsPerPage,
108-
Active: params.active,
109101
travelConfigs: params.travelConfigs,
110102
})
111103
return {

apps/sim/tools/sap_concur/list_users.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,6 @@ export const listUsersTool: ToolConfig<ListUsersParams, SapConcurProxyResponse>
6868
visibility: 'user-or-llm',
6969
description: 'SCIM v4.1 pagination cursor returned by a prior call',
7070
},
71-
filter: {
72-
type: 'string',
73-
required: false,
74-
visibility: 'user-or-llm',
75-
description:
76-
'SCIM filter expression. Supported attributes: userName, employeeNumber, externalId.',
77-
},
7871
attributes: {
7972
type: 'string',
8073
required: false,
@@ -99,7 +92,6 @@ export const listUsersTool: ToolConfig<ListUsersParams, SapConcurProxyResponse>
9992
query: buildListQuery({
10093
count: params.count,
10194
cursor: params.cursor,
102-
filter: params.filter,
10395
attributes: params.attributes,
10496
excludedAttributes: params.excludedAttributes,
10597
}),

apps/sim/tools/sap_concur/types.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,14 +178,14 @@ export interface RemoveAllAttendeesParams extends SapConcurBaseParams {
178178

179179
export interface ListReportCommentsParams extends SapConcurBaseParams {
180180
userId: string
181-
contextType: 'TRAVELER' | 'MANAGER' | 'PROXY'
181+
contextType: 'TRAVELER' | 'PROXY'
182182
reportId: string
183183
includeAllComments?: boolean
184184
}
185185

186186
export interface CreateReportCommentParams extends SapConcurBaseParams {
187187
userId: string
188-
contextType: 'TRAVELER' | 'MANAGER' | 'PROXY'
188+
contextType: 'TRAVELER' | 'PROXY'
189189
reportId: string
190190
comment: string
191191
}
@@ -327,7 +327,6 @@ export interface GetItineraryParams extends SapConcurBaseParams {
327327
export interface ListUsersParams extends SapConcurBaseParams {
328328
count?: number
329329
cursor?: string
330-
filter?: string
331330
attributes?: string
332331
excludedAttributes?: string
333332
}
@@ -366,7 +365,6 @@ export interface ListTravelProfilesSummaryParams extends SapConcurBaseParams {
366365
lastModifiedDate: string
367366
page?: number
368367
itemsPerPage?: number
369-
active?: 'Active' | 'Inactive'
370368
travelConfigs?: string
371369
}
372370

0 commit comments

Comments
 (0)