fix(quickbooks): validate master data inputs

Bill Leoutsakos · Bill Leoutsakos · commit 64f660b624d2 · 2026-08-02T21:41:59.000-07:00
diff --git a/apps/sim/tools/generated/tool-metadata.ts b/apps/sim/tools/generated/tool-metadata.ts
diff --git a/apps/sim/tools/quickbooks/create_customer.ts b/apps/sim/tools/quickbooks/create_customer.ts
@@ -14,6 +14,7 @@ import {
   buildQuickBooksEntityUrl,
   getQuickBooksToolHeaders,
   optionalQuickBooksString,
+  parseQuickBooksAddress,
   quickBooksEmailAddress,
   quickBooksPhoneNumber,
   requiredQuickBooksString,
@@ -116,8 +117,8 @@ export const quickbooksCreateCustomerTool: ToolConfig<
         FamilyName: optionalQuickBooksString(params.familyName),
         PrimaryEmailAddr: quickBooksEmailAddress(params.primaryEmail),
         PrimaryPhone: quickBooksPhoneNumber(params.primaryPhone),
-        BillAddr: params.billingAddress,
-        ShipAddr: params.shippingAddress,
+        BillAddr: parseQuickBooksAddress(params.billingAddress, 'billingAddress'),
+        ShipAddr: parseQuickBooksAddress(params.shippingAddress, 'shippingAddress'),
         Taxable: params.taxable,
       }),
     retry: { enabled: false },
diff --git a/apps/sim/tools/quickbooks/create_vendor.ts b/apps/sim/tools/quickbooks/create_vendor.ts
@@ -11,6 +11,7 @@ import {
   buildQuickBooksEntityUrl,
   getQuickBooksToolHeaders,
   optionalQuickBooksString,
+  parseQuickBooksAddress,
   quickBooksEmailAddress,
   quickBooksPhoneNumber,
   requiredQuickBooksString,
@@ -119,7 +120,7 @@ export const quickbooksCreateVendorTool: ToolConfig<
         FamilyName: optionalQuickBooksString(params.familyName),
         PrimaryEmailAddr: quickBooksEmailAddress(params.primaryEmail),
         PrimaryPhone: quickBooksPhoneNumber(params.primaryPhone),
-        BillAddr: params.billingAddress,
+        BillAddr: parseQuickBooksAddress(params.billingAddress, 'billingAddress'),
         PrintOnCheckName: optionalQuickBooksString(params.printOnCheckName),
         AcctNum: optionalQuickBooksString(params.accountNumber),
         Vendor1099: params.vendor1099,
diff --git a/apps/sim/tools/quickbooks/quickbooks.test.ts b/apps/sim/tools/quickbooks/quickbooks.test.ts
@@ -575,6 +575,69 @@ describe('QuickBooks customer and vendor mutations', () => {
     expect(() => parseQuickBooksAddress('{}', 'billingAddress')).toThrow('at least one')
   })
 
+  it('rejects malformed addresses in direct mutation tool calls', () => {
+    expect(() =>
+      quickbooksCreateCustomerTool.request.body!({
+        ...authParams,
+        displayName: 'Sanitized Customer',
+        billingAddress: 'not-an-object' as never,
+      })
+    ).toThrow('billingAddress must be valid JSON')
+
+    expect(() =>
+      quickbooksUpdateCustomerTool.request.body!({
+        ...authParams,
+        customerId: '12',
+        syncToken: '3',
+        shippingAddress: [] as never,
+      })
+    ).toThrow('shippingAddress must be a JSON object')
+
+    expect(() =>
+      quickbooksCreateVendorTool.request.body!({
+        ...authParams,
+        displayName: 'Sanitized Vendor',
+        billingAddress: { unknown: 'value' } as never,
+      })
+    ).toThrow('billingAddress contains unsupported field')
+
+    expect(() =>
+      quickbooksUpdateVendorTool.request.body!({
+        ...authParams,
+        vendorId: '21',
+        syncToken: '4',
+        billingAddress: {} as never,
+      })
+    ).toThrow('billingAddress must contain at least one supported address field')
+  })
+
+  it('treats omitted active status as unchanged in direct update calls', () => {
+    expect(
+      quickbooksUpdateCustomerTool.request.body!({
+        ...authParams,
+        customerId: '12',
+        syncToken: '3',
+        companyName: 'Updated Company',
+      })
+    ).toEqual({
+      Id: '12',
+      SyncToken: '3',
+      sparse: true,
+      CompanyName: 'Updated Company',
+    })
+
+    for (const tool of [
+      quickbooksUpdateCustomerTool,
+      quickbooksUpdateVendorTool,
+      quickbooksUpdateItemTool,
+    ]) {
+      expect(tool.params.activeStatus).toMatchObject({
+        required: false,
+        default: 'unchanged',
+      })
+    }
+  })
+
   it('removes vendor tax identifiers from mutation output', async () => {
     const response = {
       Vendor: {
diff --git a/apps/sim/tools/quickbooks/types.ts b/apps/sim/tools/quickbooks/types.ts
@@ -250,7 +250,7 @@ export interface QuickBooksUpdateCustomerParams
   customerId: string
   syncToken: string
   displayName?: string
-  activeStatus: QuickBooksActiveStatus
+  activeStatus?: QuickBooksActiveStatus
 }
 
 export interface QuickBooksCreateVendorParams extends QuickBooksAuthParams {
@@ -271,7 +271,7 @@ export interface QuickBooksUpdateVendorParams
   vendorId: string
   syncToken: string
   displayName?: string
-  activeStatus: QuickBooksActiveStatus
+  activeStatus?: QuickBooksActiveStatus
 }
 
 export type QuickBooksWritableItemType = 'service' | 'non_inventory'
@@ -294,7 +294,7 @@ export interface QuickBooksUpdateItemParams
   syncToken: string
   name?: string
   incomeAccountId?: string
-  activeStatus: QuickBooksActiveStatus
+  activeStatus?: QuickBooksActiveStatus
 }
 
 export interface QuickBooksCompanyInfoResponse extends ToolResponse {
diff --git a/apps/sim/tools/quickbooks/update_customer.ts b/apps/sim/tools/quickbooks/update_customer.ts
@@ -15,6 +15,7 @@ import {
   buildQuickBooksEntityUrl,
   getQuickBooksToolHeaders,
   optionalQuickBooksString,
+  parseQuickBooksAddress,
   quickBooksActiveValue,
   quickBooksEmailAddress,
   quickBooksPhoneNumber,
@@ -113,10 +114,10 @@ export const quickbooksUpdateCustomerTool: ToolConfig<
     },
     activeStatus: {
       type: 'string',
-      required: true,
+      required: false,
       visibility: 'user-or-llm',
       default: 'unchanged',
-      description: 'Keep, activate, or deactivate the customer',
+      description: 'Customer status change: unchanged, active, or inactive',
     },
   },
   oauth: {
@@ -140,8 +141,8 @@ export const quickbooksUpdateCustomerTool: ToolConfig<
         FamilyName: optionalQuickBooksString(params.familyName),
         PrimaryEmailAddr: quickBooksEmailAddress(params.primaryEmail),
         PrimaryPhone: quickBooksPhoneNumber(params.primaryPhone),
-        BillAddr: params.billingAddress,
-        ShipAddr: params.shippingAddress,
+        BillAddr: parseQuickBooksAddress(params.billingAddress, 'billingAddress'),
+        ShipAddr: parseQuickBooksAddress(params.shippingAddress, 'shippingAddress'),
         Taxable: params.taxable,
         Active: quickBooksActiveValue(params.activeStatus),
       }) as Record<string, unknown>
diff --git a/apps/sim/tools/quickbooks/update_item.ts b/apps/sim/tools/quickbooks/update_item.ts
@@ -103,10 +103,10 @@ export const quickbooksUpdateItemTool: ToolConfig<
     },
     activeStatus: {
       type: 'string',
-      required: true,
+      required: false,
       visibility: 'user-or-llm',
       default: 'unchanged',
-      description: 'Keep, activate, or deactivate the item',
+      description: 'Item status change: unchanged, active, or inactive',
     },
   },
   oauth: {
diff --git a/apps/sim/tools/quickbooks/update_vendor.ts b/apps/sim/tools/quickbooks/update_vendor.ts
@@ -12,6 +12,7 @@ import {
   buildQuickBooksEntityUrl,
   getQuickBooksToolHeaders,
   optionalQuickBooksString,
+  parseQuickBooksAddress,
   quickBooksActiveValue,
   quickBooksEmailAddress,
   quickBooksPhoneNumber,
@@ -116,10 +117,10 @@ export const quickbooksUpdateVendorTool: ToolConfig<
     },
     activeStatus: {
       type: 'string',
-      required: true,
+      required: false,
       visibility: 'user-or-llm',
       default: 'unchanged',
-      description: 'Keep, activate, or deactivate the vendor',
+      description: 'Vendor status change: unchanged, active, or inactive',
     },
   },
   oauth: {
@@ -143,7 +144,7 @@ export const quickbooksUpdateVendorTool: ToolConfig<
         FamilyName: optionalQuickBooksString(params.familyName),
         PrimaryEmailAddr: quickBooksEmailAddress(params.primaryEmail),
         PrimaryPhone: quickBooksPhoneNumber(params.primaryPhone),
-        BillAddr: params.billingAddress,
+        BillAddr: parseQuickBooksAddress(params.billingAddress, 'billingAddress'),
         PrintOnCheckName: optionalQuickBooksString(params.printOnCheckName),
         AcctNum: optionalQuickBooksString(params.accountNumber),
         Vendor1099: params.vendor1099,
diff --git a/apps/sim/tools/quickbooks/utils.ts b/apps/sim/tools/quickbooks/utils.ts
@@ -306,8 +306,10 @@ export function parseQuickBooksAddress(
   return result
 }
 
-export function quickBooksActiveValue(activeStatus: QuickBooksActiveStatus): boolean | undefined {
-  if (activeStatus === 'unchanged') return undefined
+export function quickBooksActiveValue(
+  activeStatus: QuickBooksActiveStatus | undefined
+): boolean | undefined {
+  if (activeStatus === undefined || activeStatus === 'unchanged') return undefined
   if (activeStatus === 'active') return true
   if (activeStatus === 'inactive') return false
   throw new Error(`Unsupported QuickBooks active status: ${String(activeStatus)}`)
