fix(env): add min option to envNumber for strict-positive configs

Author: waleedlatif1

apps/sim/lib/copilot/request/session/buffer.ts

@@ -40,8 +40,8 @@ export type StreamConfig = {
 
 export function getStreamConfig(): StreamConfig {
   return {
-    ttlSeconds: envNumber(env.COPILOT_STREAM_TTL_SECONDS, DEFAULT_TTL_SECONDS),
-    eventLimit: envNumber(env.COPILOT_STREAM_EVENT_LIMIT, DEFAULT_EVENT_LIMIT),
+    ttlSeconds: envNumber(env.COPILOT_STREAM_TTL_SECONDS, DEFAULT_TTL_SECONDS, { min: 1 }),
+    eventLimit: envNumber(env.COPILOT_STREAM_EVENT_LIMIT, DEFAULT_EVENT_LIMIT, { min: 1 }),
   }
 }
 

apps/sim/lib/core/config/env.ts

@@ -516,19 +516,25 @@ export const isFalsy = (value: string | boolean | number | undefined) =>
 export { getEnv }
 
 /**
- * Coerce an env-derived value to a positive finite number, falling back to the
- * provided default when the value is unset, empty, non-finite, or negative.
- * Zero is accepted — some configs (e.g. `KB_CONFIG_DELAY_BETWEEN_BATCHES`)
- * use `0` to mean "no delay / max throughput".
+ * Coerce an env-derived value to a finite number ≥ `min`, falling back to the
+ * provided default when the value is unset, empty, non-finite, or below `min`.
+ * `min` defaults to `0` so configs like `KB_CONFIG_DELAY_BETWEEN_BATCHES=0`
+ * (meaning "no delay / max throughput") are honored. Pass `min: 1` for configs
+ * where zero is invalid (e.g. Redis TTLs, capacity limits).
  *
  * `createEnv` is configured with `skipValidation: true`, so values declared as
  * `z.number()` arrive as raw strings when sourced from `process.env` or Helm.
  * Use this helper anywhere a numeric env override is consumed to normalize the
  * type at the boundary instead of relying on JS implicit coercion.
  */
-export function envNumber(value: number | string | undefined | null, fallback: number): number {
-  if (typeof value === 'number' && Number.isFinite(value) && value >= 0) return value
+export function envNumber(
+  value: number | string | undefined | null,
+  fallback: number,
+  options: { min?: number } = {}
+): number {
+  const min = options.min ?? 0
+  if (typeof value === 'number' && Number.isFinite(value) && value >= min) return value
   if (value === undefined || value === null || value === '') return fallback
   const parsed = Number(value)
-  return Number.isFinite(parsed) && parsed >= 0 ? parsed : fallback
+  return Number.isFinite(parsed) && parsed >= min ? parsed : fallback
 }

packages/testing/src/mocks/env.mock.ts

@@ -53,11 +53,16 @@ export function createEnvMock(overrides: Record<string, string | undefined> = {}
       typeof value === 'string'
         ? value.toLowerCase() === 'false' || value === '0'
         : value === false,
-    envNumber: (value: number | string | undefined | null, fallback: number): number => {
-      if (typeof value === 'number' && Number.isFinite(value) && value >= 0) return value
+    envNumber: (
+      value: number | string | undefined | null,
+      fallback: number,
+      options: { min?: number } = {}
+    ): number => {
+      const min = options.min ?? 0
+      if (typeof value === 'number' && Number.isFinite(value) && value >= min) return value
       if (value === undefined || value === null || value === '') return fallback
       const parsed = Number(value)
-      return Number.isFinite(parsed) && parsed >= 0 ? parsed : fallback
+      return Number.isFinite(parsed) && parsed >= min ? parsed : fallback
     },
   }
 }