fix(data-drains): address bugbot review of 6336948

- gcs: allow 1-char dot-separated bucket components (e.g. "a.bucket")
  to match GCS naming rules — overall name is 3-63 (or up to 222 with
  dots), but per-component minimum is 1 per Google's spec
- bigquery: drain the 401 response body before re-issuing the request
  with a refreshed token so undici can return the socket to the
  keep-alive pool
- snowflake: hoist getJwt() above the perAttempt timer in
  executeStatement so JWT signing doesn't eat the network budget
  (matches the order already used in pollStatement)

Author: waleedlatif1

apps/sim/lib/api/contracts/data-drains.ts

@@ -8,15 +8,15 @@ const S3_BUCKET_NAME_RE = /^[a-z0-9][a-z0-9.-]{1,61}[a-z0-9]$/
 const S3_IPV4_LIKE_RE = /^(\d{1,3}\.){3}\d{1,3}$/
 const AWS_REGION_RE = /^[a-z]{2,}(-[a-z]+)+-\d+$/
 /** GCS bucket component: lowercase alnum + _ / -, start/end alnum. Mirrors gcs.ts. */
-const GCS_BUCKET_COMPONENT_RE = /^[a-z0-9][a-z0-9_-]*[a-z0-9]$/
+const GCS_BUCKET_COMPONENT_RE = /^[a-z0-9]([a-z0-9_-]*[a-z0-9])?$/
 const GOOGLE_RESERVED_PREFIX_RE = /^(goog|google|g00gle)/i
 const GOOGLE_CONTAINS_RE = /(google|g00gle)/i
 function validateGcsBucketComponents(v: string): string | null {
   if (v.length < 3 || v.length > 222) return 'bucket must be 3-222 characters'
   const components = v.split('.')
   for (const c of components) {
-    if (c.length < 3 || c.length > 63) {
-      return 'each dot-separated component must be 3-63 characters'
+    if (c.length < 1 || c.length > 63) {
+      return 'each dot-separated component must be 1-63 characters'
     }
     if (!GCS_BUCKET_COMPONENT_RE.test(c)) {
       return 'each component must be lowercase, start/end alphanumeric, letters/digits/_/- only'

apps/sim/lib/data-drains/destinations/bigquery.ts

@@ -206,6 +206,8 @@ async function insertAll(input: InsertAllInput): Promise<void> {
       if (response.status === 401 && !refreshedOnce) {
         refreshedOnce = true
         logger.debug('BigQuery returned 401; refreshing access token and retrying once')
+        /** Drain the 401 body before discarding so undici can return the socket to the keep-alive pool. */
+        await response.text().catch(() => '')
         response = await postInsertAll(input, url, body, true)
       }
       if (!RETRYABLE_STATUSES.has(response.status)) break

apps/sim/lib/data-drains/destinations/gcs.ts

@@ -27,7 +27,7 @@ const MAX_CUSTOM_METADATA_BYTES = 8 * 1024
 /** GCS object names are at most 1024 bytes when UTF-8 encoded (flat-namespace buckets). */
 const MAX_OBJECT_NAME_BYTES = 1024
 
-const GCS_BUCKET_COMPONENT_RE = /^[a-z0-9][a-z0-9_-]*[a-z0-9]$/
+const GCS_BUCKET_COMPONENT_RE = /^[a-z0-9]([a-z0-9_-]*[a-z0-9])?$/
 const IPV4_LIKE_RE = /^(\d{1,3}\.){3}\d{1,3}$/
 const GOOGLE_RESERVED_RE = /^(goog|google|g00gle)/i
 const GOOGLE_CONTAINS_RE = /(google|g00gle)/i
@@ -36,8 +36,8 @@ function validateGcsBucketComponents(v: string): string | null {
   if (v.length < 3 || v.length > 222) return 'bucket must be 3-222 characters'
   const components = v.split('.')
   for (const c of components) {
-    if (c.length < 3 || c.length > 63) {
-      return 'each dot-separated component must be 3-63 characters'
+    if (c.length < 1 || c.length > 63) {
+      return 'each dot-separated component must be 1-63 characters'
     }
     if (!GCS_BUCKET_COMPONENT_RE.test(c)) {
       return 'each component must be lowercase, start/end alphanumeric, letters/digits/_/- only'

apps/sim/lib/data-drains/destinations/snowflake.ts

@@ -227,8 +227,9 @@ async function executeStatement(input: ExecuteInput): Promise<void> {
   let lastError: unknown
   for (let attempt = 1; attempt <= EXECUTE_MAX_ATTEMPTS; attempt++) {
     if (input.signal.aborted) throw input.signal.reason ?? new Error('Aborted')
-    const perAttempt = AbortSignal.any([input.signal, AbortSignal.timeout(PER_ATTEMPT_TIMEOUT_MS)])
+    /** Acquire JWT before starting the per-attempt timer so token signing doesn't eat the network budget (mirrors pollStatement). */
     const jwt = await input.getJwt()
+    const perAttempt = AbortSignal.any([input.signal, AbortSignal.timeout(PER_ATTEMPT_TIMEOUT_MS)])
     const params = new URLSearchParams({ requestId })
     if (attempt > 1) params.set('retry', 'true')
     const url = `${baseUrl}?${params.toString()}`