Skip to content

Commit 4e30161

Browse files
committed
fix(selectors): rename advanced subBlock IDs to avoid canonicalParamId clashes
Rename all advanced-mode subBlock IDs that matched their canonicalParamId to use a `manual*` prefix, following the established convention (e.g., manualSiteId, manualCredential). This prevents ambiguity between subBlock IDs and canonical parameter names in the serialization layer. 25 renames across 14 blocks: baseId→manualBaseId, tableId→manualTableId, workspace→manualWorkspace, objectType→manualObjectType, etc.
1 parent c2041af commit 4e30161

File tree

15 files changed

+28
-28
lines changed

15 files changed

+28
-28
lines changed

apps/sim/blocks/blocks/airtable.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ export const AirtableBlock: BlockConfig<AirtableResponse> = {
7272
required: { field: 'operation', value: 'listBases', not: true },
7373
},
7474
{
75-
id: 'baseId',
75+
id: 'manualBaseId',
7676
title: 'Base ID',
7777
type: 'short-input',
7878
canonicalParamId: 'baseId',
@@ -96,7 +96,7 @@ export const AirtableBlock: BlockConfig<AirtableResponse> = {
9696
required: { field: 'operation', value: ['listBases', 'listTables'], not: true },
9797
},
9898
{
99-
id: 'tableId',
99+
id: 'manualTableId',
100100
title: 'Table ID',
101101
type: 'short-input',
102102
canonicalParamId: 'tableId',

apps/sim/blocks/blocks/asana.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export const AsanaBlock: BlockConfig<AsanaResponse> = {
6666
required: true,
6767
},
6868
{
69-
id: 'workspace',
69+
id: 'manualWorkspace',
7070
title: 'Workspace GID',
7171
type: 'short-input',
7272
canonicalParamId: 'workspace',
@@ -117,7 +117,7 @@ export const AsanaBlock: BlockConfig<AsanaResponse> = {
117117
},
118118
},
119119
{
120-
id: 'getTasks_workspace',
120+
id: 'manualGetTasksWorkspace',
121121
title: 'Workspace GID',
122122
type: 'short-input',
123123
canonicalParamId: 'getTasks_workspace',

apps/sim/blocks/blocks/attio.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ export const AttioBlock: BlockConfig<AttioResponse> = {
121121
},
122122
},
123123
{
124-
id: 'objectType',
124+
id: 'manualObjectType',
125125
title: 'Object Type',
126126
type: 'short-input',
127127
canonicalParamId: 'objectType',
@@ -597,7 +597,7 @@ Return ONLY the JSON array. No explanations, no markdown, no extra text.
597597
},
598598
},
599599
{
600-
id: 'listIdOrSlug',
600+
id: 'manualListIdOrSlug',
601601
title: 'List ID or Slug',
602602
type: 'short-input',
603603
canonicalParamId: 'listIdOrSlug',

apps/sim/blocks/blocks/calcom.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ export const CalComBlock: BlockConfig<ToolResponse> = {
8383
required: { field: 'operation', value: 'calcom_create_booking' },
8484
},
8585
{
86-
id: 'eventTypeId',
86+
id: 'manualEventTypeId',
8787
title: 'Event Type ID',
8888
type: 'short-input',
8989
canonicalParamId: 'eventTypeId',
@@ -301,7 +301,7 @@ Return ONLY the IANA timezone string - no explanations or quotes.`,
301301
},
302302
},
303303
{
304-
id: 'eventTypeIdParam',
304+
id: 'manualEventTypeIdParam',
305305
title: 'Event Type ID',
306306
type: 'short-input',
307307
canonicalParamId: 'eventTypeIdParam',
@@ -422,7 +422,7 @@ Return ONLY the IANA timezone string - no explanations or quotes.`,
422422
},
423423
},
424424
{
425-
id: 'eventTypeScheduleId',
425+
id: 'manualEventTypeScheduleId',
426426
title: 'Schedule ID',
427427
type: 'short-input',
428428
canonicalParamId: 'eventTypeScheduleId',
@@ -467,7 +467,7 @@ Return ONLY the IANA timezone string - no explanations or quotes.`,
467467
},
468468
},
469469
{
470-
id: 'scheduleId',
470+
id: 'manualScheduleId',
471471
title: 'Schedule ID',
472472
type: 'short-input',
473473
canonicalParamId: 'scheduleId',

apps/sim/blocks/blocks/confluence.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ export const ConfluenceBlock: BlockConfig<ConfluenceResponse> = {
157157
required: { field: 'operation', value: ['create', 'get_space'] },
158158
},
159159
{
160-
id: 'spaceId',
160+
id: 'manualSpaceId',
161161
title: 'Space ID',
162162
type: 'short-input',
163163
canonicalParamId: 'spaceId',

apps/sim/blocks/blocks/google_bigquery.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ Return ONLY the SQL query - no explanations, no quotes, no extra text.`,
124124
required: { field: 'operation', value: ['list_tables', 'get_table', 'insert_rows'] },
125125
},
126126
{
127-
id: 'datasetId',
127+
id: 'manualDatasetId',
128128
title: 'Dataset ID',
129129
type: 'short-input',
130130
canonicalParamId: 'datasetId',
@@ -149,7 +149,7 @@ Return ONLY the SQL query - no explanations, no quotes, no extra text.`,
149149
required: { field: 'operation', value: ['get_table', 'insert_rows'] },
150150
},
151151
{
152-
id: 'tableId',
152+
id: 'manualTableId',
153153
title: 'Table ID',
154154
type: 'short-input',
155155
canonicalParamId: 'tableId',

apps/sim/blocks/blocks/google_tasks.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export const GoogleTasksBlock: BlockConfig<GoogleTasksResponse> = {
6666
condition: { field: 'operation', value: 'list_task_lists', not: true },
6767
},
6868
{
69-
id: 'taskListId',
69+
id: 'manualTaskListId',
7070
title: 'Task List ID',
7171
type: 'short-input',
7272
canonicalParamId: 'taskListId',

apps/sim/blocks/blocks/jira_service_management.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ export const JiraServiceManagementBlock: BlockConfig<JsmResponse> = {
146146
},
147147
},
148148
{
149-
id: 'serviceDeskId',
149+
id: 'manualServiceDeskId',
150150
title: 'Service Desk ID',
151151
type: 'short-input',
152152
canonicalParamId: 'serviceDeskId',
@@ -195,7 +195,7 @@ export const JiraServiceManagementBlock: BlockConfig<JsmResponse> = {
195195
condition: { field: 'operation', value: ['create_request', 'get_request_type_fields'] },
196196
},
197197
{
198-
id: 'requestTypeId',
198+
id: 'manualRequestTypeId',
199199
title: 'Request Type ID',
200200
type: 'short-input',
201201
canonicalParamId: 'requestTypeId',

apps/sim/blocks/blocks/microsoft_planner.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ export const MicrosoftPlannerBlock: BlockConfig<MicrosoftPlannerResponse> = {
108108

109109
// Plan ID - advanced mode
110110
{
111-
id: 'planId',
111+
id: 'manualPlanId',
112112
title: 'Plan ID',
113113
type: 'short-input',
114114
canonicalParamId: 'planId',
@@ -146,7 +146,7 @@ export const MicrosoftPlannerBlock: BlockConfig<MicrosoftPlannerResponse> = {
146146
type: 'short-input',
147147
placeholder: 'Enter the task ID',
148148
condition: { field: 'operation', value: ['read_task'] },
149-
dependsOn: ['credential', 'planId'],
149+
dependsOn: ['credential', 'manualPlanId'],
150150
mode: 'advanced',
151151
canonicalParamId: 'readTaskId',
152152
},

apps/sim/blocks/blocks/notion.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export const NotionBlock: BlockConfig<NotionResponse> = {
6969
required: { field: 'operation', value: ['notion_read', 'notion_write'] },
7070
},
7171
{
72-
id: 'pageId',
72+
id: 'manualPageId',
7373
title: 'Page ID',
7474
type: 'short-input',
7575
canonicalParamId: 'pageId',
@@ -100,7 +100,7 @@ export const NotionBlock: BlockConfig<NotionResponse> = {
100100
},
101101
},
102102
{
103-
id: 'databaseId',
103+
id: 'manualDatabaseId',
104104
title: 'Database ID',
105105
type: 'short-input',
106106
canonicalParamId: 'databaseId',
@@ -137,7 +137,7 @@ export const NotionBlock: BlockConfig<NotionResponse> = {
137137
},
138138
},
139139
{
140-
id: 'parentId',
140+
id: 'manualParentId',
141141
title: 'Parent Page ID',
142142
type: 'short-input',
143143
canonicalParamId: 'parentId',

0 commit comments

Comments
 (0)