type checks

Author: icecrasher321

apps/sim/app/api/copilot/confirm/route.ts

@@ -4,6 +4,7 @@ import { type NextRequest, NextResponse } from 'next/server'
 import { copilotConfirmBodySchema } from '@/lib/api/contracts/copilot'
 import { validateSchema } from '@/lib/api/server'
 import {
+  ASYNC_TOOL_CONFIRMATION_STATUS,
   ASYNC_TOOL_STATUS,
   type AsyncCompletionData,
   type AsyncConfirmationStatus,

apps/sim/app/api/knowledge/[id]/documents/[documentId]/tag-definitions/route.ts

@@ -117,7 +117,10 @@ export const POST = withRouteHandler(
       const validatedData = validation.data
 
       for (const def of validatedData.definitions) {
-        if (!SUPPORTED_FIELD_TYPES.includes(def.fieldType)) {
+        // Defense-in-depth runtime check: contract leaves `fieldType` as `z.string()`
+        // because tightening to the enum cascades into UI form state types. Cast here
+        // to allow `includes` to accept the wider input.
+        if (!(SUPPORTED_FIELD_TYPES as readonly string[]).includes(def.fieldType)) {
           return NextResponse.json(
             { error: 'Invalid request data', details: `Unsupported field type: ${def.fieldType}` },
             { status: 400 }

apps/sim/app/api/mcp/serve/[serverId]/route.ts

@@ -20,6 +20,12 @@ import { workflow, workflowMcpServer, workflowMcpTool, workspace } from '@sim/db
 import { createLogger } from '@sim/logger'
 import { and, eq, isNull } from 'drizzle-orm'
 import { type NextRequest, NextResponse } from 'next/server'
+import {
+  mcpJsonRpcNotificationSchema,
+  mcpJsonRpcRequestSchema,
+  mcpServeRouteParamsSchema,
+  mcpToolCallParamsSchema,
+} from '@/lib/api/contracts/mcp'
 import { type AuthResult, AuthType, checkHybridAuth } from '@/lib/auth/hybrid'
 import { generateInternalToken } from '@/lib/auth/internal'
 import { getMaxExecutionTimeout } from '@/lib/core/execution-limits'
@@ -84,7 +90,7 @@ async function getServer(serverId: string) {
 export const GET = withRouteHandler(
   async (request: NextRequest, { params }: { params: Promise<RouteParams> }) => {
     try {
-      const { serverId } = routeParamsSchema.parse(await params)
+      const { serverId } = mcpServeRouteParamsSchema.parse(await params)
       const server = await getServer(serverId)
       if (!server) {
         return NextResponse.json({ error: 'Server not found' }, { status: 404 })
@@ -126,7 +132,7 @@ export const GET = withRouteHandler(
 export const POST = withRouteHandler(
   async (request: NextRequest, { params }: { params: Promise<RouteParams> }) => {
     try {
-      const { serverId } = routeParamsSchema.parse(await params)
+      const { serverId } = mcpServeRouteParamsSchema.parse(await params)
       const server = await getServer(serverId)
       if (!server) {
         return NextResponse.json({ error: 'Server not found' }, { status: 404 })
@@ -170,7 +176,7 @@ export const POST = withRouteHandler(
       const message = body as JSONRPCMessage
 
       if (isJSONRPCNotification(message)) {
-        const notificationValidation = jsonRpcNotificationSchema.safeParse(message)
+        const notificationValidation = mcpJsonRpcNotificationSchema.safeParse(message)
         if (!notificationValidation.success) {
           return NextResponse.json(
             createError(0, ErrorCode.InvalidRequest, 'Invalid JSON-RPC message'),
@@ -193,7 +199,7 @@ export const POST = withRouteHandler(
         )
       }
 
-      const requestValidation = jsonRpcRequestSchema.safeParse(message)
+      const requestValidation = mcpJsonRpcRequestSchema.safeParse(message)
       if (!requestValidation.success) {
         return NextResponse.json(
           createError(0, ErrorCode.InvalidRequest, 'Invalid JSON-RPC message'),
@@ -222,7 +228,7 @@ export const POST = withRouteHandler(
           return handleToolsList(id, serverId)
 
         case 'tools/call': {
-          const paramsValidation = toolCallParamsSchema.safeParse(rpcParams)
+          const paramsValidation = mcpToolCallParamsSchema.safeParse(rpcParams)
           if (!paramsValidation.success) {
             return NextResponse.json(
               createError(id, ErrorCode.InvalidParams, 'Invalid tool call parameters'),
@@ -407,7 +413,7 @@ async function handleToolsCall(
 export const DELETE = withRouteHandler(
   async (request: NextRequest, { params }: { params: Promise<RouteParams> }) => {
     try {
-      const { serverId } = routeParamsSchema.parse(await params)
+      const { serverId } = mcpServeRouteParamsSchema.parse(await params)
       const server = await getServer(serverId)
       if (!server) {
         return NextResponse.json({ error: 'Server not found' }, { status: 404 })

package.json

@@ -25,7 +25,6 @@
     "check:api-validation": "bun run scripts/check-api-validation-contracts.ts --check",
     "check:api-validation:strict": "bun run scripts/check-api-validation-contracts.ts --check --enforce-boundary-baseline",
     "check:realtime-prune": "bun run scripts/check-realtime-prune-graph.ts",
-    "check:zod-v4": "bun run scripts/check-zod-v4-readiness.ts --check",
     "mship-contracts:generate": "bun run scripts/sync-mothership-stream-contract.ts",
     "mship-contracts:check": "bun run scripts/sync-mothership-stream-contract.ts --check",
     "mship-tools:generate": "bun run scripts/sync-tool-catalog.ts",