improvement(kb-search): mark sourceUrl nullable and cover non-null happy path in tests

Author: waleedlatif1

apps/sim/app/api/knowledge/search/route.test.ts

@@ -999,7 +999,10 @@ describe('Knowledge Search API Route', () => {
 
       mockGenerateSearchEmbedding.mockResolvedValue([0.1, 0.2, 0.3])
       mockGetDocumentMetadataByIds.mockResolvedValue({
-        'doc-active': { filename: 'Active Document.pdf', sourceUrl: null },
+        'doc-active': {
+          filename: 'Active Document.pdf',
+          sourceUrl: 'https://example.atlassian.net/wiki/spaces/DOCS/pages/12345',
+        },
       })
 
       const mockTagDefs = {
@@ -1023,6 +1026,9 @@ describe('Knowledge Search API Route', () => {
       expect(data.data.results).toHaveLength(1)
       expect(data.data.results[0].documentId).toBe('doc-active')
       expect(data.data.results[0].documentName).toBe('Active Document.pdf')
+      expect(data.data.results[0].sourceUrl).toBe(
+        'https://example.atlassian.net/wiki/spaces/DOCS/pages/12345'
+      )
     })
 
     it('should exclude results from deleted documents in tag search', async () => {

apps/sim/app/api/v1/knowledge/search/route.test.ts

@@ -127,6 +127,42 @@ describe('v1 knowledge search route — per-KB embedding model', () => {
     expect(mockGenerateSearchEmbedding).not.toHaveBeenCalled()
   })
 
+  it('surfaces sourceUrl from document metadata in search results', async () => {
+    mockCheckKnowledgeBaseAccess.mockResolvedValueOnce({
+      hasAccess: true,
+      knowledgeBase: baseKb('kb-confluence', 'text-embedding-3-small'),
+    })
+    mockHandleVectorOnlySearch.mockResolvedValue([
+      {
+        documentId: 'doc-confluence',
+        knowledgeBaseId: 'kb-confluence',
+        content: 'page content',
+        chunkIndex: 0,
+        distance: 0.1,
+      },
+    ])
+    mockGetDocumentMetadataByIds.mockResolvedValue({
+      'doc-confluence': {
+        filename: 'Runbook.md',
+        sourceUrl: 'https://example.atlassian.net/wiki/spaces/DOCS/pages/12345',
+      },
+    })
+
+    const req = createMockRequest('POST', {
+      workspaceId: 'ws-1',
+      knowledgeBaseIds: 'kb-confluence',
+      query: 'runbook',
+    })
+    const res = await POST(req)
+    const body = await res.json()
+
+    expect(res.status).toBe(200)
+    expect(body.data.results[0].sourceUrl).toBe(
+      'https://example.atlassian.net/wiki/spaces/DOCS/pages/12345'
+    )
+    expect(body.data.results[0].documentName).toBe('Runbook.md')
+  })
+
   it('allows tag-only search across mixed embedding models', async () => {
     mockHandleTagOnlySearch.mockResolvedValue([])
     mockCheckKnowledgeBaseAccess.mockResolvedValueOnce({

apps/sim/tools/knowledge/search.ts

@@ -179,6 +179,7 @@ export const knowledgeSearchTool: ToolConfig<any, KnowledgeSearchResponse> = {
           documentName: { type: 'string', description: 'Document name' },
           sourceUrl: {
             type: 'string',
+            nullable: true,
             description:
               'URL to the original source document (e.g., Confluence page, Google Doc, Notion page). Null for documents without an external source.',
           },

apps/sim/tools/types.ts

@@ -46,6 +46,7 @@ export interface OutputProperty {
   type: OutputType
   description?: string
   optional?: boolean
+  nullable?: boolean
   properties?: Record<string, OutputProperty>
   items?: {
     type: OutputType