fix(mcp): use undefined (not null) for cleared oauthClientId in cache

waleedlatif1 · claude · waleedlatif1 · commit 3a7fc426ee5e · 2026-05-12T10:35:40.000-07:00
McpServer.oauthClientId is typed string | undefined on the client, so the
prior `|| null` broke type-check. Empty string still normalizes to "cleared"
in the optimistic cache write.

Co-Authored-By: Claude Opus 4.7 &lt;noreply@anthropic.com&gt;
diff --git a/apps/sim/hooks/queries/mcp.ts b/apps/sim/hooks/queries/mcp.ts
@@ -273,7 +273,7 @@ export function useUpdateMcpServer() {
         const { oauthClientSecret: _omitSecret, oauthClientId, ...rest } = updates
         const safeUpdates: Partial<McpServer> = { ...rest }
         if (oauthClientId !== undefined) {
-          safeUpdates.oauthClientId = oauthClientId || null
+          safeUpdates.oauthClientId = oauthClientId || undefined
         }
         queryClient.setQueryData<McpServer[]>(
           mcpKeys.serversList(workspaceId),

Original file line number	Diff line number	Diff line change
`@@ -273,7 +273,7 @@ export function useUpdateMcpServer() {`
`273`	`273`	`const { oauthClientSecret: _omitSecret, oauthClientId, ...rest } = updates`
`274`	`274`	`const safeUpdates: Partial<McpServer> = { ...rest }`
`275`	`275`	`if (oauthClientId !== undefined) {`
`276`		`- safeUpdates.oauthClientId = oauthClientId \|\| null`
	`276`	`+ safeUpdates.oauthClientId = oauthClientId \|\| undefined`
`277`	`277`	`}`
`278`	`278`	`queryClient.setQueryData<McpServer[]>(`
`279`	`279`	`mcpKeys.serversList(workspaceId),`