fix live update on table

TheodoreSpeaks · TheodoreSpeaks · commit 38a38185547b · 2026-04-30T16:26:08.000-07:00
diff --git a/apps/realtime/src/rooms/types.ts b/apps/realtime/src/rooms/types.ts
@@ -177,6 +177,8 @@ export interface IRoomManager {
 export interface TableRowUpdatedPayload {
   rowId: string
   data: Record<string, unknown>
+  /** Per-workflow-group execution state. Keyed by `WorkflowGroup.id`. */
+  executions?: Record<string, unknown>
   position: number
   updatedAt: string | number
 }
diff --git a/apps/realtime/src/routes/http.ts b/apps/realtime/src/routes/http.ts
@@ -154,8 +154,14 @@ export function createHttpHandler(roomManager: IRoomManager, logger: Logger) {
     if (req.method === 'POST' && req.url === '/api/table-row-updated') {
       try {
         const body = await readRequestBody(req)
-        const { tableId, rowId, data, position, updatedAt } = JSON.parse(body)
-        await roomManager.handleTableRowUpdated(tableId, { rowId, data, position, updatedAt })
+        const { tableId, rowId, data, executions, position, updatedAt } = JSON.parse(body)
+        await roomManager.handleTableRowUpdated(tableId, {
+          rowId,
+          data,
+          executions,
+          position,
+          updatedAt,
+        })
         sendSuccess(res)
       } catch (error) {
         logger.error('Error handling table row update notification:', error)
diff --git a/apps/sim/app/api/table/utils.ts b/apps/sim/app/api/table/utils.ts
@@ -1,14 +1,17 @@
 import { createLogger } from '@sim/logger'
 import { NextResponse } from 'next/server'
+import { z } from 'zod'
 import {
   createTableColumnBodySchema,
   deleteTableColumnBodySchema,
   updateTableColumnBodySchema,
 } from '@/lib/api/contracts/tables'
 import type { ColumnDefinition, TableDefinition } from '@/lib/table'
-import { getTableById } from '@/lib/table'
+import { COLUMN_TYPES, getTableById } from '@/lib/table'
 import { getUserEntityPermissions } from '@/lib/workspaces/permissions/utils'
 
+const columnTypeEnum = z.enum(COLUMN_TYPES)
+
 const logger = createLogger('TableUtils')
 
 export interface TableAccessResult {
diff --git a/apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table/table.tsx b/apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table/table.tsx
@@ -3429,10 +3429,6 @@ function CellContent({
         </span>
       )
     } else {
-      // eslint-disable-next-line no-console
-      console.log(
-        `[FLASH-DEBUG] render dash col=${column.name} groupId=${column.workflowGroupId} status=${exec?.status ?? 'undefined'} value=${value === null ? 'null' : value === undefined ? 'undefined' : typeof value} runningBlockIds=${JSON.stringify(exec?.runningBlockIds ?? [])} blockErrors=${JSON.stringify(Object.keys(exec?.blockErrors ?? {}))}`
-      )
       displayContent = <span className='text-[var(--text-tertiary)]'>—</span>
     }
     return displayContent
diff --git a/apps/sim/app/workspace/[workspaceId]/tables/[tableId]/hooks/use-row-execution.ts b/apps/sim/app/workspace/[workspaceId]/tables/[tableId]/hooks/use-row-execution.ts
@@ -59,9 +59,6 @@ export function useRowExecution(): UseRowExecutionReturn {
       return res.json()
     },
     onMutate: async (params) => {
-      logger.info(
-        `[FLASH-DEBUG] useRowExecution onMutate row=${params.rowId} group=${params.groupId} clearedCols=${JSON.stringify(params.outputColumnNames)}`
-      )
       const snapshots = await snapshotAndMutateRows(queryClient, params.tableId, (r) => {
         if (r.id !== params.rowId) return null
         const exec = (r.executions ?? {})[params.groupId] as RowExecutionMetadata | undefined
@@ -89,7 +86,6 @@ export function useRowExecution(): UseRowExecutionReturn {
       toast.error(`Failed to run workflow: ${message}`)
     },
     onSettled: (_data, _err, params) => {
-      logger.info(`[FLASH-DEBUG] useRowExecution onSettled → invalidate row=${params.rowId}`)
       queryClient.invalidateQueries({ queryKey: tableKeys.rowsRoot(params.tableId) })
     },
   })
diff --git a/apps/sim/background/workflow-column-execution.ts b/apps/sim/background/workflow-column-execution.ts
@@ -150,9 +150,6 @@ export async function executeWorkflowGroupCellJob(
         const dataSnapshot: RowData = { ...accumulatedData }
         const blockErrorsSnapshot = { ...blockErrors }
         const runningSnapshot = Array.from(runningBlockIds)
-        logger.info(
-          `[FLASH-DEBUG] partial write scheduled row=${rowId} group=${groupId} dataKeys=${JSON.stringify(Object.keys(dataSnapshot))} running=${JSON.stringify(runningSnapshot)} errors=${JSON.stringify(Object.keys(blockErrorsSnapshot))}`
-        )
         writeChain = writeChain
           .then(async () => {
             if (signal?.aborted) return
@@ -250,9 +247,6 @@ export async function executeWorkflowGroupCellJob(
       // Drain queued partial writes before the terminal write so a late
       // `running` partial doesn't clobber it.
       await writeChain.catch(() => {})
-      logger.info(
-        `[FLASH-DEBUG] terminal write row=${rowId} group=${groupId} status=${result.success ? 'completed' : 'error'} dataKeys=${JSON.stringify(Object.keys(accumulatedData))}`
-      )
 
       await writeState(
         {
diff --git a/apps/sim/hooks/queries/tables.ts b/apps/sim/hooks/queries/tables.ts
@@ -258,17 +258,9 @@ export function useTableRows({
 
     onTableRowUpdated((event) => {
       if (event.tableId !== tableId) return
-      const incomingExec = Object.fromEntries(
-        Object.entries(
-          (event.executions as Record<string, { status?: string }> | undefined) ?? {}
-        ).map(([gid, e]) => [gid, e?.status ?? null])
-      )
       // While an optimistic mutation is in flight, applying the socket delta
       // could clobber the optimistic state — defer to onSettled invalidate.
       if (queryClient.isMutating() > 0) {
-        logger.info(
-          `[FLASH-DEBUG] socket row=${event.rowId} (mutation in flight → invalidate) incomingExec=${JSON.stringify(incomingExec)}`
-        )
         queryClient.invalidateQueries({ queryKey: tableKeys.rowsRoot(tableId) })
         return
       }
@@ -294,15 +286,6 @@ export function useTableRows({
               totalCount: current.totalCount === null ? null : current.totalCount + 1,
             }
           }
-          const prevExec = Object.fromEntries(
-            Object.entries(current.rows[idx].executions ?? {}).map(([gid, e]) => [
-              gid,
-              e?.status ?? null,
-            ])
-          )
-          logger.info(
-            `[FLASH-DEBUG] socket merge row=${event.rowId} prevExec=${JSON.stringify(prevExec)} incomingExec=${JSON.stringify(incomingExec)}`
-          )
           const merged = {
             ...current.rows[idx],
             data: incoming.data,
diff --git a/apps/sim/lib/table/service.ts b/apps/sim/lib/table/service.ts
@@ -78,12 +78,6 @@ const logger = createLogger('TableService')
  * server can broadcast to subscribed clients in the table room.
  */
 function notifyTableRowUpdated(tableId: string, row: TableRow): void {
-  const execStates = Object.fromEntries(
-    Object.entries(row.executions ?? {}).map(([gid, e]) => [gid, e?.status ?? null])
-  )
-  logger.info(
-    `[FLASH-DEBUG] notify row=${row.id} table=${tableId} exec=${JSON.stringify(execStates)}`
-  )
   void fetch(`${getSocketServerUrl()}/api/table-row-updated`, {
     method: 'POST',
     headers: {
@@ -1578,11 +1572,9 @@ export async function updateRow(
   // `running` execution state — those land last, so the cached executions
   // end on the live state instead of being clobbered by a stale envelope.
   notifyTableRowUpdated(data.tableId, updatedRow)
-  logger.info(`[FLASH-DEBUG] updateRow → scheduler START row=${data.rowId}`)
   // Awaited (not `void`) so cell tasks dispatch their cascade before the
   // trigger.dev worker tears down on `run()` resolve.
   await scheduleWorkflowGroupRuns(table, [updatedRow])
-  logger.info(`[FLASH-DEBUG] updateRow → scheduler END row=${data.rowId}`)
 
   return updatedRow
 }
diff --git a/apps/sim/lib/table/workflow-columns.ts b/apps/sim/lib/table/workflow-columns.ts
@@ -125,7 +125,6 @@ interface RunGroupCellOptions {
  */
 export async function runWorkflowGroupCell(opts: RunGroupCellOptions): Promise<void> {
   const { tableId, tableName, rowId, groupId, workflowId, workspaceId, executionId } = opts
-  logger.info(`[FLASH-DEBUG] runWorkflowGroupCell START row=${rowId} group=${groupId}`)
 
   const { getJobQueue, shouldExecuteInline } = await import('@/lib/core/async-jobs/config')
   const cellCtx = { tableId, rowId, workspaceId, groupId, executionId }
@@ -143,7 +142,6 @@ export async function runWorkflowGroupCell(opts: RunGroupCellOptions): Promise<v
   let queue: Awaited<ReturnType<typeof getJobQueue>>
   try {
     queue = await getJobQueue()
-    logger.info(`[FLASH-DEBUG] enqueue START row=${rowId} group=${groupId}`)
     jobId = await queue.enqueue('workflow-group-cell', taskPayload, {
       metadata: {
         workflowId,
@@ -183,7 +181,6 @@ export async function runWorkflowGroupCell(opts: RunGroupCellOptions): Promise<v
   // we abort the just-enqueued job.
   let stampResult: 'wrote' | 'skipped' = 'wrote'
   try {
-    logger.info(`[FLASH-DEBUG] write running+jobId row=${rowId} group=${groupId} jobId=${jobId}`)
     stampResult = await writeWorkflowGroupState(cellCtx, {
       executionState: {
         status: 'running',

Original file line number	Diff line number	Diff line change
`@@ -177,6 +177,8 @@ export interface IRoomManager {`
`177`	`177`	`export interface TableRowUpdatedPayload {`
`178`	`178`	`rowId: string`
`179`	`179`	`data: Record<string, unknown>`
	`180`	+ /** Per-workflow-group execution state. Keyed by `WorkflowGroup.id`. */
	`181`	`+ executions?: Record<string, unknown>`
`180`	`182`	`position: number`
`181`	`183`	`updatedAt: string \| number`
`182`	`184`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3429,10 +3429,6 @@ function CellContent({`
`3429`	`3429`	`</span>`
`3430`	`3430`	`)`
`3431`	`3431`	`} else {`
`3432`		`- // eslint-disable-next-line no-console`
`3433`		`- console.log(`
`3434`		- `[FLASH-DEBUG] render dash col=${column.name} groupId=${column.workflowGroupId} status=${exec?.status ?? 'undefined'} value=${value === null ? 'null' : value === undefined ? 'undefined' : typeof value} runningBlockIds=${JSON.stringify(exec?.runningBlockIds ?? [])} blockErrors=${JSON.stringify(Object.keys(exec?.blockErrors ?? {}))}`
`3435`		`- )`
`3436`	`3432`	`displayContent = <span className='text-[var(--text-tertiary)]'>—</span>`
`3437`	`3433`	`}`
`3438`	`3434`	`return displayContent`