fix(quickbooks): wand prompt requires itemId, extract coerceJsonArray helper

Author: waleedlatif1

apps/sim/blocks/blocks/quickbooks.ts

@@ -189,7 +189,7 @@ export const QuickBooksBlock: BlockConfig<QuickBooksResponse> = {
       wandConfig: {
         enabled: true,
         prompt:
-          'Generate a JSON array of QuickBooks invoice line items. Each entry must have a numeric `amount` and may include `description`, `quantity`, `itemId`, and `itemName`. Return ONLY the JSON array.',
+          'Generate a JSON array of QuickBooks invoice line items. Each entry must have a numeric `amount` and a string `itemId` (the QuickBooks Item ID); may include `description`, `quantity`, and `itemName`. Return ONLY the JSON array.',
         generationType: 'json-object',
       },
     },

apps/sim/tools/quickbooks/create_bill.ts

@@ -5,22 +5,13 @@ import type {
   QuickBooksCreateBillParams,
 } from '@/tools/quickbooks/types'
 import { BILL_OUTPUT } from '@/tools/quickbooks/types'
-import { buildCompanyUrl, quickbooksAuthHeaders } from '@/tools/quickbooks/utils'
+import { buildCompanyUrl, coerceJsonArray, quickbooksAuthHeaders } from '@/tools/quickbooks/utils'
 import type { ToolConfig } from '@/tools/types'
 
 const logger = createLogger('QuickBooksCreateBill')
 
-function coerceLines(input: QuickBooksCreateBillParams['lines']): QuickBooksBillLine[] {
-  if (Array.isArray(input)) return input
-  if (typeof input !== 'string') {
-    throw new Error('Bill lines must be a JSON array')
-  }
-  const parsed = JSON.parse(input)
-  if (!Array.isArray(parsed)) {
-    throw new Error('Bill lines must be a JSON array')
-  }
-  return parsed as QuickBooksBillLine[]
-}
+const coerceLines = (input: QuickBooksCreateBillParams['lines']): QuickBooksBillLine[] =>
+  coerceJsonArray<QuickBooksBillLine>(input, 'Bill lines')
 
 export const quickbooksCreateBillTool: ToolConfig<
   QuickBooksCreateBillParams,

apps/sim/tools/quickbooks/create_invoice.ts

@@ -5,22 +5,13 @@ import type {
   QuickBooksLineItem,
 } from '@/tools/quickbooks/types'
 import { INVOICE_OUTPUT } from '@/tools/quickbooks/types'
-import { buildCompanyUrl, quickbooksAuthHeaders } from '@/tools/quickbooks/utils'
+import { buildCompanyUrl, coerceJsonArray, quickbooksAuthHeaders } from '@/tools/quickbooks/utils'
 import type { ToolConfig } from '@/tools/types'
 
 const logger = createLogger('QuickBooksCreateInvoice')
 
-function coerceLines(input: QuickBooksCreateInvoiceParams['lines']): QuickBooksLineItem[] {
-  if (Array.isArray(input)) return input
-  if (typeof input !== 'string') {
-    throw new Error('Invoice lines must be a JSON array')
-  }
-  const parsed = JSON.parse(input)
-  if (!Array.isArray(parsed)) {
-    throw new Error('Invoice lines must be a JSON array')
-  }
-  return parsed as QuickBooksLineItem[]
-}
+const coerceLines = (input: QuickBooksCreateInvoiceParams['lines']): QuickBooksLineItem[] =>
+  coerceJsonArray<QuickBooksLineItem>(input, 'Invoice lines')
 
 export const quickbooksCreateInvoiceTool: ToolConfig<
   QuickBooksCreateInvoiceParams,

apps/sim/tools/quickbooks/utils.ts

@@ -41,6 +41,23 @@ export function sanitizeWhereClause(where: string | undefined): string | undefin
   return trimmed
 }
 
+/**
+ * Coerce a `lines` parameter (already an array, or a JSON-encoded string from
+ * an LLM/short-input) into a typed array. Throws with a contextual label when
+ * the value is missing or not an array.
+ */
+export function coerceJsonArray<T>(input: unknown, label: string): T[] {
+  if (Array.isArray(input)) return input as T[]
+  if (typeof input !== 'string') {
+    throw new Error(`${label} must be a JSON array`)
+  }
+  const parsed = JSON.parse(input)
+  if (!Array.isArray(parsed)) {
+    throw new Error(`${label} must be a JSON array`)
+  }
+  return parsed as T[]
+}
+
 export function quickbooksAuthHeaders(accessToken: string | undefined): Record<string, string> {
   if (!accessToken) {
     throw new Error('Missing QuickBooks access token')