fix(testing): align capability-aware config mocks

Author: TheodoreSpeaks

apps/sim/executor/handlers/pi/babysit-backend.test.ts

@@ -1,7 +1,8 @@
 /**
  * @vitest-environment node
  */
-import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { resetEnvMock, setEnv } from '@sim/testing'
+import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest'
 
 const {
   mockWithPiSandbox,
@@ -68,6 +69,8 @@ import { BABYSIT_ROUND_PATH } from '@/executor/handlers/pi/babysit-round'
 import type { PiBabysitContinuationParams } from '@/executor/handlers/pi/backend'
 import { DIFF_PATH } from '@/executor/handlers/pi/cloud-shared'
 
+afterAll(resetEnvMock)
+
 const OLD_SHA = 'a'.repeat(40)
 const NEW_SHA = 'c'.repeat(40)
 const SECOND_SHA = 'd'.repeat(40)
@@ -235,6 +238,7 @@ function makeRunner(options: {
 describe('runBabysitPiWithOptions', () => {
   beforeEach(() => {
     vi.clearAllMocks()
+    setEnv({ SANDBOX_PROVIDER: 'e2b' })
     mockWithPiSandbox.mockReset()
     mockFetchSnapshot.mockReset()
     mockFetchThreads.mockReset()

apps/sim/lib/execution/event-buffer.test.ts

@@ -1,7 +1,7 @@
 /**
  * @vitest-environment node
  */
-import { redisConfigMockFns, resetRedisConfigMock } from '@sim/testing'
+import { redisConfigMockFns, resetEnvMock, resetRedisConfigMock, setEnv } from '@sim/testing'
 import { sleep } from '@sim/utils/helpers'
 import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest'
 import type { ExecutionEventEntry } from '@/lib/execution/event-buffer'
@@ -26,7 +26,10 @@ const { mockRedis, persistedEntries } = vi.hoisted(() => {
 
 const mockGetRedisClient = redisConfigMockFns.mockGetRedisClient
 
-afterAll(resetRedisConfigMock)
+afterAll(() => {
+  resetEnvMock()
+  resetRedisConfigMock()
+})
 
 import {
   createExecutionEventWriter,
@@ -77,6 +80,7 @@ function countOccurrences(haystack: string, needle: string): number {
 describe('execution event buffer', () => {
   beforeEach(() => {
     vi.clearAllMocks()
+    setEnv({ REDIS_URL: 'redis://localhost:6379' })
     persistedEntries.length = 0
     mockGetRedisClient.mockReturnValue(mockRedis)
     mockRedis.get.mockResolvedValue(null)

apps/sim/lib/execution/remote-sandbox/conformance.test.ts

@@ -37,6 +37,7 @@ const {
   mockEnv: {
     SANDBOX_PROVIDER: 'e2b' as string | undefined,
     PI_SANDBOX_LIFETIME_MS: undefined as string | undefined,
+    E2B_ENABLED: 'true',
     E2B_API_KEY: 'test-key',
     MOTHERSHIP_E2B_TEMPLATE_ID: 'mothership-shell',
     MOTHERSHIP_E2B_DOC_TEMPLATE_ID: 'mothership-docs',

packages/testing/src/mocks/env.mock.test.ts

@@ -36,6 +36,16 @@ describe('env mock', () => {
     expect(envMock.getEnv('SOME_UNPINNED_TEST_VAR')).toBe('from-process-env')
   })
 
+  it('does not inherit process.env for pinned capability defaults', () => {
+    vi.stubEnv('REDIS_URL', 'redis://localhost:6379')
+    vi.stubEnv('STORAGE_PROVIDER', 's3')
+    resetEnvMock()
+    expect(envMock.env.REDIS_URL).toBeUndefined()
+    expect(envMock.getEnv('REDIS_URL')).toBeUndefined()
+    expect(envMock.env.STORAGE_PROVIDER).toBe('local')
+    expect(envMock.getEnv('STORAGE_PROVIDER')).toBe('local')
+  })
+
   it('pins explicitly-undefined overrides without process.env fallback', () => {
     vi.stubEnv('NEXT_PUBLIC_APP_URL', 'https://shadowed.example.com')
     setEnv({ NEXT_PUBLIC_APP_URL: undefined })

packages/testing/src/mocks/env.mock.ts

@@ -25,6 +25,12 @@ export const defaultMockEnv = {
   EMAIL_DOMAIN: 'test.sim.ai',
   PERSONAL_EMAIL_FROM: 'Test <test@test.sim.ai>',
 
+  // Cache
+  REDIS_URL: undefined,
+
+  // Storage
+  STORAGE_PROVIDER: 'local',
+
   // URLs
   NEXT_PUBLIC_APP_URL: 'https://test.sim.ai',
 }

packages/testing/src/mocks/redis-config.mock.test.ts

@@ -7,6 +7,7 @@ describe('redis-config mock', () => {
   })
 
   it('defaults to the Redis-unavailable behavior of the real module', async () => {
+    expect(redisConfigMock.getConfiguredRedisUrl()).toBeNull()
     expect(redisConfigMock.getRedisClient()).toBeNull()
     await expect(redisConfigMock.acquireLock('k', 'v', 10)).resolves.toBe(true)
     await expect(redisConfigMock.releaseLock('k', 'v')).resolves.toBe(true)
@@ -24,12 +25,15 @@ describe('redis-config mock', () => {
 
   it('resetRedisConfigMock restores defaults after overrides', async () => {
     const fakeClient = { ping: () => 'PONG' }
+    redisConfigMockFns.mockGetConfiguredRedisUrl.mockReturnValue('redis://localhost:6379')
     redisConfigMockFns.mockGetRedisClient.mockReturnValue(fakeClient)
     redisConfigMockFns.mockAcquireLock.mockResolvedValue(false)
+    expect(redisConfigMock.getConfiguredRedisUrl()).toBe('redis://localhost:6379')
     expect(redisConfigMock.getRedisClient()).toBe(fakeClient)
     await expect(redisConfigMock.acquireLock('k', 'v', 10)).resolves.toBe(false)
 
     resetRedisConfigMock()
+    expect(redisConfigMock.getConfiguredRedisUrl()).toBeNull()
     expect(redisConfigMock.getRedisClient()).toBeNull()
     await expect(redisConfigMock.acquireLock('k', 'v', 10)).resolves.toBe(true)
   })

packages/testing/src/mocks/redis-config.mock.ts

@@ -45,8 +45,9 @@ function getRedisConnectionDefaultsImpl(url?: string): {
 
 /**
  * Controllable mock functions for `@/lib/core/config/redis`.
- * Default: `getRedisClient` returns `null` (tests that need a client override
- * it), matching the real module's behavior when `REDIS_URL` is unset.
+ * Default: `getConfiguredRedisUrl` and `getRedisClient` return `null` (tests
+ * that need Redis override them), matching the real module's database-cache
+ * behavior.
  * `acquireLock`/`releaseLock`/`extendLock` default to succeeding (`true`),
  * matching the real module's Redis-unavailable no-op path.
  * {@link resetRedisConfigMock} restores the default behaviors.
@@ -59,6 +60,7 @@ function getRedisConnectionDefaultsImpl(url?: string): {
  * ```
  */
 export const redisConfigMockFns = {
+  mockGetConfiguredRedisUrl: vi.fn().mockReturnValue(null),
   mockGetRedisClient: vi.fn().mockReturnValue(null),
   mockGetRedisConnectionDefaults: vi.fn(getRedisConnectionDefaultsImpl),
   mockOnRedisReconnect: vi.fn(),
@@ -73,6 +75,7 @@ export const redisConfigMockFns = {
  * Restores every redis-config mock function to its default behavior.
  */
 export function resetRedisConfigMock(): void {
+  redisConfigMockFns.mockGetConfiguredRedisUrl.mockReset().mockReturnValue(null)
   redisConfigMockFns.mockGetRedisClient.mockReset().mockReturnValue(null)
   redisConfigMockFns.mockGetRedisConnectionDefaults
     .mockReset()
@@ -95,6 +98,7 @@ export function resetRedisConfigMock(): void {
  * ```
  */
 export const redisConfigMock = {
+  getConfiguredRedisUrl: redisConfigMockFns.mockGetConfiguredRedisUrl,
   getRedisClient: redisConfigMockFns.mockGetRedisClient,
   getRedisConnectionDefaults: redisConfigMockFns.mockGetRedisConnectionDefaults,
   onRedisReconnect: redisConfigMockFns.mockOnRedisReconnect,