Skip to content

Commit 1373fe2

Browse files
committed
fix(secrets): use getErrorMessage for the visibility-change toast
CI's check:audits gate caught a documented rule violation: CLAUDE.md says never write `e instanceof Error ? e.message : 'fallback'`, use getErrorMessage(e, fallback?) from @sim/utils/errors. The visibility-change handler did exactly the banned form. Worth noting for next time: check:audits is not part of `bun run check`, so a local run of check + lint + type-check + tests passes while CI fails.
1 parent 633eb5e commit 1373fe2

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

  • apps/sim/app/workspace/[workspaceId]/settings/components/secrets/components/secrets-manager

apps/sim/app/workspace/[workspaceId]/settings/components/secrets/components/secrets-manager/secrets-manager.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import { useCallback, useEffect, useId, useMemo, useRef, useState } from 'react'
44
import { ChipConfirmModal, ChipInput, cn, toast } from '@sim/emcn'
55
import { createLogger } from '@sim/logger'
6+
import { getErrorMessage } from '@sim/utils/errors'
67
import { useQueryClient } from '@tanstack/react-query'
78
import { useParams, useRouter } from 'next/navigation'
89
import { canMutateWorkspaceSettingsSection } from '@/components/settings/navigation'
@@ -467,7 +468,7 @@ export function SecretsManager() {
467468
)
468469
} catch (error) {
469470
logger.error('Failed to change secret visibility', { error })
470-
toast.error(error instanceof Error ? error.message : 'Failed to change visibility')
471+
toast.error(getErrorMessage(error, 'Failed to change visibility'))
471472
}
472473
}, [pendingVisibilityChange, workspaceId, upsertWorkspaceMutation])
473474

0 commit comments

Comments
 (0)