fix(uploads): surface server error message and bypass quota for local-storage fallback

Author: waleedlatif1

apps/sim/app/api/workspaces/[id]/files/presigned/route.ts

@@ -46,14 +46,6 @@ export const POST = withRouteHandler(
       )
     }
 
-    const quotaCheck = await checkStorageQuota(userId, fileSize)
-    if (!quotaCheck.allowed) {
-      return NextResponse.json(
-        { error: quotaCheck.error || 'Storage limit exceeded' },
-        { status: 413 }
-      )
-    }
-
     if (!hasCloudStorage()) {
       logger.info(`Local storage detected, signaling API fallback for ${fileName}`)
       return NextResponse.json({
@@ -64,6 +56,14 @@ export const POST = withRouteHandler(
       })
     }
 
+    const quotaCheck = await checkStorageQuota(userId, fileSize)
+    if (!quotaCheck.allowed) {
+      return NextResponse.json(
+        { error: quotaCheck.error || 'Storage limit exceeded' },
+        { status: 413 }
+      )
+    }
+
     const key = generateWorkspaceFileKey(workspaceId, fileName)
     const presigned = await generatePresignedUploadUrl({
       fileName,

apps/sim/lib/uploads/client/direct-upload.ts

@@ -180,8 +180,15 @@ export const getPresignedUploadInfo = async (
     try {
       errorDetails = await response.json()
     } catch {}
+    const serverMessage =
+      errorDetails != null &&
+      typeof errorDetails === 'object' &&
+      typeof (errorDetails as Record<string, unknown>).error === 'string'
+        ? ((errorDetails as Record<string, unknown>).error as string)
+        : null
     throw new DirectUploadError(
-      `Failed to get presigned URL for ${file.name}: ${response.status} ${response.statusText}`,
+      serverMessage ||
+        `Failed to get presigned URL for ${file.name}: ${response.status} ${response.statusText}`,
       'PRESIGNED_URL_ERROR',
       errorDetails
     )