Fix PHPStan-issues (tests) and set a baseline

Author: tvdijen

phpstan-baseline-dev.neon

@@ -0,0 +1,13 @@
+parameters:
+	ignoreErrors:
+		-
+			message: '#^Call to an undefined method Mockery\\Expectation\:\:shouldReceive\(\)\.$#'
+			identifier: method.notFound
+			count: 2
+			path: tests/SAML2/Assertion/Validation/ConstraintValidator/SubjectConfirmationMethodTest.php
+
+		-
+			message: '#^Call to an undefined method Mockery\\Expectation\:\:shouldReceive\(\)\.$#'
+			identifier: method.notFound
+			count: 3
+			path: tests/SAML2/Certificate/KeyLoaderTest.php

phpstan-dev.neon

@@ -2,3 +2,5 @@ parameters:
   level: 3
   paths:
     - tests
+includes:
+  - phpstan-baseline-dev.neon

src/SAML2/Assertion/Validation/ConstraintValidator/SubjectConfirmationMethod.php

@@ -21,7 +21,7 @@ public function validate(
     ): void {
         if ($subjectConfirmation->getMethod() !== Constants::CM_BEARER) {
             $result->addError(sprintf(
-                'Invalid Method on SubjectConfirmation, current;y only Bearer (%s) is supported',
+                'Invalid Method on SubjectConfirmation, currently only Bearer (%s) is supported',
                 Constants::CM_BEARER
             ));
         }

src/SAML2/Message.php

@@ -574,7 +574,7 @@ public static function fromXML(DOMElement $xml): Message
     /**
      * Retrieve the Extensions.
      *
-     * @return \SAML2\XML\samlp\Extensions[]
+     * @return \SAML2\XML\Chunk[]
      */
     public function getExtensions(): array
     {
@@ -598,9 +598,9 @@ public function setExtensions(array $extensions): void
      *
      * @param \SAML2\XML\samlp\Extensions $extensions The Extensions
      */
-    public function addExtension(Extensions $extensions): void
+    public function addExtension(Chunk $extension): void
     {
-        $this->extensions[] = $extensions;
+        $this->extensions[] = $extension;
     }
 
 

tests/SAML2/Assertion/ProcessorTest.php

@@ -25,6 +25,8 @@ class ProcessorTest extends MockeryTestCase
 
     protected function setUp(): void
     {
+        parent::setUp();
+
         $this->decrypter = m::mock(Decrypter::class);
         $validator = m::mock(\SAML2\Signature\Validator::class);
         $assertionValidator = m::mock(\SAML2\Assertion\Validation\AssertionValidator::class);

tests/SAML2/Assertion/Validation/ConstraintValidator/NotOnOrAfterTest.php

@@ -4,7 +4,9 @@
 
 namespace SAML2\Assertion\Validation\ConstraintValidator;
 
+use Mockery;
 use PHPUnit\Framework\Attributes\Test;
+use SAML2\Assertion;
 use SAML2\Assertion\Validation\ConstraintValidator\NotOnOrAfter;
 use SAML2\Assertion\Validation\Result;
 use Test\SAML2\ControlledTimeTestCase;
@@ -29,7 +31,7 @@ class NotOnOrAfterTest extends ControlledTimeTestCase
     public function setUp(): void
     {
         parent::setUp();
-        $this->assertion = \Mockery::mock(\SAML2\Assertion::class);
+        $this->assertion = Mockery::mock(Assertion::class);
     }
 
 

tests/SAML2/Assertion/Validation/ConstraintValidator/SessionNotOnOrAfterTest.php

@@ -4,7 +4,9 @@
 
 namespace SAML2\Assertion\Validation\ConstraintValidator;
 
+use Mockery;
 use PHPUnit\Framework\Attributes\Test;
+use SAML2\Assertion;
 use SAML2\Assertion\Validation\ConstraintValidator\SessionNotOnOrAfter;
 use SAML2\Assertion\Validation\Result;
 use Test\SAML2\ControlledTimeTestCase;
@@ -29,7 +31,7 @@ class SessionNotOnOrAfterTest extends ControlledTimeTestCase
     public function setUp(): void
     {
         parent::setUp();
-        $this->assertion = \Mockery::mock(\SAML2\Assertion::class);
+        $this->assertion = Mockery::mock(Assertion::class);
     }
 
 

tests/SAML2/Assertion/Validation/ConstraintValidator/SpIsValidAudienceTest.php

@@ -4,9 +4,12 @@
 
 namespace SAML2\Assertion\Validation\ConstraintValidator;
 
+use Mockery;
 use PHPUnit\Framework\Attributes\Test;
+use SAML2\Assertion;
 use SAML2\Assertion\Validation\ConstraintValidator\SpIsValidAudience;
 use SAML2\Assertion\Validation\Result;
+use SAML2\Configuration\ServiceProvider;
 
 /**
  * Because we're mocking a static call, we have to run it in separate processes so as to no contaminate the other
@@ -31,8 +34,8 @@ class SpIsValidAudienceTest extends \Mockery\Adapter\Phpunit\MockeryTestCase
     public function setUp(): void
     {
         parent::setUp();
-        $this->assertion = \Mockery::mock(\SAML2\Assertion::class);
-        $this->serviceProvider = \Mockery::mock(\SAML2\Configuration\ServiceProvider::class);
+        $this->assertion = Mockery::mock(Assertion::class);
+        $this->serviceProvider = Mockery::mock(ServiceProvider::class);
     }
 
 

tests/SAML2/Assertion/Validation/ConstraintValidator/SubjectConfirmationMethodTest.php

@@ -4,25 +4,30 @@
 
 namespace SAML2\Assertion\Validation\ConstraintValidator;
 
+use Mockery;
+use Mockery\MockInterface;
 use PHPUnit\Framework\Attributes\Test;
 use SAML2\Assertion\Validation\ConstraintValidator\SubjectConfirmationMethod;
 use SAML2\Assertion\Validation\Result;
 use SAML2\Constants;
+use SAML2\XML\saml\SubjectConfirmation;
 
 class SubjectConfirmationMethodTest extends \Mockery\Adapter\Phpunit\MockeryTestCase
 {
     /**
-     * @var \Mockery\MockInterface
+     * @var \Mockery\MockInterface&\SAML2\XML\saml\SubjectConfirmation
      */
-    private $subjectConfirmation;
+    private SubjectConfirmation $subjectConfirmation;
 
 
     /**
      * @return void
      */
     public function setUp(): void
     {
-        $this->subjectConfirmation = new \SAML2\XML\saml\SubjectConfirmation();
+        parent::setUp();
+
+        $this->subjectConfirmation = new SubjectConfirmation();
     }
 
 
@@ -38,7 +43,6 @@ public function subjectConfirmationWithBearerMethodIsValid(): void
         $result = new Result();
 
         $validator->validate($this->subjectConfirmation, $result);
-
         $this->assertTrue($result->isValid());
     }
 

tests/SAML2/Assertion/Validation/ConstraintValidator/SubjectConfirmationNotBeforeTest.php

@@ -7,6 +7,8 @@
 use PHPUnit\Framework\Attributes\Test;
 use SAML2\Assertion\Validation\ConstraintValidator\SubjectConfirmationNotBefore;
 use SAML2\Assertion\Validation\Result;
+use SAML2\XML\saml\SubjectConfirmation;
+use SAML2\XML\saml\SubjectConfirmationData;
 use Test\SAML2\ControlledTimeTestCase;
 
 /**
@@ -15,15 +17,11 @@
  */
 class SubjectConfirmationNotBeforeTest extends ControlledTimeTestCase
 {
-    /**
-     * @var \Mockery\MockInterface
-     */
-    private $subjectConfirmation;
+    /** @var \SAML2\XML\saml\SubjectConfirmation */
+    private SubjectConfirmation $subjectConfirmation;
 
-    /**
-     * @var \Mockery\MockInterface
-     */
-    private $subjectConfirmationData;
+    /** @var \SAML2\XML\saml\SubjectConfirmationData */
+    private SubjectConfirmationData $subjectConfirmationData;
 
 
     /**
@@ -32,8 +30,9 @@ class SubjectConfirmationNotBeforeTest extends ControlledTimeTestCase
     public function setUp(): void
     {
         parent::setUp();
-        $this->subjectConfirmation = new \SAML2\XML\saml\SubjectConfirmation();
-        $this->subjectConfirmationData = new \SAML2\XML\saml\SubjectConfirmationData();
+
+        $this->subjectConfirmation = new SubjectConfirmation();
+        $this->subjectConfirmationData = new SubjectConfirmationData();
         $this->subjectConfirmation->setSubjectConfirmationData($this->subjectConfirmationData);
     }