[core] Fix sigma killing process when SigmaContainer is unmount

If `SigmaContainer` is unmount, the sigma kill process was not called.
The GC should handle it, but in the case where a graph is given to the
component and is still alive, GC do nothing.

Author: sim51

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## Version 5.0.3
+
+### Fixes
+
+- Fix `sigma` killing process when `SigmaContainer` is unmount.
+
 ## Version 5.0.2
 
 ### Fixes

packages/core/src/components/SigmaContainer.tsx

@@ -90,23 +90,27 @@ const SigmaContainerComponent = <
    * => create sigma
    */
   useEffect(() => {
-    setSigma((prev) => {
-      let instance: Sigma<N, E, G> | null = null;
-      if (containerRef.current !== null) {
-        let sigGraph = new Graph<N, E, G>();
-        if (graph) {
-          sigGraph = typeof graph === 'function' ? new graph() : graph;
-        }
+    let instance: Sigma<N, E, G> | null = null;
+    if (containerRef.current !== null) {
+      let sigGraph = new Graph<N, E, G>();
+      if (graph) {
+        sigGraph = typeof graph === 'function' ? new graph() : graph;
+      }
+      instance = new Sigma(sigGraph, containerRef.current, sigmaSettings);
+      setSigma((prev) => {
         let prevCameraState: CameraState | null = null;
         if (prev) {
           prevCameraState = prev.getCamera().getState();
-          prev.kill();
         }
-        instance = new Sigma(sigGraph, containerRef.current, sigmaSettings);
-        if (prevCameraState) instance.getCamera().setState(prevCameraState);
+        if (prevCameraState) instance!.getCamera().setState(prevCameraState);
+        return instance;
+      });
+    }
+    return () => {
+      if (instance) {
+        instance.kill();
       }
-      return instance;
-    });
+    };
   }, [containerRef, graph, sigmaSettings]);
 
   /**