Remove auto-update of config file

Author: bensilverfin

CHANGELOG.md

@@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file.
 
 
 ## [1.55.0] (25/02/2026)
-In this update we have introduced a new feature that allows you to move text parts into subdirectories. The config file will be updated to reflect the new location of the text parts.
+In this update we have introduced a new feature that allows you to move text parts into subdirectories. 
 
 ## [1.54.0] (17/02/2026)
 Added `create-test` command support for account templates (fetches template data, period data, and custom data).

lib/templates/accountTemplate.js

@@ -91,9 +91,6 @@ class AccountTemplate {
 
     if (!this.#validateFolderName(name, templateConfig)) return false;
 
-    // Scan disk for text parts and update config paths
-    templateConfig = this.#syncTextPartsFromDisk(name, templateConfig);
-
     const template = this.#filterConfigItems(templateConfig);
 
     // Liquid tests
@@ -214,27 +211,6 @@ class AccountTemplate {
     }
   }
 
-  /**
-   * For text parts already listed in the config, scan the disk to find their actual location.
-   * This allows parts to be moved into subdirectories without manually editing the config.
-   * Only parts that are already in the config are updated — new files on disk are not added.
-   */
-  static #syncTextPartsFromDisk(name, templateConfig) {
-    if (!templateConfig.text_parts || Object.keys(templateConfig.text_parts).length === 0) {
-      return templateConfig;
-    }
-
-    const diskParts = fsUtils.scanTextParts(this.TEMPLATE_TYPE, name);
-
-    for (const partName of Object.keys(templateConfig.text_parts)) {
-      if (diskParts[partName]) {
-        templateConfig.text_parts[partName] = diskParts[partName];
-      }
-    }
-
-    return templateConfig;
-  }
-
   static #createLiquidTest(name, templateConfig) {
     const testContent = "# Add your Liquid Tests here";
     fsUtils.createLiquidTestFiles(this.TEMPLATE_TYPE, name, testContent);

lib/templates/reconciliationText.js

@@ -100,9 +100,6 @@ class ReconciliationText {
     const originalConfig = JSON.parse(JSON.stringify(templateConfig));
     templateConfig = this.#checkHandleAndNameInConfig(templateConfig, handle);
 
-    // Scan disk for text parts and update config paths
-    templateConfig = this.#syncTextPartsFromDisk(handle, templateConfig);
-
     let template = this.#filterConfigItems(templateConfig);
     template = this.#checkReconciliationType(template);
     // Liquid Tests
@@ -224,27 +221,6 @@ class ReconciliationText {
     return templateConfig;
   }
 
-  /**
-   * For text parts already listed in the config, scan the disk to find their actual location.
-   * This allows parts to be moved into subdirectories without manually editing the config.
-   * Only parts that are already in the config are updated — new files on disk are not added.
-   */
-  static #syncTextPartsFromDisk(handle, templateConfig) {
-    if (!templateConfig.text_parts || Object.keys(templateConfig.text_parts).length === 0) {
-      return templateConfig;
-    }
-
-    const diskParts = fsUtils.scanTextParts(this.TEMPLATE_TYPE, handle);
-
-    for (const partName of Object.keys(templateConfig.text_parts)) {
-      if (diskParts[partName]) {
-        templateConfig.text_parts[partName] = diskParts[partName];
-      }
-    }
-
-    return templateConfig;
-  }
-
   static #createLiquidTest(handle, templateConfig) {
     // Liquid Test YAML
     const testContent = "# Add your Liquid Tests here";

tests/lib/templates/reconciliationTexts.test.js

@@ -570,87 +570,47 @@ describe("ReconciliationText", () => {
       expect(result.name_nl).toBe(handle);
     });
 
-    it("should find a text part that was moved into a subdirectory", () => {
-      // Move part_1.liquid into a subfolder
+    it("should read a text part from a subdirectory when config path is set manually", () => {
+      // User manually set config to point to a subfolder; file lives there
       const subDir = path.join(templateDir, "text_parts", "tables");
       fs.mkdirSync(subDir, { recursive: true });
       fs.renameSync(part1LiquidPath, path.join(subDir, "part_1.liquid"));
 
+      const configWithSubfolderPath = { ...configContent, text_parts: { part_1: "text_parts/tables/part_1.liquid" } };
+      fs.writeFileSync(configPath, JSON.stringify(configWithSubfolderPath));
+
       const result = ReconciliationText.read(handle);
 
       expect(result.text_parts).toEqual([{ name: "part_1", content: "Part 1 content" }]);
     });
 
-    it("should update config.json when a text part is moved to a subdirectory", () => {
-      // Move part_1.liquid into a subfolder
-      const subDir = path.join(templateDir, "text_parts", "tables");
-      fs.mkdirSync(subDir, { recursive: true });
-      fs.renameSync(part1LiquidPath, path.join(subDir, "part_1.liquid"));
-
-      ReconciliationText.read(handle);
-
-      const updatedConfig = JSON.parse(fs.readFileSync(configPath, "utf-8"));
-      expect(updatedConfig.text_parts.part_1).toBe("text_parts/tables/part_1.liquid");
-    });
-
-    it("should find a text part nested multiple levels deep", () => {
-      // Move part_1.liquid into a deeply nested subfolder
-      // First, ensure no leftover from other tests by recreating the file at original location
-      if (!fs.existsSync(part1LiquidPath)) {
-        fs.writeFileSync(part1LiquidPath, "Part 1 content");
-      }
-      // Remove any subdirectories left from previous tests
-      const textPartsDir = path.join(templateDir, "text_parts");
-      for (const entry of fs.readdirSync(textPartsDir)) {
-        const fullPath = path.join(textPartsDir, entry);
-        if (fs.statSync(fullPath).isDirectory()) {
-          fs.rmSync(fullPath, { recursive: true, force: true });
-        }
-      }
+    it("should read a text part nested multiple levels deep when config path is set manually", () => {
       const deepDir = path.join(templateDir, "text_parts", "section", "subsection");
       fs.mkdirSync(deepDir, { recursive: true });
-      fs.renameSync(part1LiquidPath, path.join(deepDir, "part_1.liquid"));
+      fs.writeFileSync(path.join(deepDir, "part_1.liquid"), "Part 1 content");
+      fs.unlinkSync(part1LiquidPath);
+
+      const configWithDeepPath = { ...configContent, text_parts: { part_1: "text_parts/section/subsection/part_1.liquid" } };
+      fs.writeFileSync(configPath, JSON.stringify(configWithDeepPath));
 
       const result = ReconciliationText.read(handle);
 
       expect(result.text_parts).toEqual([{ name: "part_1", content: "Part 1 content" }]);
-
-      const updatedConfig = JSON.parse(fs.readFileSync(configPath, "utf-8"));
-      expect(updatedConfig.text_parts.part_1).toBe("text_parts/section/subsection/part_1.liquid");
     });
 
-    it("should not add new files on disk that are not in the config", () => {
-      // Add a new liquid file that is NOT listed in config
+    it("should only include parts listed in the config", () => {
+      // Extra file on disk not in config is ignored
       fs.writeFileSync(path.join(templateDir, "text_parts", "extra_part.liquid"), "Extra content");
 
       const result = ReconciliationText.read(handle);
 
-      // Should only contain part_1, not extra_part
       expect(result.text_parts).toEqual([{ name: "part_1", content: "Part 1 content" }]);
-
-      const updatedConfig = JSON.parse(fs.readFileSync(configPath, "utf-8"));
-      expect(updatedConfig.text_parts).not.toHaveProperty("extra_part");
     });
 
-    it("should keep config entry unchanged when a text part file is missing from disk", () => {
-      // Delete part_1.liquid from disk but keep it in the config
+    it("should throw when a text part in config is missing from disk", () => {
       fs.unlinkSync(part1LiquidPath);
 
-      // The config should still have the original path (not removed by syncTextPartsFromDisk)
-      // We can't call read() fully because it will fail when trying to read the missing file,
-      // so we just verify the config is not modified by writing it and checking it
-      const configBefore = JSON.parse(fs.readFileSync(configPath, "utf-8"));
-      expect(configBefore.text_parts.part_1).toBe("text_parts/part_1.liquid");
-
-      // read() will fail at readPartsLiquid, but the config should not have been altered
-      try {
-        ReconciliationText.read(handle);
-      } catch (e) {
-        // Expected to fail when reading the missing file
-      }
-
-      const configAfter = JSON.parse(fs.readFileSync(configPath, "utf-8"));
-      expect(configAfter.text_parts.part_1).toBe("text_parts/part_1.liquid");
+      expect(() => ReconciliationText.read(handle)).toThrow();
     });
   });
 });