feat: firm_ids parameter

Author: AgustinSilverfin

bin/cli.js

@@ -496,7 +496,8 @@ program
   .option("-h, --handle <handles...>", "Specify reconciliation text handle(s) - can specify multiple")
   .option("-at, --account-template <names...>", "Specify account detail template name(s) - can specify multiple")
   .option("-s, --shared-part <names...>", "Specify shared part name(s) - can specify multiple")
-  .option("-i, --id <sampler-id>", "Specify an existing sampler ID to fetch results for (optional)")
+  .option("--firm-ids <firm-ids...>", "Specify firm ID(s) to run the sampler against - can specify multiple (optional)")
+  .option("--id <sampler-id>", "Specify an existing sampler ID to fetch results for (optional)")
   .action(async (options) => {
     // If an existing sampler ID is provided, fetch and display results
     if (options.id) {
@@ -520,7 +521,9 @@ program
       sharedParts: sharedParts,
     };
 
-    await new LiquidSamplerRunner(options.partner).run(templateHandles);
+    const firmIds = options.firmIds || [];
+
+    await new LiquidSamplerRunner(options.partner).run(templateHandles, firmIds);
   });
 
 // Create Liquid Test

lib/liquidSamplerRunner.js

@@ -23,9 +23,10 @@ class LiquidSamplerRunner {
    * @param {Array<string>} templateHandles.reconciliationTexts - Array of reconciliation text handles
    * @param {Array<string>} templateHandles.accountTemplates - Array of account template names
    * @param {Array<string>} templateHandles.sharedParts - Array of shared part names
+   * @param {Array<number>} firmIds - Array of firm IDs to use in the sampler
    * @returns {Promise<void>}
    */
-  async run(templateHandles = {}) {
+  async run(templateHandles = {}, firmIds = []) {
     try {
       // Validate at least one template specified
       const { reconciliationTexts = [], accountTemplates = [], sharedParts = [] } = templateHandles;
@@ -35,7 +36,7 @@ class LiquidSamplerRunner {
       }
 
       // Build payload
-      const samplerParams = await this.#buildSamplerParams(templateHandles);
+      const samplerParams = await this.#buildSamplerParams(templateHandles, firmIds);
 
       consola.info(`Starting sampler run with ${samplerParams.templates.length} template(s)...`);
 
@@ -71,6 +72,11 @@ class LiquidSamplerRunner {
 
       const response = await SF.readSamplerRun(this.partnerId, samplerId);
 
+      if (!response || !response.data) {
+        consola.error("Failed to fetch sampler run status. Is staging running?");
+        process.exit(1);
+      }
+
       await this.#handleSamplerResponse(response.data);
     } catch (error) {
       errorUtils.errorHandler(error);
@@ -83,9 +89,10 @@ class LiquidSamplerRunner {
    * @param {Array<string>} templateHandles.reconciliationTexts - Array of reconciliation text handles
    * @param {Array<string>} templateHandles.accountTemplates - Array of account template names
    * @param {Array<string>} templateHandles.sharedParts - Array of shared part names
+   * @param {Array<number>} firmIds - Array of firm IDs to use in the sampler
    * @returns {Object} Sampler payload with templates array
    */
-  async #buildSamplerParams(templateHandles = {}) {
+  async #buildSamplerParams(templateHandles = {}, firmIds = []) {
     const templates = [];
     const { reconciliationTexts = [], accountTemplates = [], sharedParts = [] } = templateHandles;
 
@@ -175,7 +182,7 @@ class LiquidSamplerRunner {
       });
     }
 
-    return { templates };
+    return { templates, firm_ids: firmIds };
   }
 
   /**
@@ -186,8 +193,8 @@ class LiquidSamplerRunner {
    */
   async #fetchAndWaitSamplerResult(samplerId) {
     let samplerRun = { status: "pending" };
-    const pollingDelay = 10000; // 10 seconds
-    const waitingLimit = 2000000; // 2000 seconds
+    const pollingDelay = 15000; // 15 seconds
+    const waitingLimit = 3600000; // 1 hour
 
     spinner.spin("Running sampler...");
     let waitingTime = 0;
@@ -203,7 +210,7 @@ class LiquidSamplerRunner {
 
       if (waitingTime >= waitingLimit) {
         spinner.stop();
-        consola.error("Timeout. Try to run your sampler again");
+        consola.error("Timeout. Try to fetch the status by using the --id flag, if not run your sampler again");
         process.exit(1);
       }
     }
@@ -237,6 +244,11 @@ class LiquidSamplerRunner {
         }
         break;
 
+      case "pending":
+      case "running":
+        consola.info(`Sampler run is still in progress. Current status: "${response.status}". Please check again later.`);
+        break;
+
       default:
         consola.error(`Unexpected sampler status: ${response.status}`);
         process.exit(1);