SF-3807 Store drafts in draft tab for speedy chapter navigation#3899
Open
RaymondLuong3 wants to merge 2 commits into
Open
SF-3807 Store drafts in draft tab for speedy chapter navigation#3899RaymondLuong3 wants to merge 2 commits into
RaymondLuong3 wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3899 +/- ##
=======================================
Coverage 80.90% 80.91%
=======================================
Files 630 630
Lines 40677 40694 +17
Branches 6578 6605 +27
=======================================
+ Hits 32909 32926 +17
+ Misses 6741 6740 -1
- Partials 1027 1028 +1 ☔ View full report in Codecov by Sentry. |
3ba146c to
e0ab5b9
Compare
e0ab5b9 to
57368bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the getDraft method from draft handling service in favour of the getBookDraft. It also implements a cache so that getting drafts is speedier when accessing a book that is already cached. The draft tab component has been updated to use the getBookDraft method which allows navigating between chapters to require minimal load time.
This change is