Code review fixes

Author: RaymondLuong3

src/SIL.XForge.Scripture/ClientApp/src/app/shared/text/text.component.spec.ts

@@ -118,7 +118,7 @@ describe('TextComponent', () => {
     env.runWithDelayedGetText(env.notPresentTextDocId, () => {
       env.id = env.notPresentTextDocId;
       env.waitForEditor();
-      expect(env.component.placeholder).toEqual('text.book_does_not_exist');
+      expect(env.component.placeholder).toEqual('text.this_book_does_not_exist');
     });
 
     // The user is offline and goes to a location that the project does not have. The placeholder should indicate
@@ -128,7 +128,7 @@ describe('TextComponent', () => {
     env.runWithDelayedGetText(env.notPresentTextDocId, () => {
       env.id = env.notPresentTextDocId;
       env.waitForEditor();
-      expect(env.component.placeholder).toEqual('text.book_does_not_exist');
+      expect(env.component.placeholder).toEqual('text.this_book_does_not_exist');
     });
     env.onlineStatus = true;
     env.waitForEditor();
@@ -146,7 +146,7 @@ describe('TextComponent', () => {
     env.waitForEditor();
     env.id = env.notPresentTextDocId;
     env.waitForEditor();
-    expect(env.component.placeholder).toEqual('text.book_does_not_exist');
+    expect(env.component.placeholder).toEqual('text.this_book_does_not_exist');
 
     const callback: (env: TestEnvironment) => void = (env: TestEnvironment) => {
       env.realtimeService.addSnapshot<User>(UserDoc.COLLECTION, {

src/SIL.XForge.Scripture/ClientApp/src/app/shared/text/text.component.ts

@@ -351,7 +351,7 @@ export class TextComponent implements AfterViewInit, OnDestroy {
         const bookName = this.transloco.translate(`canon.book_names.${bookId}`);
         return this.project.texts.some(t => t.bookNum === this.id!.bookNum)
           ? this.transloco.translate('text.chapter_does_not_exist', { projectName: this.project.name })
-          : this.transloco.translate('text.book_does_not_exist', { bookName, projectName: this.project.name });
+          : this.transloco.translate('text.this_book_does_not_exist', { bookName, projectName: this.project.name });
       case 'offline-or-loading':
         if (this.onlineStatusService.isOnline) {
           return this.transloco.translate('text.loading');

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.ts

@@ -481,10 +481,6 @@ export class EditorComponent extends DataLoadingComponent implements OnDestroy,
     return this._bookNum;
   }
 
-  get bookName(): string {
-    return this.text == null ? '' : Canon.bookNumberToEnglishName(this.text.bookNum);
-  }
-
   get currentUser(): User | undefined {
     return this.currentUserDoc == null ? undefined : this.currentUserDoc.data;
   }

src/SIL.XForge.Scripture/ClientApp/src/assets/i18n/checking_en.json

@@ -485,13 +485,13 @@
     "upgrade_safari": "{{ newLine }}We recommend upgrading to the latest {{ safariLink }}."
   },
   "text": {
-    "book_does_not_exist": "{{ bookName }} does not exist in {{ projectName }}",
     "book_is_empty": "This book is empty. Add chapters in Paratext.",
     "chapter_does_not_exist": "This chapter does not exist in {{ projectName }}",
     "error": "An error occurred while loading the text",
     "loading": "Loading...",
     "not_available_offline": "This text is not available offline. Connect to the Internet to see the text.",
-    "permission_denied": "You do not have permission to view this text. Please contact the project's administrator to get permission."
+    "permission_denied": "You do not have permission to view this text. Please contact the project's administrator to get permission.",
+    "this_book_does_not_exist": "{{ bookName }} does not exist in {{ projectName }}"
   },
   "text_chooser_dialog": {
     "cancel": "Cancel",