Skip to content

Commit 7a3c968

Browse files
committed
Cast rather than using .Value
1 parent 3ca60c8 commit 7a3c968

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

src/SIL.Machine/Corpora/ParatextProjectTermsParserBase.cs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,13 +117,14 @@ public IEnumerable<KeyTerm> Parse(
117117
.Descendants()
118118
.Where(n => n.Name.LocalName == "TermRendering")
119119
.Where(ele => ((string)ele.Attribute("Guess") ?? "false") == "false")
120-
.Select(ele => (ele.Attribute("Id").Value, ele))
120+
.Select(ele => ((string)ele.Attribute("Id"), ele))
121+
.Where(kvp => kvp.Item1 != null)
121122
.Where(kvp => IsInCategory(kvp.Item1, termCategories, termIdToCategory))
122123
.Where(kvp => IsInChapters(kvp.Item1, chapters, termIdToReferences))
123124
.Select(kvp =>
124125
{
125126
string id = kvp.Item1.Replace("\n", "&#xA");
126-
string rendering = kvp.Item2.Element("Renderings").Value;
127+
string rendering = (string)kvp.Item2.Element("Renderings") ?? "";
127128
IReadOnlyList<string> renderings = GetRenderingsWithPattern(rendering);
128129
return (id, renderings);
129130
})
@@ -138,7 +139,8 @@ public IEnumerable<KeyTerm> Parse(
138139
termsGlosses = termsGlossesDoc
139140
.Descendants()
140141
.Where(n => n.Name.LocalName == "Localization")
141-
.Select(ele => (ele.Attribute("Id").Value, ele))
142+
.Select(ele => ((string)ele.Attribute("Id"), ele))
143+
.Where(kvp => kvp.Item1 != null)
142144
.Where(kvp => IsInCategory(kvp.Item1, termCategories, termIdToCategory))
143145
.Where(kvp => IsInChapters(kvp.Item1, chapters, termIdToReferences))
144146
.Select(kvp =>
@@ -309,7 +311,7 @@ IDictionary<string, ImmutableHashSet<VerseRef>> TermReferences
309311
var termIdToReferences = new Dictionary<string, ImmutableHashSet<VerseRef>>();
310312
foreach (XElement term in biblicalTermsDocument.Descendants().Where(n => n.Name.LocalName == "Term"))
311313
{
312-
string termId = term.Attribute("Id").Value;
314+
string termId = (string)term.Attribute("Id");
313315
if (termId == null)
314316
continue;
315317

0 commit comments

Comments
 (0)