Make fwdata api respect nullable return types

Author: myieye

backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs

@@ -953,7 +953,8 @@ public IAsyncEnumerable<Entry> SearchEntries(string query, QueryOptions? options
 
     public Task<Entry?> GetEntry(Guid id)
     {
-        return Task.FromResult<Entry?>(FromLexEntry(EntriesRepository.GetObject(id)));
+        EntriesRepository.TryGetObject(id, out var lexEntry);
+        return Task.FromResult(lexEntry is null ? null : FromLexEntry(lexEntry));
     }
 
     public async Task<Entry> CreateEntry(Entry entry, CreateEntryOptions? options = null)
@@ -1423,7 +1424,7 @@ private void ApplySenseToLexSense(Sense sense, ILexSense lexSense)
 
     public Task<Sense?> GetSense(Guid entryId, Guid id)
     {
-        var lcmSense = SenseRepository.GetObject(id);
+        SenseRepository.TryGetObject(id, out var lcmSense);
         return Task.FromResult(lcmSense is null ? null : FromLexSense(lcmSense));
     }
 
@@ -1550,7 +1551,7 @@ public Task DeleteSense(Guid entryId, Guid senseId)
 
     public Task<ExampleSentence?> GetExampleSentence(Guid entryId, Guid senseId, Guid id)
     {
-        var lcmExampleSentence = ExampleSentenceRepository.GetObject(id);
+        ExampleSentenceRepository.TryGetObject(id, out var lcmExampleSentence);
         return Task.FromResult(lcmExampleSentence is null ? null : FromLexExampleSentence(senseId, lcmExampleSentence));
     }
 

backend/FwLite/FwLiteProjectSync.Tests/CrdtRepairTests.cs

@@ -226,7 +226,7 @@ public async Task CrdtEntryMissingTranslationId_FwExampleSentenceRemoved_FullSyn
         // act
         await FwDataApi.DeleteExampleSentence(entryId, senseId, exampleSentenceId);
         var result = await SyncService.Sync(CrdtApi, FwDataApi);
-        result.CrdtChanges.Should().Be(1, "the crdt translation was removed");
+        result.CrdtChanges.Should().Be(1, "the crdt example-sentence was removed");
 
         // assert - the crdt translation was also removed
         var updatedCrdtEntry = await CrdtApi.GetEntry(crdtEntry.Id);