Hi.
We often need to download SG thumbnails from the thumbnail's URL.
We wrote code to do that which is essentially duplicated code from sg.download_attachment, the main difference being that instead of passing in an attachment, we directly pass the URL that the function extracts at
|
url = self.get_attachment_download_url(attachment) |
Could we split the code into 2 functions, one to download by URL, and one to download by attachment, as it's essentially the same code?
I can put an MR if you're not against the idea.
Hi.
We often need to download SG thumbnails from the thumbnail's URL.
We wrote code to do that which is essentially duplicated code from sg.download_attachment, the main difference being that instead of passing in an attachment, we directly pass the URL that the function extracts at
python-api/shotgun_api3/shotgun.py
Line 2936 in a1de54e
Could we split the code into 2 functions, one to download by URL, and one to download by attachment, as it's essentially the same code?
I can put an MR if you're not against the idea.