error message does not identify source

[DinoChiesa]

AI Policy: acknowledged

What happened
When I connect into my remote host, I see:
warning: client protocol ("0.4.1") is newer than daemon protocol (version "0.3.5"), try restarting your daemon

This is apparently #377 , originating from shpool. but I am not here to report that there is a mismatch. Instead I am reporting that the error message is not helpful. there is no indication that shpool is the source of this message. because I am using shpool through another layer (an internal tool called "roadwarrior" invokes it), and because my shell is starting up so it runs through .bash_profile and so on, it was not clear to me, immediately, what program or tool was issuing this message.

What I expected to happen
Something like
shpool warning: client protocol ("0.4.1") is newer than daemon protocol (version "0.3.5"), try restarting your daemon

or

warning: shpool client protocol ("0.4.1") is newer than daemon protocol (version "0.3.5"), try restarting your daemon

More info
I restarted the shpool daemon and the message went away.

I am not sure WHY shpool needed to be restarted. My machine had just restarted two days ago as part of periodic maintenance. I had the latest shpool already. Anyway I'm not interested in spending time to diagnose that.

The main point here is to suggest the message is less than 100% helpful when shpool is used in this way.

Version info

$ shpool version
shpool 0.10.2 (cl/929545807)

[ethanpailes]

Yeah these are all fair points. I think we should do two things to try to improve this message:

1. prefix the message with "shpool: "
2. include the version for the shpool binary as well (which will unfortunately require a library API breaking change I think).