From 4f2ee3c294539a2fd65c159f92dd0c390052f7cd Mon Sep 17 00:00:00 2001 From: Justin Gordon Date: Mon, 13 Jul 2026 19:20:33 -1000 Subject: [PATCH 1/2] fix: provide URL to SSR renderer VM --- renderer/node-renderer.js | 1 + spec/requests/server_render_check_spec.rb | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/renderer/node-renderer.js b/renderer/node-renderer.js index 392e29897..766852010 100644 --- a/renderer/node-renderer.js +++ b/renderer/node-renderer.js @@ -1,4 +1,5 @@ const path = require('path'); +const { URL } = require('node:url'); const { reactOnRailsProNodeRenderer } = require('react-on-rails-pro-node-renderer'); const isProduction = process.env.NODE_ENV === 'production'; diff --git a/spec/requests/server_render_check_spec.rb b/spec/requests/server_render_check_spec.rb index fd3efa475..53d357ba2 100644 --- a/spec/requests/server_render_check_spec.rb +++ b/spec/requests/server_render_check_spec.rb @@ -11,6 +11,13 @@ .to include("Comments") end + it "server renders RouterApp NavLinks that require the URL VM global" do + get root_path + html_nodes = Nokogiri::HTML(response.body) + + expect(html_nodes.at_css("#RouterApp-react-component-0 a[href='/react-router']").text).to eq("Route") + end + it "generates no server rendered HTML if server rendering not enabled" do get simple_path html_nodes = Nokogiri::HTML(response.body) From 2f24defd218faf162599c2f872265171879238fd Mon Sep 17 00:00:00 2001 From: Justin Gordon Date: Mon, 13 Jul 2026 19:30:55 -1000 Subject: [PATCH 2/2] test: use parsed SSR response body --- spec/requests/server_render_check_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/requests/server_render_check_spec.rb b/spec/requests/server_render_check_spec.rb index 53d357ba2..88aaaa866 100644 --- a/spec/requests/server_render_check_spec.rb +++ b/spec/requests/server_render_check_spec.rb @@ -13,7 +13,7 @@ it "server renders RouterApp NavLinks that require the URL VM global" do get root_path - html_nodes = Nokogiri::HTML(response.body) + html_nodes = response.parsed_body expect(html_nodes.at_css("#RouterApp-react-component-0 a[href='/react-router']").text).to eq("Route") end