Follow-up: Repair review-app setup and exercise deployed smoke

[justin808]

Summary

React on Rails 17 RC12 validation PR #783 merged and is reachable from the default branch. Its review-app attempt stopped during pre-existing setup/configuration validation, before a usable application could be built and deployed, so deployed behavioral smoke never ran.

The RC12 package update passed local validation, hosted CI, and review. No React on Rails RC12 code regression was found.

Acceptance criteria

• Repair the repository-owned review-app setup/configuration that prevents the workflow from reaching image build and deployment.
• Exercise the repaired path from a current default-based verification PR and retain the exact tested commit plus public workflow evidence.
• Confirm image build, deployment, and a usable review endpoint complete successfully.
• Run behavioral smoke that verifies expected server-rendered HTML, the headline RSC/client interaction, and no new browser console errors.
• Clean up the temporary review app after evidence is retained.

Evidence

• Merged RC12 validation PR: Validate React on Rails 17 RC12 #783
• Setup-stage workflow attempt: https://github.com/shakacode/react-webpack-rails-tutorial/actions/runs/29512221119
• Fleet tracker: Release gate: react_on_rails 17.0.0 react_on_rails#3823

This follow-up is an infrastructure/verification repair, not evidence against RC12.

[justin808]

qa-evidence v1

status: external-gate-failing
default_sha: 8266366
verification_head_sha: 63601d7
verification_pr: #786
automatic_validation_run: https://github.com/shakacode/react-webpack-rails-tutorial/actions/runs/29635625599
deploy_run: https://github.com/shakacode/react-webpack-rails-tutorial/actions/runs/29635634000
explicit_cleanup_run: https://github.com/shakacode/react-webpack-rails-tutorial/actions/runs/29635805984
pr_close_cleanup_run: https://github.com/shakacode/react-webpack-rails-tutorial/actions/runs/29635833923
image_build: FAIL (not reached)
deploy: FAIL (not reached)
endpoint_reachable: FAIL (not reached)
ssr_rsc_behavior: FAIL (not reached)
client_headline_navigation: FAIL (not reached)
client_console_errors_zero: FAIL (not reached)
cheap_unhappy_path: PASS (automatic PR run validated the exact head and intentionally stopped before first app creation)
cleanup: PASS
verification_pr_closed_unmerged: PASS
remote_verification_branch_deleted: PASS
default_reachable: PASS
failure_phase: initial review-app setup
sanitized_signature: repo-owned node-renderer workload sizing was rejected by external resource-ratio validation before image build; this is independent of the repaired probe syntax
issue_disposition: remains open; no waiver
tested_at: 2026-07-18T07:34:53Z

[justin808]

QA Evidence\n\n- QA lane: ror17-fleet-c-qa-1; Tutorial replay worktree removed after cleanup; claim renewed and active during closeout.\n- Scope checked: exact default through a fresh verification PR, default validation, trusted deploy stages, bounded health wait, both cleanup paths, branch removal, and default reachability.\n- Tested at: PR #788 head bc976c4 from default 803b592.\n- Automated checks: default validation passed in https://github.com/shakacode/react-webpack-rails-tutorial/actions/runs/29640291592; trusted deploy was cancelled after the single 15-minute bound in https://github.com/shakacode/react-webpack-rails-tutorial/actions/runs/29640295886; explicit cleanup passed in https://github.com/shakacode/react-webpack-rails-tutorial/actions/runs/29640801654; close-trigger cleanup passed in https://github.com/shakacode/react-webpack-rails-tutorial/actions/runs/29640824220.\n- Manual checks: endpoint usability, SSR/RSC behavior, client navigation, and console state remain UNKNOWN because deploy/health never reached a durable conclusion within the bound.\n- Findings: external-gate-failing. Image build passed, but deploy/health did not conclude. No waiver or inferred success.\n- QA required: yes.\n- QA required rationale: the merged workflow/config repair must be proved by a fresh-default deployment and behavioral smoke.\n- QA lane status: blocked.\n- Release-blocking status: blocked.\n- Process-gap disposition: checklist+replay.\n\nPR #788 was closed unmerged, its refs and worktree were removed, both cleanup paths passed, and exact default remained reachable. Issue #784 remains open for diagnosis and a later fresh-default replay.\n\n

[justin808]

QA Evidence

• Verdict: FAIL
• Final state: external-gate-failing
• Sanitized category: rollout at pre-resource-creation/setup; root ownership remains UNKNOWN.
• Build: PASS — image build completed.
• Deploy: FAIL — the deploy command remained active at the 15-minute total bound.
• Rollout ready: FAIL — no ready rollout became observable; the health step never started.
• Endpoint usability/status: UNKNOWN — deployment did not become ready.
• Server-rendered output and SSR behavior: UNKNOWN — deployment did not become ready.
• RSC behavior: UNKNOWN — deployment did not become ready.
• Client navigation and console errors: UNKNOWN — deployment did not become ready.
• Cheap unhappy path: UNKNOWN — deployment did not become ready.
• Explicit cleanup: PASS.
• PR-close cleanup: PASS.
• Provider cleanup verification: PASS.
• Verification PR: QA: replay review-app deployment from current default #789
• Deploy evidence: https://github.com/shakacode/react-webpack-rails-tutorial/actions/runs/29644264826
• Explicit cleanup evidence: https://github.com/shakacode/react-webpack-rails-tutorial/actions/runs/29644769190
• Close-trigger cleanup evidence: https://github.com/shakacode/react-webpack-rails-tutorial/actions/runs/29644793688
• Exact default reachability: PASS for 803b592bd77a330cb61c63dc793d12cf3ee4bf2f.
• Remote verification ref removal: PASS.
• Minimal repo fix envelope: none justified by this replay; no workflow or configuration file should be changed without stronger evidence.
• QA lane: stable tutorial review-app lane; claim active and heartbeat live.
• Scope checked: one inert-marker PR from exact default, build/deploy metadata, low-frequency sanitized rollout snapshots, cleanup, and default reachability.
• Tested at: PR QA: replay review-app deployment from current default #789 head 7de2c9bd8bed7d78672bcbf4021325bd0b1ec6a0.
• Automated checks: deploy and both cleanup workflow runs linked above.
• Manual checks: blocked before endpoint availability; live application behavior remains UNKNOWN.
• Findings: external gate remains blocked in rollout before readiness.
• QA required: yes
• QA required rationale: fresh-default deployed behavior is the acceptance gate for this issue.
• QA lane status: blocked
• Release-blocking status: blocked
• Process-gap disposition: not applicable

[justin808]

Fresh-default replay result: external gate still failing.

• Verification PR: Verify review-app workflow from fresh default #790
• Default SHA: 803b592bd77a330cb61c63dc793d12cf3ee4bf2f
• Verification head: 9e2fd513a7a6ad831baec7a0166ffe157e52dfa8 (empty commit only)
• Deploy workflow: https://github.com/shakacode/react-webpack-rails-tutorial/actions/runs/29650213855
• Result: setup and image build completed, then deployment remained active through one dedicated 15-minute readiness watch. Readiness was not observed, so browser smoke did not start. The run was cancelled after the bound; no root cause is inferred from this timeout.
• Cleanup workflow: https://github.com/shakacode/react-webpack-rails-tutorial/actions/runs/29650940093 (successful)
• Next action: inspect the deployment-stage failure outside this replay, then run one new fresh-default replay with the same stage-aware bounds and complete browser smoke only after readiness.

QA Evidence

• QA lane: ror17-fleet-c-tutorial-replay-2; isolated worktree; private claim active during replay
• Scope checked: merged default-branch issue-comment review-app path for PR Verify review-app workflow from fresh default #790
• Tested at: default 803b592bd77a330cb61c63dc793d12cf3ee4bf2f; verification head 9e2fd513a7a6ad831baec7a0166ffe157e52dfa8
• Automated checks: one comment-triggered workflow; upstream build completed; readiness not proven
• Manual checks: blocked because readiness was not observed; no endpoint or browser assertion was claimed
• Findings: readiness timeout; root cause unproven
• QA required: yes
• QA required rationale: post-merge review-app behavior requires deployed browser proof
• QA lane status: blocked
• Release-blocking status: blocked
• Process-gap disposition: checklist+replay

[justin808]

Fresh-default review-app replay #3 — external-gate-failing

This verification-only replay used current master and one disposable empty-commit PR. It did not modify product or workflow code, and the PR was closed unmerged.

Stage	Result	Evidence
Trusted base	PASS	master at 803b592bd77a330cb61c63dc793d12cf3ee4bf2f
Verification head	PASS	PR #791 at 415f9a4e3dfcbb024e3547250c01442972e6c399; empty commit, no file diff
Local workflow validation	PASS	.agents/bin/validate; bin/conductor-exec bin/test-cpflow-github-flow bundle exec cpflow
Fresh-app auto guard	PASS	PR-open run 29659708782 completed successfully; fresh-app skip ran and setup/build/deploy/readiness were skipped
Effective deploy attempts	PASS	Exactly one +review-app-deploy command: comment
Fresh setup + image build	PASS	run 29659774335 completed fresh setup and image build
Rollout/readiness	FAIL	Active rollout began 2026-07-18T20:40:07Z; readiness was not observed in the single fixed 15-minute watch ending 2026-07-18T20:55:07Z; the run was cancelled and reached terminal cancelled
Browser behavioral smoke	BLOCKED	Not run because readiness was never observed; no pass was inferred or waived
Explicit teardown	PASS	Exactly one delete command: comment; run 29660657938 completed successfully
PR close	PASS	PR #791 closed unmerged
Close-trigger cleanup	PASS	run 29660706331 completed successfully

Current verification-head state: seven check runs completed successfully, including the configured review check; zero reviews; zero review threads; zero unresolved threads. The failed readiness observation is the external blocker, not a current-head code/check failure.

Disposition: leave #784 open as external-gate-failing. Root cause remains UNKNOWN; no protected endpoint, deployment log, credential, or environment detail is included here.

QA Evidence

• QA lane: ror17-fleet-c-tutorial-replay-3; branch jg-codex/verify-review-app-fresh-default-3; claim active during replay; final cleanup verified
• Scope checked: fresh-default PR-open guard, one explicit deploy, setup/build, fixed rollout/readiness watch, cleanup, and current-head checks/reviews/threads
• Tested at: PR Verify fresh default review-app deployment #791 head 415f9a4e3dfcbb024e3547250c01442972e6c399
• Automated checks: local RuboCop and cpflow GitHub-flow validation passed; linked GitHub Actions evidence above
• Manual checks: browser smoke blocked because readiness was not observed
• Findings: rollout/readiness blocked; root cause UNKNOWN; cleanup passed
• QA required: yes
• QA required rationale: deployed review-app behavior requires real rollout and endpoint evidence
• QA lane status: blocked
• Release-blocking status: blocked
• Process-gap disposition: park — this replay produced no public-safe evidence for a narrower mechanizable cause