Merge pull request #2 from serverscom/fix-delete-lb

olegy89 · web-flow · commit 416cf16709a6 · 2025-11-06T10:15:22.000+02:00
fix case when lb already deleted
diff --git a/internal/service/lb/manager.go b/internal/service/lb/manager.go
@@ -84,6 +84,10 @@ func (s *Manager) DeleteLB(ctx context.Context, labelSelector string) error {
 	if err != nil {
 		return utils.IgnoreNotFound(err)
 	}
+	if len(lbs) == 0 {
+		// consider as already deleted
+		return nil
+	}
 	if len(lbs) > 1 {
 		return fmt.Errorf("found more than one lb with same label")
 	}

Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,10 @@ func (s *Manager) DeleteLB(ctx context.Context, labelSelector string) error {`
`84`	`84`	`if err != nil {`
`85`	`85`	`return utils.IgnoreNotFound(err)`
`86`	`86`	`}`
	`87`	`+ if len(lbs) == 0 {`
	`88`	`+ // consider as already deleted`
	`89`	`+ return nil`
	`90`	`+ }`
`87`	`91`	`if len(lbs) > 1 {`
`88`	`92`	`return fmt.Errorf("found more than one lb with same label")`
`89`	`93`	`}`