Skip to content

Commit 2f4f946

Browse files
committed
Add type declarations
1 parent 34ba1a6 commit 2f4f946

6 files changed

Lines changed: 50 additions & 58 deletions

File tree

src/Rar4FileReader.php

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -30,20 +30,11 @@
3030
*/
3131
final class Rar4FileReader
3232
{
33-
/**
34-
* @var BinaryFileReader
35-
*/
36-
private $fileReader;
33+
private BinaryFileReader $fileReader;
3734

38-
/**
39-
* @var BitConverter
40-
*/
41-
private $bit;
35+
private BitConverter $bit;
4236

43-
/**
44-
* @var DateTimeConverter
45-
*/
46-
private $dateTime;
37+
private DateTimeConverter $dateTime;
4738

4839
/**
4940
* The constructor.

src/Struct/RarArchiveStruct.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,25 +10,25 @@ final class RarArchiveStruct
1010
/**
1111
* @var int The RAR version
1212
*/
13-
public $version = 4;
13+
public int $version = 4;
1414

1515
/**
1616
* @var string 7 bytes (0x52 0x61 0x72 0x21 0x1A 0x07 0x00)
1717
*/
18-
public $signature;
18+
public string $signature = '';
1919

2020
/**
21-
* @var RarMainHeadStruct
21+
* @var RarMainHeadStruct|null
2222
*/
23-
public $mainHead;
23+
public ?RarMainHeadStruct $mainHead = null;
2424

2525
/**
2626
* @var RarFileHeadStruct[]
2727
*/
28-
public $files = [];
28+
public array $files = [];
2929

3030
/**
3131
* @var RarVolumeHeaderStruct[] (Not supported)
3232
*/
33-
public $volumeHeaders = [];
33+
public array $volumeHeaders = [];
3434
}

src/Struct/RarExtTimeStruct.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,40 +12,40 @@ final class RarExtTimeStruct
1212
/**
1313
* @var int
1414
*/
15-
public $size;
15+
public int $size = 0;
1616

1717
/**
1818
* @var int
1919
*/
20-
public $type;
20+
public int $type = 0;
2121

2222
/**
2323
* @var int
2424
*/
25-
public $flags;
25+
public int $flags = 0;
2626

2727
/**
2828
* @var DateTimeImmutable|null
2929
*/
30-
public $mtime;
30+
public ?DateTimeImmutable $mtime = null;
3131

3232
/**
3333
* @var DateTimeImmutable|null
3434
*/
35-
public $ctime;
35+
public ?DateTimeImmutable $ctime = null;
3636

3737
/**
3838
* @var DateTimeImmutable|null
3939
*/
40-
public $atime;
40+
public ?DateTimeImmutable $atime = null;
4141

4242
/**
4343
* @var DateTimeImmutable|null
4444
*/
45-
public $arctime;
45+
public ?DateTimeImmutable $arctime = null;
4646

4747
/**
4848
* @var bool
4949
*/
50-
public $isUnixFormat;
50+
public bool $isUnixFormat = false;
5151
}

src/Struct/RarFileHeadStruct.php

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -12,86 +12,87 @@ final class RarFileHeadStruct
1212
/**
1313
* @var int 4 bytes
1414
*/
15-
public $packSize;
15+
public int $packSize = 0;
1616

1717
/**
1818
* @var int 4 bytes
1919
*/
20-
public $lowUnpackSize;
20+
public int $lowUnpackSize = 0;
2121

2222
/**
2323
* @var int 1 byte
2424
*/
25-
public $hostOS;
25+
public int $hostOS = 0;
2626

2727
/**
2828
* @var string 4 bytes
2929
*/
30-
public $fileCRC;
30+
public string $fileCRC = '';
3131

3232
/**
3333
* @var DateTimeImmutable 4 bytes
3434
*/
35-
public $fileTime;
35+
public DateTimeImmutable $fileTime;
3636

3737
/**
38-
* @var int 1 bytes
38+
* @var int 1 byte
3939
*/
40-
public $unpVer;
40+
public int $unpVer = 0;
4141

4242
/**
4343
* @var int 1 byte
44+
*
4445
* 0 = Store (no compression)
4546
* 1 = Fastest
4647
* 2 = Fast
4748
* 3 = Normal (corresponds to m3)
4849
* 4 = Good
4950
* 5 = Best
5051
*/
51-
public $method;
52+
public int $method = 0;
5253

5354
/**
5455
* @var int 2 bytes
5556
*/
56-
public $nameSize;
57+
public int $nameSize = 0;
5758

5859
/**
5960
* @var int 4 bytes
6061
*/
61-
public $fileAttr;
62+
public int $fileAttr = 0;
6263

6364
/**
6465
* @var int 4 bytes (only present if LHD_LARGE is set)
6566
*/
66-
public $highPackSize = 0;
67+
public int $highPackSize = 0;
6768

6869
/**
6970
* @var int 4 bytes (only present if LHD_LARGE is set)
7071
*/
71-
public $highUnpackSize = 0;
72+
public int $highUnpackSize = 0;
7273

7374
/**
74-
* @var string (NameSize) bytes
75+
* @var string Filename
7576
*/
76-
public $fileName = '';
77+
public string $fileName = '';
7778

7879
/**
7980
* @var string 8 bytes (only present if LHD_SALT is set)
8081
*/
81-
public $salt;
82+
public string $salt = '';
8283

8384
/**
84-
* @var RarExtTimeStruct Structure, See Description (only present if LHD_EXTTIME is set)
85+
* @var RarExtTimeStruct|null Structure, See Description (only present if LHD_EXTTIME is set)
8586
*/
86-
public $extTime;
87+
public ?RarExtTimeStruct $extTime = null;
8788

8889
/**
8990
* @var int
9091
*/
91-
public $unpackSize;
92+
public int $unpackSize = 0;
9293

9394
/**
9495
* @var bool
9596
*/
96-
public $isDirectory = false;
97+
public bool $isDirectory = false;
9798
}

src/Struct/RarMainHeadStruct.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ final class RarMainHeadStruct
1010
/**
1111
* @var int 2 bytes
1212
*/
13-
public $highPosAv;
13+
public int $highPosAv = 0;
1414

1515
/**
1616
* @var int 4 bytes
1717
*/
18-
public $posAv;
18+
public int $posAv = 0;
1919

2020
/**
2121
* @var int 1 byte Value 0x0200 (512). Indicates whether encryption is present in the archive volume.
2222
*/
23-
public $encryptVer;
23+
public int $encryptVer = 0;
2424
}

src/Struct/RarVolumeHeaderStruct.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,45 +10,45 @@ final class RarVolumeHeaderStruct
1010
/**
1111
* @var string 2 bytes
1212
*/
13-
public $crc = '';
13+
public string $crc = '';
1414

1515
/**
16-
* @var int 1 bytes
16+
* @var int 1 byte
1717
*/
18-
public $type = 0;
18+
public int $type = 0;
1919

2020
/**
2121
* @var int 2 byte
2222
*/
23-
public $flags = 0;
23+
public int $flags = 0;
2424

2525
/**
2626
* @var int 2 byte
2727
*/
28-
public $size = 0;
28+
public int $size = 0;
2929

3030
/**
3131
* @var int 4 byte
3232
*/
33-
public $addSize = 0;
33+
public int $addSize = 0;
3434

3535
/**
3636
* @var int
3737
*/
38-
public $blockSize = 0;
38+
public int $blockSize = 0;
3939

4040
/**
4141
* @var bool
4242
*/
43-
public $hasAdd;
43+
public bool $hasAdd = false;
4444

4545
/**
4646
* @var int
4747
*/
48-
public $headerSize;
48+
public int $headerSize = 0;
4949

5050
/**
5151
* @var int
5252
*/
53-
public $bodySize;
53+
public int $bodySize = 0;
5454
}

0 commit comments

Comments
 (0)