From 0e22d1834f16442b0c506a1ea27175631c007025 Mon Sep 17 00:00:00 2001
From: Evgeny Vereshchagin <evvers@ya.ru>
Date: Tue, 4 Aug 2026 17:46:35 +0000
Subject: [PATCH] pfroute: extract netmasks correctly on Darwin/NetBSD

by skipping the 2-byte sin_port field and switching to the network byte
order when RTA_NETMASKs are parsed.

Apart from the unit tests it was tested on NetBSD (32 and 64 bit)
and Darwin and also cross-checked with netstat and route.

It's a follow-up to 528626a02c7bfa404a85857375da5f9b3203ebaa.

AI-Assisted: no
---
 scapy/arch/bpf/pfroute.py |  4 ++--
 test/regression.uts       | 12 ++++++------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/scapy/arch/bpf/pfroute.py b/scapy/arch/bpf/pfroute.py
index dcb78457c63..b249490302d 100644
--- a/scapy/arch/bpf/pfroute.py
+++ b/scapy/arch/bpf/pfroute.py
@@ -1064,8 +1064,8 @@ def read_routes():
                 nm = msg.addrs[i]
                 if nm.sa_family == socket.AF_INET:
                     mask = atol(nm.sin_addr)
-                elif nm.sa_family in [0x00, 0xFF]:  # NetBSD
-                    mask = struct.unpack("<I", nm.sa_data[:4].rjust(4, b"\x00"))[0]
+                elif nm.sa_family in [0x00, 0xFF]:  # Darwin, NetBSD
+                    mask = struct.unpack("!I", nm.sa_data[2:].ljust(4, b"\x00"))[0]
                 else:
                     mask = int.from_bytes(nm.sa_data[:4], "big")
                 i += 1
diff --git a/test/regression.uts b/test/regression.uts
index 32a75bb4af6..58dbb5a8d8b 100644
--- a/test/regression.uts
+++ b/test/regression.uts
@@ -3227,9 +3227,9 @@ with BSDLoader(NETBSD=True, sysctldata=_PFROUTE_DATA, ifaces=_NETBSD_IFACES, AF_
 
 assert routes == [
     (0, 0, '172.23.192.1', 'hvn0', '172.23.207.191', 1),
-    (2130706432, 4294967040, '127.0.0.1', 'lo0', '127.0.0.1', 1),
+    (2130706432, 4278190080, '127.0.0.1', 'lo0', '127.0.0.1', 1),
     (2130706433, 4294967295, '0.0.0.0', 'lo0', '127.0.0.1', 1),
-    (2887237632, 4294967295, '0.0.0.0', 'hvn0', '172.23.207.191', 1),
+    (2887237632, 4294963200, '0.0.0.0', 'hvn0', '172.23.207.191', 1),
     (2887241663, 4294967295, '0.0.0.0', 'lo0', '172.23.207.191', 1),
     (2887237633, 4294967295, '0.0.0.0', 'hvn0', '', 1),
     (3758096384, 4026531840, '0.0.0.0', 'hvn0', '172.23.207.191', 250),
@@ -3292,16 +3292,16 @@ with BSDLoader(DARWIN=True, sysctldata=_PFROUTE_DATA, ifaces=_DARWIN_IFACES, AF_
 
 assert routes == [
     (0, 0, '10.0.2.2', 'en0', '10.0.2.15', 1),
-    (167772672, 4294967295, '0.0.0.0', 'en0', '10.0.2.15', 1),
+    (167772672, 4294967040, '0.0.0.0', 'en0', '10.0.2.15', 1),
     (167772674, 4294967295, '0.0.0.0', 'en0', '10.0.2.15', 1),
     (167772674, 4294967295, '0.0.0.0', 'en0', '10.0.2.15', 1),
     (167772675, 4294967295, '0.0.0.0', 'en0', '10.0.2.15', 1),
     (167772687, 4294967295, '0.0.0.0', 'en0', '10.0.2.15', 1),
     (167772927, 4294967295, '0.0.0.0', 'en0', '10.0.2.15', 1),
-    (2130706432, 4294967040, '127.0.0.1', 'lo0', '127.0.0.1', 1),
+    (2130706432, 4278190080, '127.0.0.1', 'lo0', '127.0.0.1', 1),
     (2130706433, 4294967295, '127.0.0.1', 'lo0', '127.0.0.1', 1),
-    (2851995648, 4294967295, '0.0.0.0', 'en0', '10.0.2.15', 1),
-    (3758096384, 4043308800, '0.0.0.0', 'en0', '10.0.2.15', 1),
+    (2851995648, 4294901760, '0.0.0.0', 'en0', '10.0.2.15', 1),
+    (3758096384, 4026531840, '0.0.0.0', 'en0', '10.0.2.15', 1),
     (3758096635, 4294967295, '0.0.0.0', 'en0', '10.0.2.15', 1),
     (4294967295, 4294967295, '0.0.0.0', 'en0', '10.0.2.15', 1)
 ]