Since v10 some lines are ignored

[mvorisek]

Q	A
php-code-coverage version	10.1.9
PHP version	8.2.13
Driver	Xdebug
PCOV version (if used)	n/a
Xdebug version (if used)	3.2.2
Installation Method	Composer
Usage Method	PHPUnit / other
PHPUnit version (if used)	10.4.2

source: https://github.com/atk4/ui/blob/5.0.0/tests/JsTest.php#L38

Started to happen when PHPUnit was upgraded to v10 and php-code-coverage from v9.2.29 to v10.1.9 on the same PHP version and xdebug version. See the screenshot, l38 went from uncovered to ignored.

[sebastianbergmann]

Thank you for your report.

Please provide a minimal, self-contained, reproducing test case that shows the problem you are reporting.

Without such a minimal, self-contained, reproducing test case I will not be able to investigate this issue.

[mvorisek]

The source is linked, ie. lines l37 - l39, it seems the issue is when the if expression is CTE (compile time evalueable).

[sebastianbergmann]

@dvdoug @Slamdunk Do you have an idea what to do here? Thanks!

[Slamdunk]

I see that the source is linked, but it's very cumbersome to reproduce locally, I didn't manage to achieve the result.

@mvorisek can you provide the least amount of files that reproduce the issue in a separate repo please?

[mvorisek]

I belive the reason you was not able to reproduce it is you did not run phpunit /w opcache. I belive so as PHP_INT_SIZE === 4 is always false (/w 64-bit php binary) and the condition body is eliminated as dead code only when opcache is enabled.

Please run phpunit /w opcache like: php -d opcache.enable_cli=1 vendor/bin/phpunit ....

The following code should be then enough to reproduce:

    public function testNumbers(): void
    {
        if (\PHP_INT_SIZE === 4) {
            self::markTestIncomplete('Test is not supported on 32bit php');
        }

        $v = 'a';
    }

[sebastianbergmann]

I did not realize that this is related to bytecode optimization before.

I would argue that code coverage data should not be collected/processed when OpCache is active. We should probably error out when code coverage reporting is requested and OpCache is active.

[mvorisek]

Thankfully, opcache is generally supported and we need it for other testing (memory leaks testing). I belive @Slamdunk can fix this as in v9 it was working.

[Slamdunk]

@mvorisek the repo doesn't provide all the necessary requirements for the test to run locally, I get many unrelated errors like:

1) Atk4\Ui\Tests\DemosTest::testDemosStatusAndHtmlResponse with data set #0 ('index.php')                                                                                                                                                       
Atk4\Ui\Exception: Database error: Sqlite database does not exist, create it first                                                                                                                                                              
                                                                                                                                                                                                                                                
/home/tessarotto/repos/ui/demos/init-app.php:98                                                                                                                                                                                                 
/home/tessarotto/repos/ui/tests/DemosTest.php:75                                                                                                                                                                                                
/home/tessarotto/repos/ui/vendor/bin/phpunit:122                                                                                                                                                                                                
                                                                                                                                                                                                                                                
2) Atk4\Ui\Tests\DemosTest::testDemosStatusAndHtmlResponse with data set #1 ('_unit-test/callback-nested.php')                                                                                                                                  
Error: Attempt to assign property "runCalled" on string                                                                                                                                                                                         
                                                                                                                                                                                                                                                
/home/tessarotto/repos/ui/tests/DemosTest.php:85                                                                                                                                                                                                
/home/tessarotto/repos/ui/vendor/bin/phpunit:122                                                                                                                                                                                                

Can you provide some Docker based reproducible environment please?

[mvorisek]

#1022 (comment) this few lines should be enough - no other repo/files should be needed

[Slamdunk]

I honestly have no idea what that's supposed to mean, but in the previous run I get this:

🤷

[mvorisek]

Please confim me you get l38 uncovered - ie. not uncounted/unmeasured - with v10 and opcache enabled, if so, I will provide a repro.

[Slamdunk]

I get L38 counted and uncovered

[sebastianbergmann]

@mvorisek Can you share your OpCache settings, please? Thanks!

[mvorisek]

@Slamdunk thank you - one more check - l37 must be of course covered (in #1022 (comment) screenshot), ie. please run the test and confirm the previous.

[Slamdunk]

L37 is uncovered because I am not able to run the test suite locally, so...