Skip to content

Commit caf2f7a

Browse files
committed
Fix flaky test_multi_timer_validation on Windows CI
Increase timer tolerance from 150ms to 500ms to account for CI environments under heavy load, especially Windows during wheel building where timing can be significantly less precise.
1 parent a7f174c commit caf2f7a

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

tests/unit/io/utils.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,10 @@ def submit_and_wait_for_completion(unit_test, create_timer, start, end, incremen
128128
time.sleep(.1)
129129

130130
# ensure they are all called back in a timely fashion
131+
# Use a generous tolerance (500ms) to account for CI environments under heavy load,
132+
# especially Windows during wheel building where timing can be significantly less precise
131133
for callback in completed_callbacks:
132-
assert callback.expected_wait == pytest.approx(callback.get_wait_time(), abs=.15)
134+
assert callback.expected_wait == pytest.approx(callback.get_wait_time(), abs=.5)
133135

134136

135137
def noop_if_monkey_patched(f):

0 commit comments

Comments
 (0)