Skip to content

Commit 85b5a1f

Browse files
committed
🐛 Make tip of the week snippet optional
1 parent 79c3391 commit 85b5a1f

File tree

5 files changed

+9
-22
lines changed

5 files changed

+9
-22
lines changed

interfaces/api.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export interface TipOfTheWeek {
2828
published_at: string;
2929
created_at: string;
3030
updated_at: string;
31-
codeSnippet: CodeSnippet;
31+
codeSnippet?: CodeSnippet;
3232
}
3333
export interface CodeSnippet {
3434
id: number;

interfaces/tipOfTheWeek.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import CodeSnippet from './codeSnippet';
22

33
export default interface TipOfTheWeek {
4-
snippet: CodeSnippet;
4+
snippet?: CodeSnippet;
55
desc: string;
66
sourceName: string;
77
sourceURL: string;

lib/issues.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ export function mapToIssue(issue: IssueAPIResponse): Issue {
9292
const tipOfTheWeek =
9393
issue.tipOfTheWeek !== null
9494
? {
95-
snippet: issue.tipOfTheWeek.codeSnippet,
95+
snippet: issue.tipOfTheWeek.codeSnippet ?? null,
9696
desc: issue.tipOfTheWeek.description,
9797
sourceName: issue.tipOfTheWeek.sourceName,
9898
sourceURL: issue.tipOfTheWeek.sourceURL,

pages/issues/[id].tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export default function IssueComponent({ issueData }: { issueData: Issue }): JSX
7676
<Text type="base" additionalStyles="py-4 relative z-10">
7777
<Markdown>{issueData.tipOfTheWeek.desc}</Markdown>
7878
</Text>
79-
<CodeSnippet snippet={issueData.tipOfTheWeek.snippet} />
79+
{issueData.tipOfTheWeek.snippet ? <CodeSnippet snippet={issueData.tipOfTheWeek.snippet} /> : null}
8080
</IssueItem>
8181
) : null}
8282
{issueData?.articles !== null ? (

scripts/issueEmailGenerator.js

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -99,10 +99,14 @@ ${currentIssue.description}
9999
# Tip of the day
100100
${currentIssue.tipOfTheWeek.description}
101101
102+
${
103+
currentIssue.tipOfTheWeek.codeSnippet &&
104+
`
102105
\`\`\`${currentIssue.tipOfTheWeek.codeSnippet.language}
103106
${currentIssue.tipOfTheWeek.codeSnippet.code}
104107
\`\`\`
105-
108+
`
109+
}
106110
___
107111
108112
# Articles
@@ -137,23 +141,6 @@ ${tool.description}
137141
138142
___
139143
140-
# Dev of the Week
141-
142-
<img alt="${currentIssue.devOfTheWeek.name}" src="${getAssetURL(
143-
currentIssue.id,
144-
currentIssue.devOfTheWeek.profileImg
145-
)}" style="width:200px;"/>
146-
147-
## ${currentIssue.devOfTheWeek.name}
148-
${currentIssue.devOfTheWeek.bio}
149-
150-
${Object.keys(currentIssue.devOfTheWeek)
151-
.filter(key => PROFILE_KEYS.includes(key) && currentIssue.devOfTheWeek[key] !== null)
152-
.map(profile => `[${PROFILE_TYPES[profile]}](${currentIssue.devOfTheWeek[profile]})`)
153-
.join(' | ')}
154-
155-
___
156-
157144
# Tech Talks
158145
159146
[**${currentIssue.talks[0].title}**](${currentIssue.talks[0].url})

0 commit comments

Comments
 (0)