Skip to content

Commit ec2e7c1

Browse files
committed
Stop using deprecated ConversionUtils methods
There is now the Types utility class instead.
1 parent 38b1e3a commit ec2e7c1

File tree

12 files changed

+26
-29
lines changed

12 files changed

+26
-29
lines changed

src/main/java/org/scijava/command/CommandModuleItem.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ private T tValue(final String value) {
253253

254254
private <D> D tValue(final String value, final Class<D> type) {
255255
if (value == null || value.isEmpty()) return null;
256-
final Class<D> saneType = ConversionUtils.getNonprimitiveType(type);
256+
final Class<D> saneType = Types.box(type);
257257
return ConversionUtils.convert(value, saneType);
258258
}
259259

src/main/java/org/scijava/convert/AbstractConverter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,8 @@ public boolean canConvert(final Object src, final Class<?> dest) {
109109
@Override
110110
public boolean canConvert(final Class<?> src, final Class<?> dest) {
111111
if (src == null) return false;
112-
final Class<?> saneSrc = ConversionUtils.getNonprimitiveType(src);
113-
final Class<?> saneDest = ConversionUtils.getNonprimitiveType(dest);
112+
final Class<?> saneSrc = Types.box(src);
113+
final Class<?> saneDest = Types.box(dest);
114114
return ConversionUtils.canCast(saneSrc, getInputType()) &&
115115
ConversionUtils.canCast(getOutputType(), saneDest);
116116
}

src/main/java/org/scijava/convert/DefaultConverter.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public Object convert(final Object src, final Type dest) {
9797
@Override
9898
public <T> T convert(final Object src, final Class<T> dest) {
9999
// ensure type is well-behaved, rather than a primitive type
100-
final Class<T> saneDest = ConversionUtils.getNonprimitiveType(dest);
100+
final Class<T> saneDest = Types.box(dest);
101101

102102
// Handle array types
103103
if (isArray(dest)) {
@@ -153,7 +153,7 @@ public <T> T convert(final Object src, final Class<T> dest) {
153153
final String s = (String) src;
154154
if (s.isEmpty()) {
155155
// return null for empty strings
156-
return ConversionUtils.getNullValue(dest);
156+
return Types.nullValue(dest);
157157
}
158158

159159
// use first character when converting to Character
@@ -310,11 +310,10 @@ public boolean canConvert(final Class<?> src, final Type dest) {
310310
@Deprecated
311311
public boolean canConvert(final Class<?> src, final Class<?> dest) {
312312
// ensure type is well-behaved, rather than a primitive type
313-
final Class<?> saneDest = ConversionUtils.getNonprimitiveType(dest);
313+
final Class<?> saneDest = Types.box(dest);
314314

315315
// OK for numerical conversions
316-
if (ConversionUtils.canCast(ConversionUtils.getNonprimitiveType(src),
317-
Number.class) &&
316+
if (ConversionUtils.canCast(Types.box(src), Number.class) &&
318317
(ClassUtils.isByte(dest) || ClassUtils.isDouble(dest) ||
319318
ClassUtils.isFloat(dest) || ClassUtils.isInteger(dest) ||
320319
ClassUtils.isLong(dest) || ClassUtils.isShort(dest)))

src/main/java/org/scijava/convert/NullConverter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
import org.scijava.Priority;
3838
import org.scijava.plugin.Plugin;
39-
import org.scijava.util.ConversionUtils;
39+
import org.scijava.util.Types;
4040

4141
/**
4242
* {@link Converter} implementation for handling {@code null} values. Performs
@@ -83,7 +83,7 @@ public boolean canConvert(final Class<?> src, final Class<?> dest) {
8383
@Override
8484
public <T> T convert(final Object src, final Class<T> dest) {
8585
if (dest == null) return null;
86-
if (src == null) return ConversionUtils.getNullValue(dest);
86+
if (src == null) return Types.nullValue(dest);
8787

8888
throw new IllegalArgumentException("Attempting non-null conversion: " +
8989
src + " > " + dest + " using NullConverter.");

src/main/java/org/scijava/convert/NumberToNumberConverter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232

3333
package org.scijava.convert;
3434

35-
import org.scijava.util.ConversionUtils;
35+
import org.scijava.util.Types;
3636

3737
/**
3838
* Converts numbers to numbers, and throws IllegalArgumentException for null or
@@ -53,7 +53,7 @@ public <T> T convert(final Object src, final Class<T> dest) {
5353
getInputType().getSimpleName() + ", but got " +
5454
src.getClass().getSimpleName());
5555
}
56-
if (ConversionUtils.getNonprimitiveType(dest) != getOutputType()) {
56+
if (Types.box(dest) != getOutputType()) {
5757
throw new IllegalArgumentException(
5858
"Expected output class of " + getOutputType().getSimpleName() +
5959
", but got " + dest.getSimpleName());

src/main/java/org/scijava/module/AbstractModuleInfo.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040

4141
import org.scijava.AbstractUIDetails;
4242
import org.scijava.util.ConversionUtils;
43+
import org.scijava.util.Types;
4344

4445
/**
4546
* Abstract superclass of {@link ModuleInfo} implementation.
@@ -168,7 +169,7 @@ private <T> ModuleItem<T> castItem(final ModuleItem<?> item,
168169
{
169170
final Class<?> itemType = item.getType();
170171
// if (!type.isAssignableFrom(itemType)) {
171-
final Class<?> saneItemType = ConversionUtils.getNonprimitiveType(itemType);
172+
final Class<?> saneItemType = Types.box(itemType);
172173
if (!ConversionUtils.canCast(type, saneItemType)) {
173174
throw new IllegalArgumentException("Type " + type.getName() +
174175
" is incompatible with item of type " + itemType.getName());

src/main/java/org/scijava/module/process/DefaultValuePreprocessor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
import org.scijava.module.ModuleService;
4141
import org.scijava.plugin.Parameter;
4242
import org.scijava.plugin.Plugin;
43-
import org.scijava.util.ConversionUtils;
43+
import org.scijava.util.Types;
4444

4545
/**
4646
* A preprocessor plugin that populates default parameter values.
@@ -74,7 +74,7 @@ private <T> void assignDefaultValue(final Module module,
7474
final ModuleItem<T> item)
7575
{
7676
if (module.isInputResolved(item.getName())) return;
77-
final T nullValue = ConversionUtils.getNullValue(item.getType());
77+
final T nullValue = Types.nullValue(item.getType());
7878
if (!Objects.equals(item.getValue(module), nullValue)) return;
7979
final T defaultValue = moduleService.getDefaultValue(item);
8080
if (defaultValue == null) return;

src/main/java/org/scijava/module/process/LoadInputsPreprocessor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
import org.scijava.module.ModuleService;
3939
import org.scijava.plugin.Parameter;
4040
import org.scijava.plugin.Plugin;
41-
import org.scijava.util.ConversionUtils;
41+
import org.scijava.util.Types;
4242
import org.scijava.widget.InputHarvester;
4343

4444
/**
@@ -93,7 +93,7 @@ private <T> T getBestValue(final Object prefValue,
9393
if (defaultValue != null) {
9494
return conversionService.convert(defaultValue, type);
9595
}
96-
return ConversionUtils.getNullValue(type);
96+
return Types.nullValue(type);
9797
}
9898

9999
}

src/main/java/org/scijava/util/ClassUtils.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -683,16 +683,16 @@ public static boolean canCast(final Object obj, final Class<?> type) {
683683
return ConversionUtils.canCast(obj, type);
684684
}
685685

686-
/** @deprecated use {@link ConversionUtils#getNonprimitiveType(Class)} */
686+
/** @deprecated use {@link Types#box(Class)} */
687687
@Deprecated
688688
public static <T> Class<T> getNonprimitiveType(final Class<T> type) {
689-
return ConversionUtils.getNonprimitiveType(type);
689+
return Types.box(type);
690690
}
691691

692-
/** @deprecated use {@link ConversionUtils#getNullValue(Class)} */
692+
/** @deprecated use {@link Types#nullValue(Class)} */
693693
@Deprecated
694694
public static <T> T getNullValue(final Class<T> type) {
695-
return ConversionUtils.getNullValue(type);
695+
return Types.nullValue(type);
696696
}
697697

698698
/**

src/main/java/org/scijava/util/Types.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,6 @@
5959
import java.util.Objects;
6060
import java.util.Set;
6161

62-
import org.scijava.util.ConversionUtils;
63-
6462
/**
6563
* Utility class for working with generic types, fields and methods.
6664
* <p>
@@ -1647,7 +1645,7 @@ private static Map<TypeVariable<?>, Type> getTypeArguments(Class<?> cls,
16471645
}
16481646

16491647
// work with wrapper the wrapper class instead of the primitive
1650-
cls = ConversionUtils.getNonprimitiveType(cls);
1648+
cls = Types.box(cls);
16511649
}
16521650

16531651
// create a copy of the incoming map, or an empty one if it's null

0 commit comments

Comments
 (0)