Skip to content

Commit 4bdb6dc

Browse files
committed
pombast: update n5-related test workarounds
Some tests are fixed, others are now broken... good times!
1 parent d0e609e commit 4bdb6dc

1 file changed

Lines changed: 34 additions & 23 deletions

File tree

pombast.toml

Lines changed: 34 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -145,17 +145,6 @@ excludes = [
145145
skip-tests = [
146146
# Error while checking the CLIJ2 installation: null
147147
"sc.fiji:labkit-pixel-classification",
148-
149-
# TEMP: Until n5-aws-sw test failures are resolved; see also:
150-
# https://github.com/scijava/pom-scijava/pull/304#issuecomment-4684120110
151-
# Errors are of the form:
152-
# Unable to execute HTTP request: Connect to localhost:9000
153-
# [localhost/127.0.0.1] failed: Connection refused (Connection refused)
154-
"org.janelia.saalfeldlab:n5-aws-s3",
155-
156-
# TEMP: Until n5-universe test failures are resolved; see also:
157-
# https://github.com/scijava/pom-scijava/pull/304#issuecomment-4684417746
158-
"org.janelia.saalfeldlab:n5-universe",
159148
]
160149

161150
[remove-tests]
@@ -166,18 +155,40 @@ skip-tests = [
166155

167156
# In org.janelia.saalfeldlab.n5.metadata.ome.ngff.v04.WriteAxesTests.testXYT:
168157
# java.util.NoSuchElementException: No value present
169-
"org.janelia.saalfeldlab:n5-ij" = ["org.janelia.saalfeldlab.n5.metadata.ome.ngff.v04.WriteAxesTests"]
170-
171-
# Avoid notNull assertion error at
172-
# org.janelia.saalfeldlab.n5.universe.metadata.MetadataTests.testEmptyBase(MetadataTests.java:346)
173-
"org.janelia.saalfeldlab:n5-universe" = ["org.janelia.saalfeldlab.n5.universe.metadata.MetadataTests"]
174-
175-
# In org.janelia.saalfeldlab.n5.zarr.ZarrCachedFSTest.cacheBehaviorTest:
176-
# arrays first differed at element [0]; expected:<[a]> but was:<[c]>
177-
"org.janelia.saalfeldlab:n5-zarr" = ["org.janelia.saalfeldlab.n5.zarr.ZarrCachedFSTest"]
178-
# Note: The above test is fixed with saalfeldlab/n5-zarr@e7edcec3,
179-
# but the fix is only available in n5-zarr 2.0.0-alpha-1, and we
180-
# do not want to update the SciJava BOM to the alpha version.
158+
#"org.janelia.saalfeldlab:n5-ij" = ["org.janelia.saalfeldlab.n5.metadata.ome.ngff.v04.WriteAxesTests"]
159+
160+
# In org.janelia.saalfeldlab.n5.s3.AmazonS3UtilsTest.testUriParsing:
161+
# SdkClient Unable to load region from any of the providers in the chain
162+
# software.amazon.awssdk.regions.providers.DefaultAwsRegionProviderChain@427475a2:
163+
# [software.amazon.awssdk.regions.providers.SystemSettingsRegionProvider@768b79db:
164+
# Unable to load region from system settings. Region must be specified either
165+
# via environment variable (AWS_REGION) or system property (aws.region).,
166+
# software.amazon.awssdk.regions.providers.AwsProfileRegionProvider@3b59d246:
167+
# No region provided in profile: default,
168+
# software.amazon.awssdk.regions.providers.InstanceProfileRegionProvider@11b0cf30:
169+
# Unable to contact EC2 metadata service.]
170+
"org.janelia.saalfeldlab:n5-aws-s3" = ["org.janelia.saalfeldlab.n5.s3.AmazonS3UtilsTest"]
171+
172+
# Skip n5-universe'slow tests.
173+
"org.janelia.saalfeldlab:n5-universe" = [
174+
"org.janelia.saalfeldlab.n5.universe.storage.zarr.ZarrStorageTests", # Time elapsed: 1753 s
175+
"org.janelia.saalfeldlab.n5.universe.storage.zarr.zarr2.Zarr2HttpFactoryTest", # Time elapsed: 947.2 s
176+
"org.janelia.saalfeldlab.n5.universe.storage.n5.N5StorageTests", # Time elapsed: 843.5 s
177+
"org.janelia.saalfeldlab.n5.universe.storage.n5.N5HttpFactoryTest", # Time elapsed: 832.3 s
178+
"org.janelia.saalfeldlab.n5.universe.storage.zarr.zarr3.Zarr3HttpFactoryTest", # Time elapsed: 785.5 s
179+
180+
# And these are all dependent on the above removed classes. :-(
181+
"org.janelia.saalfeldlab.n5.universe.BackendStorageFormatTests",
182+
"org.janelia.saalfeldlab.n5.universe.storage.n5.N5AmazonS3FactoryTest",
183+
"org.janelia.saalfeldlab.n5.universe.storage.n5.N5FileSystemTest",
184+
"org.janelia.saalfeldlab.n5.universe.storage.n5.N5GoogleCloudFactoryTest",
185+
"org.janelia.saalfeldlab.n5.universe.storage.zarr.zarr2.Zarr2AmazonS3FactoryTest",
186+
"org.janelia.saalfeldlab.n5.universe.storage.zarr.zarr2.Zarr2FileSystemTest",
187+
"org.janelia.saalfeldlab.n5.universe.storage.zarr.zarr2.Zarr2GoogleCloudFactoryTest",
188+
"org.janelia.saalfeldlab.n5.universe.storage.zarr.zarr3.Zarr3AmazonS3FactoryTest",
189+
"org.janelia.saalfeldlab.n5.universe.storage.zarr.zarr3.Zarr3FileSystemTest",
190+
"org.janelia.saalfeldlab.n5.universe.storage.zarr.zarr3.Zarr3GoogleCloudFactoryTest",
191+
]
181192

182193
"sc.fiji:labkit-ui" = [
183194
"sc.fiji.labkit.ui.GarbageCollectionTest", # Too slow (7 s)

0 commit comments

Comments
 (0)