Remove scipp dependency, inline Status class

- Add science/synapse/status.h with StatusCode enum and Status class
- Update all includes from science/scipp/status.h to local status.h
- Add missing #include <optional> and <chrono> to device.h
- Remove science-scipp from vcpkg.json dependencies

Author: maxhodak

include/science/synapse/config.h

@@ -5,7 +5,7 @@
 #include <vector>
 #include <utility>
 
-#include "science/scipp/status.h"
+#include "science/synapse/status.h"
 #include "science/synapse/api/synapse.pb.h"
 #include "science/synapse/node.h"
 

include/science/synapse/device.h

@@ -1,7 +1,9 @@
 #pragma once
 
+#include <chrono>
 #include <future>
 #include <memory>
+#include <optional>
 #include <string>
 #include <vector>
 

include/science/synapse/node.h

@@ -5,7 +5,7 @@
 #include <vector>
 #include <utility>
 
-#include "science/scipp/status.h"
+#include "science/synapse/status.h"
 #include "science/synapse/api/node.pb.h"
 
 namespace synapse {

include/science/synapse/signal_config.h

@@ -4,7 +4,7 @@
 #include <vector>
 #include "science/synapse/api/nodes/signal_config.pb.h"
 #include "science/synapse/channel.h"
-#include "science/scipp/status.h"
+#include "science/synapse/status.h"
 
 namespace synapse {
 

include/science/synapse/status.h

@@ -0,0 +1,50 @@
+#pragma once
+
+#include <string>
+#include <utility>
+
+namespace science {
+
+/**
+ * Library-agnostic status codes for return values.
+ * These codes are 1:1 with abseil / gRPC status codes.
+ */
+enum class StatusCode : int {
+  kOk = 0,
+  kCancelled = 1,
+  kUnknown = 2,
+  kInvalidArgument = 3,
+  kDeadlineExceeded = 4,
+  kNotFound = 5,
+  kAlreadyExists = 6,
+  kPermissionDenied = 7,
+  kResourceExhausted = 8,
+  kFailedPrecondition = 9,
+  kAborted = 10,
+  kOutOfRange = 11,
+  kUnimplemented = 12,
+  kInternal = 13,
+  kUnavailable = 14,
+  kDataLoss = 15,
+  kUnauthenticated = 16,
+};
+
+/**
+ * Status, containing a status code and an optional message.
+ */
+class Status {
+ public:
+  Status() = default;
+  explicit Status(StatusCode code) : code_(code) {}
+  Status(StatusCode code, std::string message) : code_(code), message_(std::move(message)) {}
+
+  [[nodiscard]] bool ok() const { return code_ == StatusCode::kOk; }
+  [[nodiscard]] StatusCode code() const { return code_; }
+  [[nodiscard]] std::string message() const { return message_; }
+
+ private:
+  StatusCode code_{StatusCode::kOk};
+  std::string message_{};
+};
+
+}  // namespace science

include/science/synapse/tap.h

@@ -6,7 +6,7 @@
 #include <optional>
 
 #include <zmq.hpp>
-#include "science/scipp/status.h"
+#include "science/synapse/status.h"
 #include "science/synapse/api/tap.pb.h"
 
 namespace synapse {

include/science/synapse/util/discover.h

@@ -4,7 +4,7 @@
 #include <string>
 #include <vector>
 
-#include "science/scipp/status.h"
+#include "science/synapse/status.h"
 #include "science/synapse/device_advertisement.h"
 
 namespace synapse {

test/test_discover.cpp

@@ -1,6 +1,6 @@
 
 #include <gtest/gtest.h>
-#include <science/scipp/status.h>
+#include <science/synapse/status.h>
 #include <science/synapse/util/discover.h>
 
 using synapse::DeviceAdvertisement;

vcpkg.json

@@ -4,7 +4,7 @@
   "version": "0.1.0",
   "supports": "arm64 | x64 | linux | osx",
   "default-features": ["examples", "tests"],
-  "dependencies": ["grpc", "protobuf", "cppzmq", "science-scipp"],
+  "dependencies": ["grpc", "protobuf", "cppzmq"],
   "vcpkg-configuration": {
     "overlay-ports": ["./external/sciencecorp/vcpkg/ports"]
   },