- fix: Resolve stack overflow issue in menu pagination logic

- feat: Add DisableOption support for AddItem method

Author: schwarper

API/Class/BaseMenu.cs

@@ -50,10 +50,11 @@ public abstract class BaseMenu(string title, BasePlugin plugin) : IMenu
     /// </summary>
     /// <param name="display">The text to display for the item.</param>
     /// <param name="onSelect">The action to perform when the item is selected.</param>
+    /// <param name="disableOption">The disable option for the item.</param>
     /// <returns>The created item option.</returns>
-    public virtual ItemOption AddItem(string display, Action<CCSPlayerController, ItemOption> onSelect)
+    public virtual ItemOption AddItem(string display, Action<CCSPlayerController, ItemOption> onSelect, DisableOption disableOption = DisableOption.None)
     {
-        ItemOption option = new(display, DisableOption.None, onSelect);
+        ItemOption option = new(display, disableOption, onSelect);
         ItemOptions.Add(option);
         return option;
     }
@@ -272,18 +273,12 @@ internal void DeregisterOnKeyPress()
         if (Menu is WasdMenu || (Menu is ScreenMenu screenMenu && screenMenu.MenuType == MenuType.Scrollable))
             return;
 
-        foreach (KeyValuePair<string, CommandCallback> kvp in _keyCommands)
-        {
-            if (_keyCommands.ContainsKey(kvp.Key))
-            {
-                Menu.Plugin.RemoveCommand(kvp.Key, kvp.Value);
-            }
-        }
+        foreach (var kvp in _keyCommands)
+            Menu.Plugin.RemoveCommand(kvp.Key, kvp.Value);
 
         _keyCommands.Clear();
     }
 
-
     internal void RegisterPlayerDisconnectEvent()
     {
         Menu.Plugin.RegisterEventHandler<EventPlayerDisconnect>(OnPlayerDisconnect);

API/Interface/IMenu.cs

@@ -44,8 +44,9 @@ public interface IMenu
     /// </summary>
     /// <param name="display">The text to display for the item.</param>
     /// <param name="onSelect">The action to perform when the item is selected.</param>
+    /// <param name="disableOption">The disable option for the item.</param>
     /// <returns>The created item option.</returns>
-    ItemOption AddItem(string display, Action<CCSPlayerController, ItemOption> onSelect);
+    ItemOption AddItem(string display, Action<CCSPlayerController, ItemOption> onSelect, DisableOption disableOption = DisableOption.None);
 
     /// <summary>
     /// Adds an item to the menu with a specified display text and disable option.

API/Menu/CenterHtmlMenu.cs

@@ -97,7 +97,7 @@ public class CenterHtmlMenuInstance : BaseMenuInstance
     /// <summary>
     /// Gets a value indicating whether the menu has a next button.
     /// </summary>
-    protected override bool HasNextButton => Menu.ItemOptions.Count > MenuItemsPerPage + 1 && CurrentOffset + NumPerPage < Menu.ItemOptions.Count;
+    protected override bool HasNextButton => Menu.ItemOptions.Count > NumPerPage + 1 && CurrentOffset + NumPerPage < Menu.ItemOptions.Count;
 
     /// <summary>
     /// Initializes a new instance of the <see cref="CenterHtmlMenuInstance"/> class.