Skip to content

Commit 1ab3414

Browse files
replace world parameters with env variables
Issue: ZENKO-5182
1 parent 61ce181 commit 1ab3414

15 files changed

Lines changed: 100 additions & 97 deletions

File tree

.github/scripts/end2end/common.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ get_token() {
22
curl -k -H "Host: keycloak.zenko.local" \
33
-d "client_id=${OIDC_CLIENT_ID}" \
44
-d "username=${OIDC_USERNAME}" \
5-
-d "password=${OIDC_PASSWORD}" \
5+
-d "password=${KEYCLOAK_TEST_PASSWORD}" \
66
-d "grant_type=password" \
77
-d "scope=openid" \
88
https://localhost/auth/realms/${OIDC_REALM}/protocol/openid-connect/token | \

.github/scripts/end2end/keycloak-helper.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ case $COMMAND in
3939
${KEYCLOAK_EXEC} /opt/jboss/keycloak/bin/kcadm.sh set-password \
4040
-r ${OIDC_REALM} \
4141
--username ${OIDC_USERNAME} \
42-
--new-password ${OIDC_PASSWORD}
42+
--new-password ${KEYCLOAK_TEST_PASSWORD}
4343

4444
# attach StorageManager role to user
4545
${KEYCLOAK_EXEC} /opt/jboss/keycloak/bin/kcadm.sh add-roles \

.github/scripts/end2end/load-config.sh

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -37,18 +37,16 @@ load_common() {
3737
ENV_VARS=()
3838

3939
# From end2end.yaml
40-
ENV_VARS+=("SUBDOMAIN=$(get_env_var SUBDOMAIN)")
4140
ENV_VARS+=("KEYCLOAK_TEST_REALM_NAME=$(get_env_var OIDC_REALM)")
4241
ENV_VARS+=("KEYCLOAK_TEST_CLIENT_ID=$(get_env_var OIDC_CLIENT_ID)")
4342
ENV_VARS+=("KEYCLOAK_TEST_USER=$(get_env_var OIDC_USERNAME)")
44-
ENV_VARS+=("KEYCLOAK_TEST_PASSWORD=$(get_env_var OIDC_PASSWORD)")
43+
ENV_VARS+=("KEYCLOAK_TEST_PASSWORD=$(get_env_var KEYCLOAK_TEST_PASSWORD)")
4544
ENV_VARS+=("KEYCLOAK_TEST_HOST=$(get_env_var OIDC_HOST)")
4645
ENV_VARS+=("KEYCLOAK_TEST_PORT=80")
4746
ENV_VARS+=("KEYCLOAK_TEST_GRANT_TYPE=password")
4847
ENV_VARS+=("AZURE_ACCOUNT_NAME=$(get_env_var AZURE_ACCOUNT_NAME)")
4948
ENV_VARS+=("AZURE_SECRET_KEY=$(get_env_var AZURE_SECRET_KEY)")
50-
ENV_VARS+=("CLOUDSERVER_ENDPOINT=http://end2end-connector-s3api.default.svc.cluster.local:80")
51-
ENV_VARS+=("VAULT_ENDPOINT=http://end2end-management-vault-iam-admin-api:80")
49+
ENV_VARS+=("AZURE_BACKEND_ENDPOINT=$(get_env_var AZURE_BACKEND_ENDPOINT)")
5250

5351
# From k8s: Zenko account credentials
5452
ENV_VARS+=("ZENKO_ACCESS_KEY=$(kubectl get secret end2end-account-zenko -o jsonpath='{.data.AccessKeyId}' | base64 -d)")
@@ -65,7 +63,11 @@ load_common() {
6563
load_ctst() {
6664
load_common
6765

66+
# From end2end.yaml
67+
ENV_VARS+=("SUBDOMAIN=$(get_env_var SUBDOMAIN)")
68+
6869
# Hardcoded CTST values
70+
ENV_VARS+=("SSL=false")
6971
ENV_VARS+=("ZENKO_ACCOUNT_NAME=zenko-ctst")
7072
ENV_VARS+=("STORAGE_MANAGER_USER_NAME=ctst_storage_manager")
7173
ENV_VARS+=("STORAGE_ACCOUNT_OWNER_USER_NAME=ctst_storage_account_owner")
@@ -79,7 +81,6 @@ load_ctst() {
7981
# From end2end.yaml
8082
ENV_VARS+=("DR_SUBDOMAIN=$(get_env_var DR_SUBDOMAIN)")
8183
ENV_VARS+=("PROMETHEUS_NAME=$(get_env_var PROMETHEUS_NAME)")
82-
ENV_VARS+=("AZURE_BACKEND_ENDPOINT=$(get_env_var AZURE_BACKEND_ENDPOINT)")
8384
ENV_VARS+=("AZURE_BACKEND_QUEUE_ENDPOINT=$(get_env_var AZURE_BACKEND_QUEUE_ENDPOINT)")
8485
ENV_VARS+=("AZURE_ARCHIVE_BUCKET_NAME=$(get_env_var AZURE_ARCHIVE_BUCKET_NAME)")
8586
ENV_VARS+=("AZURE_ARCHIVE_BUCKET_NAME_2=$(get_env_var AZURE_ARCHIVE_BUCKET_NAME_2)")
@@ -127,13 +128,19 @@ load_ctst() {
127128
ENV_VARS+=("BACKBEAT_API_HOST=$(echo "${cloudserver_config}" | jq -r '.backbeat.host')")
128129
ENV_VARS+=("BACKBEAT_API_PORT=$(echo "${cloudserver_config}" | jq -r '.backbeat.port')")
129130

130-
# From k8s: Service users credentials (individual components)
131-
ENV_VARS+=("BACKBEAT_LCBP_1_CREDS=$(kubectl get secret -l app.kubernetes.io/name=backbeat-lcbp-user-creds,app.kubernetes.io/instance=end2end -o jsonpath='{.items[0].data.backbeat-lifecycle-bp-1\.json}' | base64 -d)")
132-
ENV_VARS+=("BACKBEAT_LCC_1_CREDS=$(kubectl get secret -l app.kubernetes.io/name=backbeat-lcc-user-creds,app.kubernetes.io/instance=end2end -o jsonpath='{.items[0].data.backbeat-lifecycle-conductor-1\.json}' | base64 -d)")
133-
ENV_VARS+=("BACKBEAT_LCOP_1_CREDS=$(kubectl get secret -l app.kubernetes.io/name=backbeat-lcop-user-creds,app.kubernetes.io/instance=end2end -o jsonpath='{.items[0].data.backbeat-lifecycle-op-1\.json}' | base64 -d)")
134-
ENV_VARS+=("BACKBEAT_QP_1_CREDS=$(kubectl get secret -l app.kubernetes.io/name=backbeat-qp-user-creds,app.kubernetes.io/instance=end2end -o jsonpath='{.items[0].data.backbeat-qp-1\.json}' | base64 -d)")
135-
ENV_VARS+=("SORBET_FWD_2_ACCESSKEY=$(kubectl get secret -l app.kubernetes.io/name=sorbet-fwd-creds,app.kubernetes.io/instance=end2end -o jsonpath='{.items[0].data.accessKey}' | base64 -d)")
136-
ENV_VARS+=("SORBET_FWD_2_SECRETKEY=$(kubectl get secret -l app.kubernetes.io/name=sorbet-fwd-creds,app.kubernetes.io/instance=end2end -o jsonpath='{.items[0].data.secretKey}' | base64 -d)")
131+
# From k8s: Service users credentials
132+
local lcbp_creds lcc_creds lcop_creds qp_creds sorbet_ak sorbet_sk
133+
lcbp_creds=$(kubectl get secret -l app.kubernetes.io/name=backbeat-lcbp-user-creds,app.kubernetes.io/instance=end2end -o jsonpath='{.items[0].data.backbeat-lifecycle-bp-1\.json}' | base64 -d)
134+
lcc_creds=$(kubectl get secret -l app.kubernetes.io/name=backbeat-lcc-user-creds,app.kubernetes.io/instance=end2end -o jsonpath='{.items[0].data.backbeat-lifecycle-conductor-1\.json}' | base64 -d)
135+
lcop_creds=$(kubectl get secret -l app.kubernetes.io/name=backbeat-lcop-user-creds,app.kubernetes.io/instance=end2end -o jsonpath='{.items[0].data.backbeat-lifecycle-op-1\.json}' | base64 -d)
136+
qp_creds=$(kubectl get secret -l app.kubernetes.io/name=backbeat-qp-user-creds,app.kubernetes.io/instance=end2end -o jsonpath='{.items[0].data.backbeat-qp-1\.json}' | base64 -d)
137+
sorbet_ak=$(kubectl get secret -l app.kubernetes.io/name=sorbet-fwd-creds,app.kubernetes.io/instance=end2end -o jsonpath='{.items[0].data.accessKey}' | base64 -d)
138+
sorbet_sk=$(kubectl get secret -l app.kubernetes.io/name=sorbet-fwd-creds,app.kubernetes.io/instance=end2end -o jsonpath='{.items[0].data.secretKey}' | base64 -d)
139+
140+
# Build SERVICE_USERS_CREDENTIALS JSON (same format as run-e2e-ctst.sh)
141+
local service_users_creds
142+
service_users_creds=$(echo '{"backbeat-lifecycle-bp-1":'"${lcbp_creds}"',"backbeat-lifecycle-conductor-1":'"${lcc_creds}"',"backbeat-lifecycle-op-1":'"${lcop_creds}"',"backbeat-qp-1":'"${qp_creds}"',"sorbet-fwd-2":{"accessKey":"'"${sorbet_ak}"'","secretKey":"'"${sorbet_sk}"'"}}')
143+
ENV_VARS+=("SERVICE_USERS_CREDENTIALS=${service_users_creds}")
137144
}
138145

139146
# =============================================================================
@@ -163,7 +170,6 @@ load_e2e() {
163170
ENV_VARS+=("GCP_SECRET_KEY=$(get_env_var GCP_SECRET_KEY)")
164171
ENV_VARS+=("GCP_BACKEND_SERVICE_KEY=$(get_env_var GCP_BACKEND_SERVICE_KEY)")
165172
ENV_VARS+=("GCP_BACKEND_SERVICE_EMAIL=$(get_env_var GCP_BACKEND_SERVICE_EMAIL)")
166-
ENV_VARS+=("AZURE_BACKEND_ENDPOINT=$(get_env_var AZURE_BACKEND_ENDPOINT)")
167173
ENV_VARS+=("AWS_ENDPOINT=$(get_env_var AWS_ENDPOINT)")
168174
ENV_VARS+=("AWS_ACCESS_KEY=$(get_env_var AWS_ACCESS_KEY)")
169175
ENV_VARS+=("AWS_SECRET_KEY=$(get_env_var AWS_SECRET_KEY)")
@@ -185,6 +191,8 @@ load_e2e() {
185191

186192
# Derived endpoints
187193
ENV_VARS+=("CLOUDSERVER_HOST=end2end-connector-s3api.default.svc.cluster.local")
194+
ENV_VARS+=("CLOUDSERVER_ENDPOINT=http://end2end-connector-s3api.default.svc.cluster.local:80")
195+
ENV_VARS+=("VAULT_ENDPOINT=http://end2end-management-vault-iam-admin-api:80")
188196
ENV_VARS+=("VAULT_STS_ENDPOINT=http://end2end-connector-vault-sts-api:80")
189197
ENV_VARS+=("BACKBEAT_API_ENDPOINT=http://end2end-management-backbeat-api.default.svc.cluster.local:80")
190198

.github/scripts/end2end/run-e2e-ctst.sh

Lines changed: 21 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,20 @@ VERSION=$(cat ../../../VERSION | grep -Po 'VERSION="\K[^"]*')
2020

2121
# Zenko Environment
2222
ZENKO_ACCOUNT_NAME="zenko-ctst"
23-
ADMIN_ACCESS_KEY_ID=$(kubectl get secret end2end-management-vault-admin-creds.v1 -o jsonpath='{.data.accessKey}' | base64 -d)
24-
ADMIN_SECRET_ACCESS_KEY=$(kubectl get secret end2end-management-vault-admin-creds.v1 -o jsonpath='{.data.secretKey}' | base64 -d)
23+
# ADMIN_ACCESS_KEY_ID=$(kubectl get secret end2end-management-vault-admin-creds.v1 -o jsonpath='{.data.accessKey}' | base64 -d)
24+
# ADMIN_SECRET_ACCESS_KEY=$(kubectl get secret end2end-management-vault-admin-creds.v1 -o jsonpath='{.data.secretKey}' | base64 -d)
2525
ADMIN_PRA_ACCESS_KEY_ID=$(kubectl get secret end2end-pra-management-vault-admin-creds.v1 -o jsonpath='{.data.accessKey}' | base64 -d)
2626
ADMIN_PRA_SECRET_ACCESS_KEY=$(kubectl get secret end2end-pra-management-vault-admin-creds.v1 -o jsonpath='{.data.secretKey}' | base64 -d)
27-
STORAGE_MANAGER_USER_NAME="ctst_storage_manager"
28-
STORAGE_ACCOUNT_OWNER_USER_NAME="ctst_storage_account_owner"
29-
DATA_CONSUMER_USER_NAME="ctst_data_consumer"
30-
DATA_ACCESSOR_USER_NAME="ctst_data_accessor"
27+
28+
# STORAGE_MANAGER_USER_NAME="ctst_storage_manager"
29+
# STORAGE_ACCOUNT_OWNER_USER_NAME="ctst_storage_account_owner"
30+
# DATA_CONSUMER_USER_NAME="ctst_data_consumer"
31+
# DATA_ACCESSOR_USER_NAME="ctst_data_accessor"
32+
3133
VAULT_AUTH_HOST="${ZENKO_NAME}-connector-vault-auth-api.default.svc.cluster.local"
32-
ZENKO_PORT="80"
34+
# ZENKO_PORT="80"
3335
KEYCLOAK_TEST_USER=${OIDC_USERNAME}
34-
KEYCLOAK_TEST_PASSWORD=${OIDC_PASSWORD}
36+
# KEYCLOAK_TEST_PASSWORD=${OIDC_PASSWORD}
3537
KEYCLOAK_TEST_HOST=${OIDC_HOST}
3638
KEYCLOAK_TEST_PORT="80"
3739
KEYCLOAK_TEST_REALM_NAME=${OIDC_REALM}
@@ -45,7 +47,7 @@ BACKBEAT_LCOP_1_CREDS=$(kubectl get secret -l app.kubernetes.io/name=backbeat-lc
4547
BACKBEAT_QP_1_CREDS=$(kubectl get secret -l app.kubernetes.io/name=backbeat-qp-user-creds,app.kubernetes.io/instance=end2end -o jsonpath='{.items[0].data.backbeat-qp-1\.json}' | base64 -d)
4648
SORBET_FWD_2_ACCESSKEY=$(kubectl get secret -l app.kubernetes.io/name=sorbet-fwd-creds,app.kubernetes.io/instance=end2end -o jsonpath='{.items[0].data.accessKey}' | base64 -d)
4749
SORBET_FWD_2_SECRETKEY=$(kubectl get secret -l app.kubernetes.io/name=sorbet-fwd-creds,app.kubernetes.io/instance=end2end -o jsonpath='{.items[0].data.secretKey}' | base64 -d)
48-
SERVICE_USERS_CREDENTIALS=$(echo '{"backbeat-lifecycle-bp-1":'${BACKBEAT_LCBP_1_CREDS}',"backbeat-lifecycle-conductor-1":'${BACKBEAT_LCC_1_CREDS}',"backbeat-lifecycle-op-1":'${BACKBEAT_LCOP_1_CREDS}',"backbeat-qp-1":'${BACKBEAT_QP_1_CREDS}',"sorbet-fwd-2":{"accessKey":"'${SORBET_FWD_2_ACCESSKEY}'","secretKey":"'${SORBET_FWD_2_SECRETKEY}'"}}' | jq -R)
50+
# SERVICE_USERS_CREDENTIALS=$(echo '{"backbeat-lifecycle-bp-1":'${BACKBEAT_LCBP_1_CREDS}',"backbeat-lifecycle-conductor-1":'${BACKBEAT_LCC_1_CREDS}',"backbeat-lifecycle-op-1":'${BACKBEAT_LCOP_1_CREDS}',"backbeat-qp-1":'${BACKBEAT_QP_1_CREDS}',"sorbet-fwd-2":{"accessKey":"'${SORBET_FWD_2_ACCESSKEY}'","secretKey":"'${SORBET_FWD_2_SECRETKEY}'"}}' | jq -R)
4951

5052
# Get KAFKA topics for sorbet
5153
KAFKA_DEAD_LETTER_TOPIC=$(kubectl get secret -l app.kubernetes.io/name=cold-sorbet-config-e2e-azure-archive,app.kubernetes.io/instance=end2end \
@@ -57,8 +59,8 @@ KAFKA_OBJECT_TASK_TOPIC=$(kubectl get secret -l app.kubernetes.io/name=cold-sorb
5759
KAFKA_GC_REQUEST_TOPIC=$(kubectl get secret -l app.kubernetes.io/name=cold-sorbet-config-e2e-azure-archive,app.kubernetes.io/instance=end2end \
5860
-o jsonpath='{.items[0].data.config\.json}' | base64 -di | jq '."kafka-gc-request-topic"' | cut -d "\"" -f 2)
5961

60-
DR_ADMIN_ACCESS_KEY_ID=$(kubectl get secret end2end-pra-management-vault-admin-creds.v1 -o jsonpath='{.data.accessKey}' | base64 -d)
61-
DR_ADMIN_SECRET_ACCESS_KEY=$(kubectl get secret end2end-pra-management-vault-admin-creds.v1 -o jsonpath='{.data.secretKey}' | base64 -d)
62+
# DR_ADMIN_ACCESS_KEY_ID=$(kubectl get secret end2end-pra-management-vault-admin-creds.v1 -o jsonpath='{.data.accessKey}' | base64 -d)
63+
# DR_ADMIN_SECRET_ACCESS_KEY=$(kubectl get secret end2end-pra-management-vault-admin-creds.v1 -o jsonpath='{.data.secretKey}' | base64 -d)
6264

6365
# Extracting kafka host from bacbeat's config
6466
KAFKA_HOST_PORT=$(kubectl get secret -l app.kubernetes.io/name=backbeat-config,app.kubernetes.io/instance=end2end \
@@ -90,13 +92,6 @@ UTILIZATION_SERVICE_PORT="80"
9092
# Setting CTST world params
9193
WORLD_PARAMETERS="$(jq -c <<EOF
9294
{
93-
"subdomain":"${SUBDOMAIN}",
94-
"DRSubdomain":"${DR_SUBDOMAIN}",
95-
"ssl":false,
96-
"port":"${ZENKO_PORT}",
97-
"AccountName":"${ZENKO_ACCOUNT_NAME}",
98-
"AdminAccessKey":"${ADMIN_ACCESS_KEY_ID}",
99-
"AdminSecretKey":"${ADMIN_SECRET_ACCESS_KEY}",
10095
"VaultAuthHost":"${VAULT_AUTH_HOST}",
10196
"NotificationDestination":"${NOTIF_DEST_NAME}",
10297
"NotificationDestinationTopic":"${NOTIF_DEST_TOPIC}",
@@ -111,17 +106,15 @@ WORLD_PARAMETERS="$(jq -c <<EOF
111106
"KafkaHosts":"${KAFKA_HOST_PORT}",
112107
"KafkaAuthHosts":"${KAFKA_AUTH_HOST_PORT}",
113108
"KeycloakUsername":"${KEYCLOAK_TEST_USER}",
114-
"KeycloakPassword":"${KEYCLOAK_TEST_PASSWORD}",
115109
"KeycloakHost":"${KEYCLOAK_TEST_HOST}",
116110
"KeycloakPort":"${KEYCLOAK_TEST_PORT}",
117-
"keycloakRealm":"${KEYCLOAK_TEST_REALM_NAME}",
118-
"keycloakClientId":"${KEYCLOAK_TEST_CLIENT_ID}",
119-
"keycloakGrantType":"${KEYCLOAK_TEST_GRANT_TYPE}",
120-
"StorageManagerUsername":"${STORAGE_MANAGER_USER_NAME}",
121-
"StorageAccountOwnerUsername":"${STORAGE_ACCOUNT_OWNER_USER_NAME}",
122-
"DataConsumerUsername":"${DATA_CONSUMER_USER_NAME}",
123-
"DataAccessorUsername":"${DATA_ACCESSOR_USER_NAME}",
124-
"ServiceUsersCredentials":${SERVICE_USERS_CREDENTIALS},
111+
"KeycloakRealm":"${KEYCLOAK_TEST_REALM_NAME}",
112+
"KeycloakClientId":"${KEYCLOAK_TEST_CLIENT_ID}",
113+
"KeycloakGrantType":"${KEYCLOAK_TEST_GRANT_TYPE}",
114+
"StorageManagerUsername":"ctst_storage_manager",
115+
"StorageAccountOwnerUsername":"ctst_storage_account_owner",
116+
"DataConsumerUsername":"ctst_data_consumer",
117+
"DataAccessorUsername":"ctst_data_accessor",
125118
"AzureAccountName":"${AZURE_ACCOUNT_NAME}",
126119
"AzureAccountKey":"${AZURE_SECRET_KEY}",
127120
"AzureArchiveContainer":"${AZURE_ARCHIVE_BUCKET_NAME}",
@@ -139,8 +132,6 @@ WORLD_PARAMETERS="$(jq -c <<EOF
139132
"KafkaCleanerInterval":"${KAFKA_CLEANER_INTERVAL}",
140133
"SorbetdRestoreTimeout":"${SORBETD_RESTORE_TIMEOUT}",
141134
"TimeProgressionFactor":"${TIME_PROGRESSION_FACTOR}",
142-
"DRAdminAccessKey":"${DR_ADMIN_ACCESS_KEY_ID}",
143-
"DRAdminSecretKey":"${DR_ADMIN_SECRET_ACCESS_KEY}",
144135
"UtilizationServiceHost":"${UTILIZATION_SERVICE_HOST}",
145136
"UtilizationServicePort":"${UTILIZATION_SERVICE_PORT}"
146137
}
@@ -160,7 +151,7 @@ docker run \
160151
--rm \
161152
--network=host \
162153
"${E2E_IMAGE}" /bin/bash \
163-
-c "SUBDOMAIN=${SUBDOMAIN} CONTROL_PLANE_INGRESS_ENDPOINT=${OIDC_ENDPOINT} ACCOUNT=${ZENKO_ACCOUNT_NAME} KEYCLOAK_REALM=${KEYCLOAK_TEST_REALM_NAME} STORAGE_MANAGER=${STORAGE_MANAGER_USER_NAME} STORAGE_ACCOUNT_OWNER=${STORAGE_ACCOUNT_OWNER_USER_NAME} DATA_CONSUMER=${DATA_CONSUMER_USER_NAME} DATA_ACCESSOR=${DATA_ACCESSOR_USER_NAME} /ctst/node_modules/cli-testing/bin/seedKeycloak.sh"; [[ $? -eq 1 ]] && exit 1 || echo 'Keycloak Configured!'
154+
-c "SUBDOMAIN=${SUBDOMAIN} CONTROL_PLANE_INGRESS_ENDPOINT=${OIDC_ENDPOINT} ACCOUNT=${ZENKO_ACCOUNT_NAME} KEYCLOAK_REALM=${KEYCLOAK_TEST_REALM_NAME} STORAGE_MANAGER=ctst_storage_manager STORAGE_ACCOUNT_OWNER=ctst_storage_account_owner DATA_CONSUMER=ctst_data_consumer DATA_ACCESSOR=ctst_data_accessor /ctst/node_modules/cli-testing/bin/seedKeycloak.sh"; [[ $? -eq 1 ]] && exit 1 || echo 'Keycloak Configured!'
164155

165156
# Grant access to Kube API (insecure, only for testing)
166157
kubectl create clusterrolebinding serviceaccounts-cluster-admin \

.github/scripts/end2end/run-e2e-test.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ DESTINATION_ACCOUNT_ID=$(kubectl get secret "end2end-account-${CRR_DESTINATION_A
5252
CRR_DESTINATION_INFO="{\"AccessKeyId\":\"${DESTINATION_ACCESS_KEY}\",\"SecretAccessKey\":\"${DESTINATION_SECRET_KEY}\",\"SessionToken\":\"${DESTINATION_SESSION_TOKEN}\",\"AccountId\":\"${DESTINATION_ACCOUNT_ID}\"}"
5353
OIDC_FULLNAME="${OIDC_FIRST_NAME} ${OIDC_LAST_NAME}"
5454
KEYCLOAK_TEST_USER="${OIDC_USERNAME}-norights"
55-
KEYCLOAK_TEST_PASSWORD=${OIDC_PASSWORD}
5655
KEYCLOAK_TEST_HOST=${OIDC_ENDPOINT}
5756
KEYCLOAK_TEST_PORT="80"
5857
KEYCLOAK_TEST_REALM_NAME=${OIDC_REALM}
@@ -83,7 +82,7 @@ run_e2e_test() {
8382
--env=STAGE=${STAGE} \
8483
--env=CYPRESS_KEYCLOAK_USER_FULLNAME="${OIDC_FULLNAME}" \
8584
--env=CYPRESS_KEYCLOAK_USERNAME=${OIDC_USERNAME} \
86-
--env=CYPRESS_KEYCLOAK_PASSWORD=${OIDC_PASSWORD} \
85+
--env=CYPRESS_KEYCLOAK_PASSWORD=${KEYCLOAK_TEST_PASSWORD} \
8786
--env=CYPRESS_KEYCLOAK_ROOT=${OIDC_ENDPOINT} \
8887
--env=CYPRESS_KEYCLOAK_CLIENT_ID=${OIDC_CLIENT_ID} \
8988
--env=CYPRESS_KEYCLOAK_REALM=${OIDC_REALM} \

.github/workflows/end2end.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ env:
2121
OIDC_REALM: "zenko"
2222
OIDC_CLIENT_ID: "zenko-ui"
2323
OIDC_USERNAME: 'storage_manager'
24-
OIDC_PASSWORD: '123'
24+
KEYCLOAK_TEST_PASSWORD: '123'
2525
OIDC_FIRST_NAME: 'hello'
2626
OIDC_LAST_NAME: 'world'
2727
HTTP_PROXY: ""

tests/ctst/common/common.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export async function cleanS3Bucket(
4040
return;
4141
}
4242
Identity.useIdentity(IdentityEnum.ACCOUNT, world.getSaved<string>('accountName') ||
43-
world.parameters.AccountName);
43+
process.env.ZENKO_ACCOUNT_NAME);
4444
world.resetCommand();
4545
world.addCommandParameter({ bucket: bucketName });
4646
const createdObjects = world.getCreatedObjects();
@@ -125,14 +125,14 @@ async function createBucket(world: Zenko, versioning: string, bucketName: string
125125

126126
Given('a {string} bucket with dot', async function (this: Zenko, versioning: string) {
127127
const preName = this.getSaved<string>('accountName') ||
128-
this.parameters.AccountName || Constants.ACCOUNT_NAME;
128+
process.env.ZENKO_ACCOUNT_NAME || Constants.ACCOUNT_NAME;
129129
await createBucket(this, versioning,
130130
`${preName}.${Constants.BUCKET_NAME_TEST}${Utils.randomString()}`.toLocaleLowerCase());
131131
});
132132

133133
Given('a {string} bucket', async function (this: Zenko, versioning: string) {
134134
const preName = this.getSaved<string>('accountName') ||
135-
this.parameters.AccountName || Constants.ACCOUNT_NAME;
135+
process.env.ZENKO_ACCOUNT_NAME || Constants.ACCOUNT_NAME;
136136
await createBucket(this, versioning,
137137
`${preName}${Constants.BUCKET_NAME_TEST}${Utils.randomString()}`.toLocaleLowerCase());
138138
});

tests/ctst/common/hooks.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ Before({ tags: '@UtilizationAPI', timeout: 1200000 }, async function (scenarioOp
6262

6363
After(async function (this: Zenko, results) {
6464
// Reset any configuration set on the endpoint (ssl, port)
65-
CacheHelper.parameters.ssl = this.parameters.ssl;
66-
CacheHelper.parameters.port = this.parameters.port;
65+
CacheHelper.parameters.ssl = process.env.SSL === 'true';
66+
CacheHelper.parameters.port = process.env.ZENKO_PORT;
6767
if (results.result?.status === 'FAILED') {
6868
this.logger.warn('bucket was not cleaned for test', {
6969
bucket: this.getSaved<string>('bucketName'),

tests/ctst/steps/cloudserverAuth.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ When('the user tries to perform CreateBucket', async function (this: Zenko) {
3636
this.resetCommand();
3737
this.useSavedIdentity();
3838
const preName = this.getSaved<string>('accountName') ||
39-
this.parameters.AccountName || Constants.ACCOUNT_NAME;
39+
process.env.ZENKO_ACCOUNT_NAME || Constants.ACCOUNT_NAME;
4040
const usedBucketName = `${preName}${Constants.BUCKET_NAME_TEST}${Utils.randomString()}`.toLocaleLowerCase();
4141
this.addToSaved('bucketName', usedBucketName);
4242
this.addCommandParameter({ bucket: usedBucketName });

tests/ctst/steps/iam-policies/common.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,13 @@ When('the user tries to perform vault auth {string}', async function (this: Zenk
2929
SecretKey: userCredentials.secretAccessKey,
3030
SessionToken: userCredentials.sessionToken,
3131
ip: this.parameters.VaultAuthHost,
32-
ssl: CacheHelper.parameters ? CacheHelper.parameters.ssl as boolean : undefined,
32+
ssl: CacheHelper.parameters.ssl,
3333
};
3434

3535
switch (action) {
3636
case 'GetAccountInfo':
3737
this.setResult(await VaultAuth.getAccounts([
38-
this.getSaved<string>('accountNameForScenario') || this.parameters.AccountName,
38+
this.getSaved<string>('accountNameForScenario') || process.env.ZENKO_ACCOUNT_NAME,
3939
], null, null, {
4040
// @ts-expect-error accountNames is not generated by CTST yet
4141
accountNames: true,

0 commit comments

Comments
 (0)