Skip to content

Commit afdb07f

Browse files
committed
Mark -sDETERMINISIC as deprecated.
See emscripten-core#26647 and emscripten-core#26648
1 parent 54ef4c6 commit afdb07f

5 files changed

Lines changed: 7 additions & 1 deletion

File tree

ChangeLog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ See docs/process.md for more on how version tagging works.
2222
----------------------
2323
- The minimum version of node supported by the generated code was bumped from
2424
v12.22.0 to v18.3.0. (#26604)
25+
- The DETERMINISIC settings was marked as deprecated ()
2526

2627
5.0.5 - 04/03/26
2728
----------------

site/source/docs/tools_reference/settings_reference.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1787,6 +1787,8 @@ browser's language setting (which would mean you can get different results
17871787
in different browsers, or in the browser and in node).
17881788
Good for comparing builds for debugging purposes (and nothing else).
17891789

1790+
.. note:: This setting is deprecated
1791+
17901792
Default value: false
17911793

17921794
.. _modularize:
@@ -3421,6 +3423,7 @@ these settings please open a bug (or reply to one of the existing bugs).
34213423
- ``ASYNCIFY_EXPORTS``: please use JSPI_EXPORTS instead
34223424
- ``LINKABLE``: under consideration for removal (https://github.com/emscripten-core/emscripten/issues/25262)
34233425
- ``EXPORT_EXCEPTION_HANDLING_HELPERS``: getExceptionMessage is exported anyway when ASSERTIONS or EXCEPTION_STACK_TRACES is set, which are set by default at -O0. At -O1 or above, you can export it separately by -sEXPORTED_RUNTIME_METHODS=getExceptionMessage,decrementExceptionRefcount.
3426+
- ``DETERMINISTIC``: under consideration for removal (https://github.com/emscripten-core/emscripten/issues/26647)
34243427

34253428
.. _legacy-settings:
34263429

src/settings.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1213,6 +1213,7 @@ var SMALL_XHR_CHUNKS = false;
12131213
// in different browsers, or in the browser and in node).
12141214
// Good for comparing builds for debugging purposes (and nothing else).
12151215
// [link]
1216+
// [deprecated]
12161217
var DETERMINISTIC = false;
12171218

12181219
// By default we emit all code in a straightforward way into the output

test/test_other.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12059,7 +12059,7 @@ def test_deterministic(self):
1205912059
printf("JS random: %d\n", EM_ASM_INT({ return Math.random() }));
1206012060
}
1206112061
''')
12062-
self.run_process([EMCC, 'src.c', '-sDETERMINISTIC'] + self.get_cflags())
12062+
self.run_process([EMCC, 'src.c', '-sDETERMINISTIC', '-Wno-deprecated'] + self.get_cflags())
1206312063
one = self.run_js('a.out.js')
1206412064
# ensure even if the time resolution is 1 second, that if we see the real
1206512065
# time we'll see a difference

tools/settings.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@
115115
'ASYNCIFY_EXPORTS': 'please use JSPI_EXPORTS instead',
116116
'LINKABLE': 'under consideration for removal (https://github.com/emscripten-core/emscripten/issues/25262)',
117117
'EXPORT_EXCEPTION_HANDLING_HELPERS': 'getExceptionMessage is exported anyway when ASSERTIONS or EXCEPTION_STACK_TRACES is set, which are set by default at -O0. At -O1 or above, you can export it separately by -sEXPORTED_RUNTIME_METHODS=getExceptionMessage,decrementExceptionRefcount.',
118+
'DETERMINISTIC': 'under consideration for removal (https://github.com/emscripten-core/emscripten/issues/26647)',
118119
}
119120

120121
# Settings that don't need to be externalized when serializing to json because they

0 commit comments

Comments
 (0)