forked from cloudfoundry/cloud_controller_ng
-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathfeature_flags_api_spec.rb
More file actions
436 lines (398 loc) · 14.9 KB
/
feature_flags_api_spec.rb
File metadata and controls
436 lines (398 loc) · 14.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
require 'spec_helper'
require 'rspec_api_documentation/dsl'
RSpec.resource 'Feature Flags', type: %i[api legacy_api] do
let(:admin_auth_header) { admin_headers['HTTP_AUTHORIZATION'] }
authenticated_request
shared_context 'updatable_fields' do
field :enabled, 'The state of the feature flag.', required: true, valid_values: [true, false]
field :error_message, 'The custom error message for the feature flag.', example_values: ['error message']
end
get '/v2/config/feature_flags' do
example 'Get all feature flags' do
VCAP::CloudController::FeatureFlag.create(name: 'private_domain_creation', enabled: false, error_message: 'foobar')
client.get '/v2/config/feature_flags', {}, headers
expect(status).to eq(200)
expect(parsed_response.length).to eq(19)
expect(parsed_response).to include(
{
'name' => 'user_org_creation',
'enabled' => false,
'error_message' => nil,
'url' => '/v2/config/feature_flags/user_org_creation'
}
)
expect(parsed_response).to include(
{
'name' => 'app_bits_upload',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/app_bits_upload'
}
)
expect(parsed_response).to include(
{
'name' => 'app_scaling',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/app_scaling'
}
)
expect(parsed_response).to include(
{
'name' => 'private_domain_creation',
'enabled' => false,
'error_message' => 'foobar',
'url' => '/v2/config/feature_flags/private_domain_creation'
}
)
expect(parsed_response).to include(
{
'name' => 'route_creation',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/route_creation'
}
)
expect(parsed_response).to include(
{
'name' => 'service_instance_creation',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/service_instance_creation'
}
)
expect(parsed_response).to include(
{
'name' => 'set_roles_by_username',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/set_roles_by_username'
}
)
expect(parsed_response).to include(
{
'name' => 'unset_roles_by_username',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/unset_roles_by_username'
}
)
expect(parsed_response).to include(
{
'name' => 'diego_docker',
'enabled' => false,
'error_message' => nil,
'url' => '/v2/config/feature_flags/diego_docker'
}
)
expect(parsed_response).to include(
{
'name' => 'task_creation',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/task_creation'
}
)
expect(parsed_response).to include(
{
'name' => 'space_scoped_private_broker_creation',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/space_scoped_private_broker_creation'
}
)
expect(parsed_response).to include(
{
'name' => 'space_developer_env_var_visibility',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/space_developer_env_var_visibility'
}
)
expect(parsed_response).to include(
{
'name' => 'env_var_visibility',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/env_var_visibility'
}
)
expect(parsed_response).to include(
{
'name' => 'service_instance_sharing',
'enabled' => false,
'error_message' => nil,
'url' => '/v2/config/feature_flags/service_instance_sharing'
}
)
expect(parsed_response).to include(
{
'name' => 'hide_marketplace_from_unauthenticated_users',
'enabled' => false,
'error_message' => nil,
'url' => '/v2/config/feature_flags/hide_marketplace_from_unauthenticated_users'
}
)
expect(parsed_response).to include(
{
'name' => 'resource_matching',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/resource_matching'
}
)
expect(parsed_response).to include(
{
'name' => 'route_sharing',
'enabled' => false,
'error_message' => nil,
'url' => '/v2/config/feature_flags/route_sharing'
}
)
end
end
get '/v2/config/feature_flags/unset_roles_by_username' do
example 'Get the Unset User Roles feature flag' do
explanation <<-HEREDOC
When enabled, Org Managers or Space Managers can remove access roles by username.
In order for this feature to be enabled the CF operator must:
1) Enable the `/ids/users/` endpoint for UAA
2) Create a UAA `cloud_controller_username_lookup` client with the `scim.userids`
authority
HEREDOC
client.get '/v2/config/feature_flags/unset_roles_by_username', {}, headers
expect(status).to eq(200)
expect(parsed_response).to eq(
{
'name' => 'unset_roles_by_username',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/unset_roles_by_username'
}
)
end
end
get '/v2/config/feature_flags/set_roles_by_username' do
example 'Get the Set User Roles feature flag' do
explanation <<-HEREDOC
When enabled, Org Managers or Space Managers can add access roles by username.
In order for this feature to be enabled the CF operator must:
1) Enable the `/ids/users/` endpoint for UAA
2) Create a UAA `cloud_controller_username_lookup` client with the `scim.userids`
authority
HEREDOC
client.get '/v2/config/feature_flags/set_roles_by_username', {}, headers
expect(status).to eq(200)
expect(parsed_response).to eq(
{
'name' => 'set_roles_by_username',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/set_roles_by_username'
}
)
end
end
get '/v2/config/feature_flags/app_bits_upload' do
example 'Get the App Bits Upload feature flag' do
explanation 'When enabled, space developers can upload app bits. When disabled, only admin users can upload app bits'
client.get '/v2/config/feature_flags/app_bits_upload', {}, headers
expect(status).to eq(200)
expect(parsed_response).to eq(
{
'name' => 'app_bits_upload',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/app_bits_upload'
}
)
end
end
get '/v2/config/feature_flags/app_scaling' do
example 'Get the App Scaling feature flag' do
explanation 'When enabled, space developers can perform scaling operations (i.e. change memory, disk or instances). ' \
'When disabled, only admins can perform scaling operations.'
client.get '/v2/config/feature_flags/app_scaling', {}, headers
expect(status).to eq(200)
expect(parsed_response).to eq(
{
'name' => 'app_scaling',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/app_scaling'
}
)
end
end
get '/v2/config/feature_flags/user_org_creation' do
example 'Get the User Org Creation feature flag' do
explanation 'When enabled, any user can create an organization via the API. When disabled, only admin users can create organizations via the API.'
client.get '/v2/config/feature_flags/user_org_creation', {}, headers
expect(status).to eq(200)
expect(parsed_response).to eq(
{
'name' => 'user_org_creation',
'enabled' => false,
'error_message' => nil,
'url' => '/v2/config/feature_flags/user_org_creation'
}
)
end
end
get '/v2/config/feature_flags/private_domain_creation' do
example 'Get the Private Domain Creation feature flag' do
explanation 'When enabled, an organization manager can create private domains for that organization. When disabled, only admin users can create private domains.'
client.get '/v2/config/feature_flags/private_domain_creation', {}, headers
expect(status).to eq(200)
expect(parsed_response).to eq(
{
'name' => 'private_domain_creation',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/private_domain_creation'
}
)
end
end
get '/v2/config/feature_flags/route_creation' do
example 'Get the Route Creation feature flag' do
explanation 'When enabled, a space developer can create routes in a space. When disabled, only admin users can create routes.'
client.get '/v2/config/feature_flags/route_creation', {}, headers
expect(status).to eq(200)
expect(parsed_response).to eq(
{
'name' => 'route_creation',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/route_creation'
}
)
end
end
get '/v2/config/feature_flags/service_instance_creation' do
example 'Get the Service Instance Creation feature flag' do
explanation 'When enabled, a space developer can create service instances in a space. When disabled, only admin users can create service instances.'
client.get '/v2/config/feature_flags/service_instance_creation', {}, headers
expect(status).to eq(200)
expect(parsed_response).to eq(
{
'name' => 'service_instance_creation',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/service_instance_creation'
}
)
end
end
get '/v2/config/feature_flags/diego_docker' do
example 'Get the Diego Docker feature flag' do
explanation 'When enabled, Docker applications are supported by Diego. When disabled, Docker applications will stop running.
It will still be possible to stop and delete them and update their configurations.'
client.get '/v2/config/feature_flags/diego_docker', {}, headers
expect(status).to eq(200)
expect(parsed_response).to eq(
{
'name' => 'diego_docker',
'enabled' => false,
'error_message' => nil,
'url' => '/v2/config/feature_flags/diego_docker'
}
)
end
end
get '/v2/config/feature_flags/task_creation' do
example 'Get the Task Creation feature flag (experimental)' do
explanation 'When enabled, space developers can create tasks. When disabled, only admin users can create tasks.'
client.get '/v2/config/feature_flags/task_creation', {}, headers
expect(status).to eq(200)
expect(parsed_response).to eq(
{
'name' => 'task_creation',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/task_creation'
}
)
end
end
get '/v2/config/feature_flags/space_scoped_private_broker_creation' do
example 'Get the Space Scoped Private Broker Creation feature flag (experimental)' do
explanation 'When enabled, space developers can create space scoped private brokers.
When disabled, only admin users can create create space scoped private brokers.'
client.get '/v2/config/feature_flags/space_scoped_private_broker_creation', {}, headers
expect(status).to eq(200)
expect(parsed_response).to eq(
{
'name' => 'space_scoped_private_broker_creation',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/space_scoped_private_broker_creation'
}
)
end
end
get '/v2/config/feature_flags/space_developer_env_var_visibility' do
example 'Get the Space Developer Environment Variable Visibility feature flag (experimental)' do
explanation 'When enabled, space developers can perform a get on the /v2/apps/:guid/env endpoint,' \
'and both space developers and space supporters can perform a get on the /v3/apps/:guid/env and /v3/apps/:guid/environment_variables endpoints.
When disabled, neither space developers nor space supporters can access these endpoints.'
client.get '/v2/config/feature_flags/space_developer_env_var_visibility', {}, headers
expect(status).to eq(200)
expect(parsed_response).to eq(
{
'name' => 'space_developer_env_var_visibility',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/space_developer_env_var_visibility'
}
)
end
end
get '/v2/config/feature_flags/env_var_visibility' do
example 'Get the Environment Variable Visibility feature flag' do
explanation 'When enabled, all users can read environment variables.
When disabled, only admin can read environment variables.'
client.get '/v2/config/feature_flags/env_var_visibility', {}, headers
expect(status).to eq(200)
expect(parsed_response).to eq(
{
'name' => 'env_var_visibility',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/env_var_visibility'
}
)
end
end
get '/v2/config/feature_flags/service_instance_sharing' do
example 'Get the Service Instance Sharing feature flag (experimental)' do
explanation 'When enabled, space developers can share service instances with other spaces.
When disabled, space developers can not share service instances with other spaces.'
client.get '/v2/config/feature_flags/service_instance_sharing', {}, headers
expect(status).to eq(200)
expect(parsed_response).to eq(
{
'name' => 'service_instance_sharing',
'enabled' => false,
'error_message' => nil,
'url' => '/v2/config/feature_flags/service_instance_sharing'
}
)
end
end
put '/v2/config/feature_flags/:name' do
include_context 'updatable_fields'
example 'Set a feature flag' do
client.put '/v2/config/feature_flags/user_org_creation', fields_json, headers
expect(status).to eq(200)
expect(parsed_response).to eq(
{
'name' => 'user_org_creation',
'enabled' => true,
'error_message' => nil,
'url' => '/v2/config/feature_flags/user_org_creation'
}
)
end
end
end