fix: correct no flag behavior

Author: WillieRuemmele

src/commands/agent/preview/start.ts

@@ -15,7 +15,7 @@
  */
 
 import { Flags, SfCommand } from '@salesforce/sf-plugins-core';
-import { Lifecycle, Messages } from '@salesforce/core';
+import { Lifecycle, Messages, SfError } from '@salesforce/core';
 import { Agent, ProductionAgent, ScriptAgent } from '@salesforce/agents';
 import { createCache } from '../../../previewSessionStore.js';
 
@@ -38,26 +38,34 @@ export default class AgentPreviewStart extends SfCommand<AgentPreviewStartResult
     'api-name': Flags.string({
       summary: messages.getMessage('flags.api-name.summary'),
       char: 'n',
-      exclusive: ['authoring-bundle'],
+      exactlyOne: ['api-name', 'authoring-bundle'],
     }),
     'authoring-bundle': Flags.string({
       summary: messages.getMessage('flags.authoring-bundle.summary'),
-      exclusive: ['api-name'],
+      exactlyOne: ['api-name', 'authoring-bundle'],
     }),
     'use-live-actions': Flags.boolean({
       summary: messages.getMessage('flags.use-live-actions.summary'),
       exclusive: ['simulate-actions'],
-      dependsOn: ['authoring-bundle'],
     }),
     'simulate-actions': Flags.boolean({
       summary: messages.getMessage('flags.simulate-actions.summary'),
       exclusive: ['use-live-actions'],
-      dependsOn: ['authoring-bundle'],
     }),
   };
 
   public async run(): Promise<AgentPreviewStartResult> {
     const { flags } = await this.parse(AgentPreviewStart);
+
+    // Validate: authoring-bundle requires exactly one mode flag
+    // (mutual exclusion of mode flags handled by 'exclusive' in flag definitions)
+    if (flags['authoring-bundle'] && !flags['use-live-actions'] && !flags['simulate-actions']) {
+      throw new SfError(
+        'When using --authoring-bundle, you must specify either --use-live-actions or --simulate-actions.',
+        'MissingModeFlag'
+      );
+    }
+
     const conn = flags['target-org'].getConnection(flags['api-version']);
     const useLiveActions = flags['use-live-actions'];
     const simulateActions = flags['simulate-actions'];
@@ -68,7 +76,7 @@ export default class AgentPreviewStart extends SfCommand<AgentPreviewStartResult
 
     // Set mode for authoring bundles based on which flag was specified
     if (agent instanceof ScriptAgent) {
-      agent.preview.setMockMode(useLiveActions ? 'Live Test' : 'Mock');
+      agent.preview.setMockMode(simulateActions ? 'Mock' : 'Live Test');
     }
 
     // Warn if mode flags are used with published agents (they have no effect)

test/commands/agent/preview/start.test.ts

@@ -102,5 +102,39 @@ describe('agent preview start', () => {
       expect(setMockModeStub.calledOnce).to.be.true;
       expect(setMockModeStub.firstCall.args[0]).to.equal('Live Test');
     });
+
+    it('should throw error when using --authoring-bundle without mode flag', async () => {
+      try {
+        await AgentPreviewStart.run(['--authoring-bundle', 'MyAgent', '--target-org', 'test@org.com']);
+        expect.fail('Should have thrown an error');
+      } catch (error: unknown) {
+        expect((error as Error).message).to.include('must specify either --use-live-actions or --simulate-actions');
+      }
+    });
+
+    it('should throw error when using both mode flags together', async () => {
+      try {
+        await AgentPreviewStart.run([
+          '--authoring-bundle',
+          'MyAgent',
+          '--use-live-actions',
+          '--simulate-actions',
+          '--target-org',
+          'test@org.com',
+        ]);
+        expect.fail('Should have thrown an error');
+      } catch (error: unknown) {
+        expect((error as Error).message).to.match(/cannot also be provided when using/i);
+      }
+    });
+
+    it('should throw error when neither --api-name nor --authoring-bundle is provided', async () => {
+      try {
+        await AgentPreviewStart.run(['--use-live-actions', '--target-org', 'test@org.com']);
+        expect.fail('Should have thrown an error');
+      } catch (error: unknown) {
+        expect((error as Error).message).to.match(/exactly one|api-name|authoring-bundle/i);
+      }
+    });
   });
 });