fix(subgraphs): prevent cols.sort() from mutating array, misaligning values in batched inserts

ryanwaits · ryanwaits · commit e4a7d47cd525 · 2026-03-31T11:09:51.000-05:00
diff --git a/packages/subgraphs/src/runtime/context.ts b/packages/subgraphs/src/runtime/context.ts
@@ -217,8 +217,8 @@ export class SubgraphContext {
       data[c] === "NOW()" ? "NOW()" : escapeLiteral(data[c]),
     );
 
-    // Batch key: table + sorted columns + upsert key signature
-    const batchKey = `${op.table}:${cols.sort().join(",")}:${upsertKeys?.sort().join(",") ?? ""}`;
+    // Batch key: table + sorted columns + upsert key signature (spread to avoid mutating cols)
+    const batchKey = `${op.table}:${[...cols].sort().join(",")}:${upsertKeys ? [...upsertKeys].sort().join(",") : ""}`;
 
     return { data, cols, vals, upsertKeys, batchKey };
   }

Original file line number	Diff line number	Diff line change
`@@ -217,8 +217,8 @@ export class SubgraphContext {`
`217`	`217`	`data[c] === "NOW()" ? "NOW()" : escapeLiteral(data[c]),`
`218`	`218`	`);`
`219`	`219`
`220`		`- // Batch key: table + sorted columns + upsert key signature`
`221`		- const batchKey = `${op.table}:${cols.sort().join(",")}:${upsertKeys?.sort().join(",") ?? ""}`;
	`220`	`+ // Batch key: table + sorted columns + upsert key signature (spread to avoid mutating cols)`
	`221`	+ const batchKey = `${op.table}:${[...cols].sort().join(",")}:${upsertKeys ? [...upsertKeys].sort().join(",") : ""}`;
`222`	`222`
`223`	`223`	`return { data, cols, vals, upsertKeys, batchKey };`
`224`	`224`	`}`