Why does save-analysis use it's own syntax?

[jendrikw]

In the save-analysis file of liballoc, the value/signature of

rust/src/liballoc/task.rs

Line 98 in 14b9665

pub unsafe fn local_waker<W: Wake + 'static>(wake: Arc<W>) -> LocalWaker {

looks like this: fn <W> (wake: Arc<W>) -> LocalWaker, which is not valid rust code.

There is little documentation available for the save-analysis, but as far as I understood it, the value field is supposed to represent the signature. In most other languages, the signature of a function doesn't include the parameter names.

For consistency, I think it would be better if the field would either include the function name or leave of the parameter names.

Edit: I want this to be able to parse the string with syn, which expects either a name for the function or no names for the arguments.

[csmoe]

fn local_waker<W>(wake: Arc<W>) -> LocalWaker

it's valid generic function, cc https://doc.rust-lang.org/reference/items/functions.html#generic-functions

[jendrikw]

I know, but the function name local_waker is missing from the string, so it's impossible to parse it.

[csmoe]

@jendrikw oops, I misunderstood your comments, sorry.

[steveklabnik]

Triage: a long time later, save-analysis is eventually on the way out, and so this might just be moot.

[marmeladema]

I think its been fixed by #73155 at least for function signature as this issue is about. I can probably be closed.
cc @Xanewok

[jyn514]

Save-analysis has been removed from the compiler.