-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
cfg(bootstrap) should not be allowed in library/ #142150
Copy link
Copy link
Closed
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Description
Metadata
Metadata
Assignees
Labels
C-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Type
Fields
Give feedbackNo fields configured for issues without a type.
#141925 removed
bootstrapfrom the allowed-cfg list for the library crates, but./xstill passes in extra flags that allowcfg(bootstrap). This has already led to newcfg(bootstrap)slipping in, and it has led to issue in tooling that buildslibrary/crates outside of./x(such as https://github.com/rust-lang/miri-test-libstd/).Cc @Urgau @cuviper @onur-ozkan @workingjubilee