Skip to content

Commit dcb22ed

Browse files
authored
Unrolled build for #153230
Rollup merge of #153230 - jieyouxu:rustfmt-reviewers-for-rustfmt, r=ytmimi Roll rustfmt reviewers for in-tree rustfmt Noticed in #153229 (comment), where because `src/tools/rustfmt` has no corresponding `[assign.owners]` entry, it rolls one of the `fallback` reviewers (Mark and me) which is needless indirection, since if it rolls to Mark, Mark will have to reroll again. This _can_ also be ```toml "/src/tools/rustfmt" = ["rustfmt", "rustfmt-contributors"] ``` which corresponds to https://github.com/orgs/rust-lang/teams/rustfmt and https://github.com/orgs/rust-lang/teams/rustfmt-contributors respectively. I will double-check with triagebot team if we can use review rotation toggles for `rust-lang/rust` in-tree `rustfmt` specifically. Discussion: [#t-rustfmt > review queue tracking for rust-lang/rust in-tree rustfmt](https://rust-lang.zulipchat.com/#narrow/channel/357797-t-rustfmt/topic/review.20queue.20tracking.20for.20rust-lang.2Frust.20in-tree.20rustfmt/with/576498516) ### Unresolved question - ~~Do we want to start everyone off as off-rotation? Or on-rotation? I plan to start conservatively by preserving existing effective status, which is everyone off-rotation.~~ We will match existing defaults, with everyone starting off as off-team-rotation. r? @ytmimi
2 parents a3ac2f2 + c9763e7 commit dcb22ed

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

triagebot.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1620,6 +1620,7 @@ dep-bumps = [
16201620
"/src/tools/rustdoc" = ["rustdoc"]
16211621
"/src/tools/rustdoc-js" = ["rustdoc"]
16221622
"/src/tools/rustdoc-themes" = ["rustdoc"]
1623+
"/src/tools/rustfmt" = ["rustfmt", "rustfmt-contributors"]
16231624
"/src/tools/tidy" = ["bootstrap"]
16241625
"/src/tools/x" = ["bootstrap"]
16251626
"/src/tools/rustdoc-gui-test" = ["bootstrap"]

0 commit comments

Comments
 (0)