WIP Support #[track_caller] on closures.Closes #74042.

Author: anp

src/librustc_codegen_ssa/mir/block.rs

@@ -808,11 +808,12 @@ impl<'a, 'tcx, Bx: BuilderMethods<'a, 'tcx>> FunctionCx<'a, 'tcx, Bx> {
         let needs_location =
             instance.map_or(false, |i| i.def.requires_caller_location(self.cx.tcx()));
         if needs_location {
-            assert_eq!(
-                fn_abi.args.len(),
-                args.len() + 1,
-                "#[track_caller] fn's must have 1 more argument in their ABI than in their MIR",
-            );
+            // FIXME figure out the right number of args for closures
+            // assert_eq!(
+            //     fn_abi.args.len(),
+            //     args.len() + 1,
+            //     "#[track_caller] fn's must have 1 more argument in their ABI than in their MIR",
+            // );
             let location = self.get_caller_location(&mut bx, fn_span);
             debug!(
                 "codegen_call_terminator({:?}): location={:?} (fn_span {:?})",

src/librustc_passes/check_attr.rs

@@ -154,7 +154,7 @@ impl CheckAttrVisitor<'tcx> {
                 .emit();
                 false
             }
-            Target::Fn | Target::Method(..) | Target::ForeignFn => true,
+            Target::Closure | Target::Fn | Target::ForeignFn | Target::Method(..) => true,
             _ => {
                 struct_span_err!(
                     self.tcx.sess,

src/librustc_typeck/collect.rs

@@ -2413,7 +2413,7 @@ fn codegen_fn_attrs(tcx: TyCtxt<'_>, id: DefId) -> CodegenFnAttrs {
         } else if attr.check_name(sym::thread_local) {
             codegen_fn_attrs.flags |= CodegenFnAttrFlags::THREAD_LOCAL;
         } else if attr.check_name(sym::track_caller) {
-            if tcx.is_closure(id) || tcx.fn_sig(id).abi() != abi::Abi::Rust {
+            if !tcx.is_closure(id) && tcx.fn_sig(id).abi() != abi::Abi::Rust {
                 struct_span_err!(tcx.sess, attr.span, E0737, "`#[track_caller]` requires Rust ABI")
                     .emit();
             }

src/test/ui/rfc-2091-track-caller/track-caller-closure.rs

@@ -0,0 +1,54 @@
+// run-pass
+
+#![feature(stmt_expr_attributes)]
+
+use std::panic::Location;
+
+#[track_caller]
+fn tracked() -> &'static Location<'static> {
+    let get_location = #[track_caller] || Location::caller();
+    get_location()
+}
+
+fn untracked_wrapper() -> (&'static Location<'static>, u32) {
+    let get_location = #[track_caller] || Location::caller();
+    (get_location(), line!())
+}
+
+fn nested_tracked() -> (&'static Location<'static>, u32) {
+    (tracked(), line!())
+}
+
+fn main() {
+    let get_location = #[track_caller] || Location::caller();
+    let (location, line) = (get_location(), line!());
+    assert_eq!(location.file(), file!());
+    assert_eq!(location.line(), line);
+
+    let (tracked, tracked_line) = (tracked(), line!());
+    assert_eq!(tracked.file(), file!());
+    assert_eq!(tracked.line(), tracked_line);
+
+    let (nested, nested_line) = untracked_wrapper();
+    assert_eq!(nested.file(), file!());
+    assert_eq!(nested.line(), nested_line);
+
+    let (contained, contained_line) = nested_tracked();
+    assert_eq!(contained.file(), file!());
+    assert_eq!(contained.line(), contained_line);
+
+    fn pass_to_ptr_call<T, R>(f: fn(T) -> R, x: T) -> R {
+        f(x)
+    }
+
+    let (get_location_w_n, line_from_shim) = (#[track_caller] |_| Location::caller(), line!());
+
+    let (location_with_arg, line_with_arg) = (get_location_w_n(3), line!());
+    assert_eq!(location_with_arg.file(), file!());
+    assert_eq!(location_with_arg.line(), line_with_arg);
+
+    let location_with_shim = pass_to_ptr_call(get_location_w_n, 5);
+    // FIXME make the closure's "def site" point to this file
+    assert_eq!(location_with_shim.file(), file!());
+    assert_eq!(location_with_shim.line(), line_from_shim);
+}