Add regression test for #3135

Author: GuillaumeGomez

gui-tests/crate-pages.goml

@@ -1,32 +1,20 @@
 // Checks that the "crate pages" have all the same style (ie: not centered).
+include: "utils.goml"
 go-to: |DOC_PATH| + "/crate/sysinfo"
+// Big enough to have "margin: auto" to kick in.
+set-window-size: (1300, 800)
 
 store-value: (tabs_menu_selector, ".description-container .pure-menu-horizontal ul.pure-menu-list")
 store-value: (current_tab, 1)
-
-define-function: (
-    "check-tab",
-    [tab_name, click_next],
-    block {
-        // We check the tab's name is the one expected.
-        assert-text: (|tabs_menu_selector| + " > li a.pure-menu-active .title", |tab_name|)
-        // We check it also matches the one we clicked.
-        assert: |tabs_menu_selector| + " > li:nth-of-type(" + |current_tab| + ") a.pure-menu-active"
-        // We ensure that the content of the page is not centered.
-        assert: "body:not(.centered)"
-        assert-css: ("div.container", {"margin": "0px"})
-        if: (|click_next|, block {
-            store-value: (current_tab, |current_tab| + 1)
-            click: |tabs_menu_selector| + " > li:nth-of-type(" + |current_tab| + ")"
-        })
-    }
-)
+store-value: (nb_tabs, 4)
 
 // If this assert fails, it means we added new entries for this menu so this test needs to be
 // updated.
-assert-count: (|tabs_menu_selector| + " > li", 4)
+assert-count: (|tabs_menu_selector| + " > li", |nb_tabs|)
+
+call-function: ("check-tab-not-centered", {"tab_name": " Crate", "click_next": true})
+call-function: ("check-tab-not-centered", {"tab_name": " Source", "click_next": true})
+call-function: ("check-tab-not-centered", {"tab_name": " Builds", "click_next": true})
+call-function: ("check-tab-not-centered", {"tab_name": "Feature flags", "click_next": false})
 
-call-function: ("check-tab", {"tab_name": " Crate", "click_next": true})
-call-function: ("check-tab", {"tab_name": " Source", "click_next": true})
-call-function: ("check-tab", {"tab_name": " Builds", "click_next": true})
-call-function: ("check-tab", {"tab_name": "Feature flags", "click_next": false})
+assert: |nb_tabs| == |current_tab|

gui-tests/release-pages.goml

@@ -0,0 +1,22 @@
+// Checks that the "release pages" have all the same style (ie: centered).
+include: "utils.goml"
+go-to: |DOC_PATH| + "/releases"
+// Big enough to have "margin: auto" to kick in.
+set-window-size: (1300, 800)
+
+store-value: (tabs_menu_selector, ".description-container .pure-menu-horizontal ul.pure-menu-list")
+store-value: (current_tab, 1)
+store-value: (nb_tabs, 6)
+
+// If this assert fails, it means we added new entries for this menu so this test needs to be
+// updated.
+assert-count: (|tabs_menu_selector| + " > li", |nb_tabs|)
+
+call-function: ("check-tab-centered", {"tab_name": "Recent", "click_next": true})
+call-function: ("check-tab-centered", {"tab_name": "Stars", "click_next": true})
+call-function: ("check-tab-centered", {"tab_name": "Recent Failures", "click_next": true})
+call-function: ("check-tab-centered", {"tab_name": "Failures By Stars", "click_next": true})
+call-function: ("check-tab-centered", {"tab_name": "Activity", "click_next": true})
+call-function: ("check-tab-centered", {"tab_name": "Queue", "click_next": false})
+
+assert: |nb_tabs| == |current_tab|

gui-tests/utils.goml

@@ -0,0 +1,56 @@
+define-function: (
+    "check-tab",
+    [tab_name, centered, click_next],
+    block {
+        // We check the tab's name is the one expected.
+        assert-text: (|tabs_menu_selector| + " > li a.pure-menu-active .title", |tab_name|)
+        // We check it also matches the one we clicked.
+        assert: |tabs_menu_selector| + " > li:nth-of-type(" + |current_tab| + ") a.pure-menu-active"
+
+        // We ensure that the content of the page is (not?) centered.
+        if: (|centered|, block {
+            assert: "body.centered"
+            assert-css: ("div.container", {
+                "margin-top": "0px",
+                "margin-bottom": "0px",
+                "margin-left": "70px",
+                "margin-right": "70px",
+            })
+        })
+        else: block {
+            assert: "body:not(.centered)"
+            assert-css: ("div.container", {
+                "margin-top": "0px",
+                "margin-bottom": "0px",
+                "margin-left": "0px",
+                "margin-right": "0px",
+            })
+        }
+        if: (|click_next|, block {
+            store-value: (current_tab, |current_tab| + 1)
+            click: |tabs_menu_selector| + " > li:nth-of-type(" + |current_tab| + ")"
+        })
+    }
+)
+
+define-function: (
+    "check-tab-centered",
+    [tab_name, click_next],
+    block {
+        call-function: (
+            "check-tab",
+            {"tab_name": |tab_name|, "centered": true, "click_next": |click_next|},
+        )
+    }
+)
+
+define-function: (
+    "check-tab-not-centered",
+    [tab_name, click_next],
+    block {
+        call-function: (
+            "check-tab",
+            {"tab_name": |tab_name|, "centered": false, "click_next": |click_next|},
+        )
+    }
+)